From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, sarosh.arif@emumba.com
Subject: Re: [dpdk-dev] [PATCH] usertools: check 0-division with hugepage size
Date: Thu, 11 Feb 2021 15:18:27 -0800 [thread overview]
Message-ID: <20210211151827.4e2b7d33@hermes.local> (raw)
In-Reply-To: <20210211220544.55439-1-thomas@monjalon.net>
On Thu, 11 Feb 2021 23:05:44 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> The default page size can be None, and the page size from user request
> can be 0 kB if lower than 1024. In these cases, a division will fail.
> In order to avoid a Python exception, the page size is checked
> and an error message "Invalid page size" is printed.
>
> A similar error message is printed in set_hugepages()
> if the size is not supported, except at this stage the message can be
> completed with "Valid page sizes".
> Unfortunately the first check is too early to print such information.
>
> A third error message can be printed in a different place (get_memsize)
> in case of a format issue, e.g. a negative size.
> The function get_memsize() is also used for total requested size,
> so the error message "not a valid page size" was potentially wrong.
> This message is replaced with the more general "is not a valid size".
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2021-02-11 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 22:05 Thomas Monjalon
2021-02-11 23:18 ` Stephen Hemminger [this message]
2021-02-12 11:27 ` Burakov, Anatoly
2021-02-12 11:34 ` Thomas Monjalon
2021-03-21 9:09 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-03-23 11:30 ` Burakov, Anatoly
2021-03-25 17:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211151827.4e2b7d33@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).