From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id BA87DA0547;
Fri, 12 Feb 2021 15:30:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3858A22A28F;
Fri, 12 Feb 2021 15:30:04 +0100 (CET)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by mails.dpdk.org (Postfix) with ESMTP id 2B82122A28E
for <dev@dpdk.org>; Fri, 12 Feb 2021 15:30:01 +0100 (CET)
IronPort-SDR: MtFeJP0KdS5nuJwMzGiJvOseb9BKh1PJXzSWVejJShPKCTgDcBj3gO8IMtixNX93LaDfSfcQn7
HKF0N3BSnA3w==
X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="178915750"
X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="178915750"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
12 Feb 2021 06:30:01 -0800
IronPort-SDR: vZ1c0RSMbDwXa8QkxGtgEwIL5CfoprkEvIXKmDfAA8IeykPQyOUQKCKN3PDKLyN3/HgLbanb14
zSGIm2miAYAQ==
X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="398004329"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.22.2])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
12 Feb 2021 06:29:59 -0800
Date: Fri, 12 Feb 2021 14:29:56 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, john.mcnamara@intel.com,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Message-ID: <20210212142956.GC970@bricha3-MOBL.ger.corp.intel.com>
References: <20210212110431.940131-1-thomas@monjalon.net>
<20210212141739.1013748-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210212141739.1013748-1-thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2] doc: add pmdinfogen rewrite to release
notes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Feb 12, 2021 at 03:17:39PM +0100, Thomas Monjalon wrote:
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> The build tool pmdinfogen was rewritten in DPDK 21.02,
> adding Windows support.
> There is a new build-time dependency: pyelftools.
>
> Fixes: f0f93a7adfee ("buildtools: use Python pmdinfogen")
> Fixes: 6b19edcb663c ("build: enable pmdinfogen for Windows")
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
One additional suggestion below if you want to take it too.
> ---
> doc/guides/rel_notes/release_21_02.rst | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
> index 64e220f2ac..99a559479b 100644
> --- a/doc/guides/rel_notes/release_21_02.rst
> +++ b/doc/guides/rel_notes/release_21_02.rst
> @@ -20,6 +20,12 @@ DPDK Release 21.02
> make doc-guides-html
> xdg-open build/doc/html/guides/rel_notes/release_21_02.html
>
> +.. note::
> +
> + A dependency has been added for building DPDK on Linux or FreeBSD:
> + the Python module pyelftools (version 0.22 or greater),
> + often packaged as python3-pyelftools, is required.
This module can also be installed using pip for python3 e.g.
"pip3 install pyelftools".
> +
>
> New Features
> ------------
> @@ -180,6 +186,13 @@ New Features
> tests and output graphed results to PDF files.
> See the :doc:`../tools/cryptoperf` guide for more details.
>
> +* **Added Windows support to pmdinfogen.**
> +
> + PMD information strings were added for Windows as well as for other OS.
> + Extracting them from Windows DLL is not yet supported.
> + The build-time tool pmdinfogen was rewritten in Python,
> + thus libelf dependency was replaced with pyelftools as new build dependency.
> +
> * **Added support for build-time checking of header includes.**
>
> A new build option ``check_includes`` has been added, which, when enabled,
> --
> 2.30.0
>