From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC8ABA0547; Fri, 12 Feb 2021 22:25:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33D5422A22B; Fri, 12 Feb 2021 22:25:03 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 28ED8227F63 for ; Fri, 12 Feb 2021 22:25:01 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id g20so518069plo.2 for ; Fri, 12 Feb 2021 13:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=dsB3pZIihtwC/UA9enZfJHswH8Tr3Zf2PDbuNbug1D4=; b=X81wPaORGGhmmJoxMp6ZUlhjLbxnGCUnQnnS4Y6Iok4MXBliMIQAsdktseRfDn6Koi RhZJ/2lJfx579nxth6v1JoGh/JCqifYDoH+pG2mGyEhWdjq2trzs9g03sB+9hbAENX0U akDIvre10ckLDFNrX2XtZNV+z6pl+FlsS8eb8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=dsB3pZIihtwC/UA9enZfJHswH8Tr3Zf2PDbuNbug1D4=; b=HrYacZA99lwDs3mmn800rzm0rXH1JNMYJr7kKlajbXuvRoUUDXMORl41fB7H9jb87i 28B7IxVmA5K+oXMuF4PW4jF0K1K061gWF5AMH0NHGDXc/xXAeNCK8ouvHxxnDNdj5lwu Dv2V9us8OwBSGVUeAB2H/GMR4nJ1T0G7oi2EvpHTb3ESD2L0Y+3mjoOd/G1ajRpz+eCF SzEW3Whor8DfLlCKWoWBSBFw6wkoPJW4b4L7Zv3LihAFf7ugxddBJ0pzNTccyUOMrC4Z t09O+WGq062dAvS1waPO6SvZA4k2+9VYmBNjQjoYUsaS5POtqmPEMHOYeoNQEs36TVZ0 CztQ== X-Gm-Message-State: AOAM532iHiG3zMJRuXg8aqp8IvEKDyMVMCUGDN+VQG1T0fnoXMKAbzhQ 3QWfnUYTgsrytXeAZzglk7FQTg== X-Google-Smtp-Source: ABdhPJyGMXNP1lkaPidFt+jd5hV7K2DfNWniDAdxYdKUWqDrCFM7ZhkFKr5LU6uhbnjICLr9GbPqfQ== X-Received: by 2002:a17:902:c602:b029:e2:8422:ffbb with SMTP id r2-20020a170902c602b02900e28422ffbbmr4449610plr.49.1613165100037; Fri, 12 Feb 2021 13:25:00 -0800 (PST) Received: from localhost.localdomain ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id o190sm10311962pga.2.2021.02.12.13.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 13:24:59 -0800 (PST) From: Lance Richardson To: Xiaoyun Li Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Fri, 12 Feb 2021 16:24:52 -0500 Message-Id: <20210212212452.200471-1-lance.richardson@broadcom.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210211194434.172212-1-lance.richardson@broadcom.com> References: <20210211194434.172212-1-lance.richardson@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000c83a9805bb2a4440" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH 21.05 v3] app/testpmd: display rxq desc used count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000c83a9805bb2a4440 Content-Transfer-Encoding: 8bit Add support for displaying the count of used (filled by hardware but not yet processed by the driver) descriptors on a receive queue in order to allow the rte_eth_dev rx_queue_count() API to be exercised and tested. Signed-off-by: Lance Richardson --- v3: - Made terminology more consistent betwen commit log, title, and documentation text. - Added long help text for new command. v2: - Changed command syntax from "show port <> rxq <> count" to "show port <> rxq <> desc used count". - Expanded description to clarify the meaning of the displayed descriptor count. - Fixed header line length. app/test-pmd/cmdline.c | 87 +++++++++++++++++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 2 files changed, 94 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 59722d268..8eb2a48ef 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -246,6 +246,10 @@ static void cmd_help_long_parsed(void *parsed_result, "show port (port_id) rxq|txq (queue_id) desc (desc_id) status" " Show status of rx|tx descriptor.\n\n" + "show port (port_id) rxq (queue_id) desc used count\n" + " Show current number of filled receive" + " packet descriptors.\n\n" + "show port (port_id) macs|mcast_macs" " Display list of mac addresses added to port.\n\n" @@ -16699,6 +16703,88 @@ cmdline_parse_inst_t cmd_show_rx_tx_desc_status = { }, }; +/* *** display rx queue desc used count *** */ +struct cmd_show_rx_queue_desc_used_count_result { + cmdline_fixed_string_t cmd_show; + cmdline_fixed_string_t cmd_port; + cmdline_fixed_string_t cmd_rxq; + cmdline_fixed_string_t cmd_desc; + cmdline_fixed_string_t cmd_used; + cmdline_fixed_string_t cmd_count; + portid_t cmd_pid; + portid_t cmd_qid; +}; + +static void +cmd_show_rx_queue_desc_used_count_parsed(void *parsed_result, + __rte_unused struct cmdline *cl, + __rte_unused void *data) +{ + struct cmd_show_rx_queue_desc_used_count_result *res = parsed_result; + int rc; + + if (!rte_eth_dev_is_valid_port(res->cmd_pid)) { + printf("invalid port id %u\n", res->cmd_pid); + return; + } + + rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid); + if (rc < 0) { + printf("Invalid queueid = %d\n", res->cmd_qid); + return; + } + printf("Used desc count = %d\n", rc); +} + +cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_show = + TOKEN_STRING_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_show, "show"); +cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_port = + TOKEN_STRING_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_port, "port"); +cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_pid = + TOKEN_NUM_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_pid, RTE_UINT16); +cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_rxq = + TOKEN_STRING_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_rxq, "rxq"); +cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_qid = + TOKEN_NUM_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_qid, RTE_UINT16); +cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_desc = + TOKEN_STRING_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_count, "desc"); +cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_used = + TOKEN_STRING_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_count, "used"); +cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_count = + TOKEN_STRING_INITIALIZER + (struct cmd_show_rx_queue_desc_used_count_result, + cmd_count, "count"); +cmdline_parse_inst_t cmd_show_rx_queue_desc_used_count = { + .f = cmd_show_rx_queue_desc_used_count_parsed, + .data = NULL, + .help_str = "show port rxq desc used count", + .tokens = { + (void *)&cmd_show_rx_queue_desc_used_count_show, + (void *)&cmd_show_rx_queue_desc_used_count_port, + (void *)&cmd_show_rx_queue_desc_used_count_pid, + (void *)&cmd_show_rx_queue_desc_used_count_rxq, + (void *)&cmd_show_rx_queue_desc_used_count_qid, + (void *)&cmd_show_rx_queue_desc_used_count_desc, + (void *)&cmd_show_rx_queue_desc_used_count_used, + (void *)&cmd_show_rx_queue_desc_used_count_count, + NULL, + }, +}; + /* Common result structure for set port ptypes */ struct cmd_set_port_ptypes_result { cmdline_fixed_string_t set; @@ -17098,6 +17184,7 @@ cmdline_parse_ctx_t main_ctx[] = { (cmdline_parse_inst_t *)&cmd_config_tx_metadata_specific, (cmdline_parse_inst_t *)&cmd_show_tx_metadata, (cmdline_parse_inst_t *)&cmd_show_rx_tx_desc_status, + (cmdline_parse_inst_t *)&cmd_show_rx_queue_desc_used_count, (cmdline_parse_inst_t *)&cmd_set_raw, (cmdline_parse_inst_t *)&cmd_show_set_raw, (cmdline_parse_inst_t *)&cmd_show_set_raw_all, diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index a45910b81..703dead0c 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -266,6 +266,13 @@ Display information for a given port's RX/TX descriptor status:: testpmd> show port (port_id) (rxq|txq) (queue_id) desc (desc_id) status +show rxq desc used count +~~~~~~~~~~~~~~~~~~~~~~~~ + +Display the number of receive packet descriptors currently filled by hardware +and ready to be processed by the driver on a given RX queue:: + + testpmd> show port (port_id) rxq (queue_id) desc used count show config ~~~~~~~~~~~ -- 2.25.1 --000000000000c83a9805bb2a4440--