From: Kevin Laatz <kevin.laatz@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Kevin Laatz <kevin.laatz@intel.com>
Subject: [dpdk-dev] [PATCH] usertools/dpdk-telemetry: add file-prefix cmdline argument
Date: Mon, 15 Feb 2021 15:50:51 +0000 [thread overview]
Message-ID: <20210215155051.8659-1-kevin.laatz@intel.com> (raw)
Currently the dpdk-telemetry.py script connects to all running DPDK apps
consecutively. With the addition of this file-prefix argument, we can limit
the amount of information returned providing improved consumability and
precision to the user.
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
usertools/dpdk-telemetry.py | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py
index 181859658f..8cafcf74a6 100755
--- a/usertools/dpdk-telemetry.py
+++ b/usertools/dpdk-telemetry.py
@@ -12,6 +12,7 @@
import glob
import json
import readline
+import argparse
# global vars
TELEMETRY_VERSION = "v2"
@@ -70,14 +71,20 @@ def readline_complete(text, state):
return matches[state]
+def get_dpdk_runtime_dir(fp):
+ """ Get the DPDK runtime directory based on the file-prefix and user """
+ if (os.getuid() == 0):
+ return "/var/run/dpdk/{}".format(fp)
+ return "{}/dpdk/{}".format(os.environ.get('XDG_RUNTIME_DIR', '/tmp'), fp)
+
+
readline.parse_and_bind('tab: complete')
readline.set_completer(readline_complete)
readline.set_completer_delims(readline.get_completer_delims().replace('/', ''))
-# Path to sockets for processes run as a root user
-for f in glob.glob('/var/run/dpdk/*/dpdk_telemetry.%s' % TELEMETRY_VERSION):
- handle_socket(f)
-# Path to sockets for processes run as a regular user
-for f in glob.glob('%s/dpdk/*/dpdk_telemetry.%s' %
- (os.environ.get('XDG_RUNTIME_DIR', '/tmp'), TELEMETRY_VERSION)):
- handle_socket(f)
+parser = argparse.ArgumentParser()
+parser.add_argument("-f", "--file_prefix", \
+ help="Provide file_prefix for DPDK runtime directory", default="rte")
+args = parser.parse_args()
+rdir = get_dpdk_runtime_dir(args.file_prefix)
+handle_socket("{}/dpdk_telemetry.{}".format(rdir, TELEMETRY_VERSION))
--
2.25.1
next reply other threads:[~2021-02-15 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:50 Kevin Laatz [this message]
2021-02-15 16:08 ` Bruce Richardson
2021-02-15 18:00 ` Kevin Laatz
2021-02-16 10:44 ` Burakov, Anatoly
2021-02-16 10:56 ` [dpdk-dev] [PATCH v2] " Kevin Laatz
2021-02-16 11:50 ` [dpdk-dev] [PATCH v3] " Kevin Laatz
2021-03-25 16:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215155051.8659-1-kevin.laatz@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).