From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06A63A054D; Tue, 16 Feb 2021 21:36:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1171F1607E5; Tue, 16 Feb 2021 21:36:10 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 0A8C41607D1 for ; Tue, 16 Feb 2021 21:36:07 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id u11so6115797plg.13 for ; Tue, 16 Feb 2021 12:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=3Wo47tI1VUFWCXaudhypvJgBtWXPyxvPP/YWpBZyf0o=; b=Lkxm24yGPFvIs9WCAfeE+rT2hZCKJECIqu8uqcI9pEQsqy3D1RCsujdpohkK4aZFHE XC5A0gLsagrPbVAFKM7HPJlJ9Wm2chpdN6Rp1kimbUu73i3r6MfDsOP7dpCCKRDlDm7Y i6sWGC1KAmsDthVPQJkUBvOUd6Rs9U+QUV/Y/O8IHC1gNSbdLh/oaz//M6VH40kk4JlX MscSDIXV+5p9O2S6+sjlw7F4q2wzciku2e1Qnx6kdHBb4R6YNzvTgG2G3IQddEmBYg1l HJSCd/bVPb83aerDbzxxoXf1fQiKuKCfxOyxtRF6sUC/fqLkhh8T6qtui+abJ2hq8OIB C+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=3Wo47tI1VUFWCXaudhypvJgBtWXPyxvPP/YWpBZyf0o=; b=NPwC+yInjy2iNWQgZajMYIY8PI2zIgCvuilGfQDQnqUf02uj0BCBq+AFSvPGC4Mq8n /TF8MFFTQwnEi6FALVJcc41FkB9RwYymAyxLzeKpYzc9B3ts8Fae6TwYHt420U+HlUWc 4TrLqs9x+Oh4NCkrNCOL2onvVfRYahIUj4iuw0/pyiQ27cf/CVB7CIjUUHM+ijPx97+R broZQ1dgA0gwstrYWg1JcshYLV9+EkQUDOGCiz/8fZsEBSJQPOWZhThrXVV3M+c6AqYl PT08zPLPhLeerlrsuK8ytyEvSN1L/2BZp4xheawxyvab/s5oEArEbFoEKavKJY9Ii7+0 laVQ== X-Gm-Message-State: AOAM5309ZVsvGB/eA0NaCyaVZgq4T6tNTYnoI7ItSw8/O3QSWKU4aJM0 TUj8UdlWgUpmYDAcdj3iRYzB0o40Z+004w== X-Google-Smtp-Source: ABdhPJwCfb/O1H7RaXl/Dnxt9GjsP+X0blFvvBiUri4BGBLJFvRl5nZfGkAEyxcBGdWN/wS5HX04Ow== X-Received: by 2002:a17:90a:517:: with SMTP id h23mr5900394pjh.108.1613507766071; Tue, 16 Feb 2021 12:36:06 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id u17sm11371pgh.72.2021.02.16.12.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 12:36:05 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer Date: Tue, 16 Feb 2021 12:35:35 -0800 Message-Id: <20210216203540.29290-11-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210216203540.29290-1-aboyer@pensando.io> References: <20210216203540.29290-1-aboyer@pensando.io> In-Reply-To: <20210204195853.13411-1-aboyer@pensando.io> References: <20210204195853.13411-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH v2 10/15] net/ionic: log queue counters when tearing down X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This improves debuggability. To see the logs, use EAL arg: --log-level=pmd.net.ionic,debug While here, stop counting fragments, but start counting mtods. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 13 +++++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h index ba1471b6e9..5885aa1546 100644 --- a/drivers/net/ionic/ionic_lif.h +++ b/drivers/net/ionic/ionic_lif.h @@ -34,7 +34,6 @@ struct ionic_tx_stats { uint64_t stop; uint64_t no_csum; uint64_t tso; - uint64_t frags; }; struct ionic_rx_stats { @@ -44,6 +43,7 @@ struct ionic_rx_stats { uint64_t bad_cq_status; uint64_t no_room; uint64_t bad_len; + uint64_t mtods; }; #define IONIC_QCQ_F_INITED BIT(0) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 89b37733b6..fa92fca2f5 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -123,9 +123,13 @@ void __rte_cold ionic_dev_tx_queue_release(void *tx_queue) { struct ionic_tx_qcq *txq = tx_queue; + struct ionic_tx_stats *stats = &txq->stats; IONIC_PRINT_CALL(); + IONIC_PRINT(DEBUG, "TX queue %u pkts %ju tso %ju", + txq->qcq.q.index, stats->packets, stats->tso); + ionic_lif_txq_deinit(txq); ionic_qcq_free(&txq->qcq); @@ -410,7 +414,6 @@ ionic_tx_tso(struct ionic_tx_qcq *txq, struct rte_mbuf *txm, offset = 0; data_iova = rte_mbuf_data_iova(txm_seg); left = txm_seg->data_len; - stats->frags++; while (left > 0) { next_addr = rte_cpu_to_le_64(data_iova + offset); @@ -508,7 +511,6 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm, while (txm_seg != NULL) { elem->len = txm_seg->data_len; elem->addr = rte_cpu_to_le_64(rte_mbuf_data_iova(txm_seg)); - stats->frags++; elem++; txm_seg = txm_seg->next; } @@ -657,12 +659,18 @@ void __rte_cold ionic_dev_rx_queue_release(void *rx_queue) { struct ionic_rx_qcq *rxq = rx_queue; + struct ionic_rx_stats *stats; if (!rxq) return; IONIC_PRINT_CALL(); + stats = &rxq->stats; + + IONIC_PRINT(DEBUG, "RX queue %u pkts %ju mtod %ju", + rxq->qcq.q.index, stats->packets, stats->mtods); + ionic_rx_empty(rxq); ionic_lif_rxq_deinit(rxq); @@ -887,6 +895,7 @@ ionic_rx_clean(struct ionic_rx_qcq *rxq, pkt_type = RTE_PTYPE_L2_ETHER_ARP; else pkt_type = RTE_PTYPE_UNKNOWN; + stats->mtods++; break; } } -- 2.17.1