From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1600DA054A; Thu, 18 Feb 2021 22:23:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDD2E40040; Thu, 18 Feb 2021 22:23:08 +0100 (CET) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 8E2404003D for ; Thu, 18 Feb 2021 22:23:07 +0100 (CET) Received: by mail-lj1-f174.google.com with SMTP id g1so2499520ljj.13 for ; Thu, 18 Feb 2021 13:23:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aREppfSvaYr1bSYAfPt3zrb8jXKCQ5v2pXDeHbdoJ1g=; b=h4QxmHt/8eZCRxKwZlqN8Mk2XH0KuvOh9g/HBy8Y+j4G5Za61qZ3W1eXAd7mxoR2Au PBj5lgGOleSvmD2ivYM8xpT8Sl2poxt/wrth/CGs8zhL2qAIkJNko+aMWoDjpSzF6BhI o8I0Jt7/0CPPPQa+17OxOnzJ3RyuTWOnyp/bAK9866VcSxp5CyoVpYGuqpkAbnwncILI g1szdfz7wzFwhxf6pOOojesSHkgWs2idvmi1q2NeoAolPFqUsofo3YaHlsf/NsW2/UB4 DAOspqnldIO1qJ6FrX0aKs/YNJP0jPJmfGUOnLAm4HlzkQ/QAKMQWra7tGy+Pb4Fl7nU MhEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aREppfSvaYr1bSYAfPt3zrb8jXKCQ5v2pXDeHbdoJ1g=; b=DYq5LmOOL0Srn0s+by5xAMN+P2roEgzzW9oTGKwammNFFrr8ZzFUInT+WynPDV3tZu 10sPRaC4TR61lFMPHE4RpHBw56PkYVKJyutEB4+yg2pj/9OU0GTPGLScgNcrgTLk9GMm gGpjny8SD+kdCeWawKQ0Y7fmhTrPHImhP0mymA2VW+opf8vzxzLbC60upvqs+j9VASdE i/p5yb1GkXaud5ppjLy76NnyJ//mujuCvmcIhTgwYx/OL+IRHS7eN9LHM50voAeY873K ae0PdUUjOLcXtTCp/XPLuRR6vOv62mrL9Xe6wDakx3mexZ/mmBHD1CcF8xdtagn5awVp T2zw== X-Gm-Message-State: AOAM530Di3A75nZjBGLMftI5IVRtyBi3r0F+IHVWhTgiWqgk27cYtHPN QImsnWUoPNz0EWdeERnUIqQ= X-Google-Smtp-Source: ABdhPJxq2bk4RW/mvdC0EN3/ZosJhiNd6kmH8uSaPTGCoRP3FQwAiRSB3H5fGEQOHjZUOtxQkybYSg== X-Received: by 2002:a05:6512:3601:: with SMTP id f1mr3518003lfs.114.1613683387119; Thu, 18 Feb 2021 13:23:07 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id a10sm153495lfd.135.2021.02.18.13.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 13:23:06 -0800 (PST) Date: Fri, 19 Feb 2021 00:23:05 +0300 From: Dmitry Kozlyuk To: Ranjit Menon Cc: Khoa To , dev@dpdk.org, pallavi.kadam@intel.com Message-ID: <20210219002305.0000e93d@sovereign> In-Reply-To: <2da301ca-f163-97a7-692d-2cfeecf819bd@intel.com> References: <1613626805-9313-1-git-send-email-khot@linux.microsoft.com> <1613673602-6291-1-git-send-email-khot@linux.microsoft.com> <2da301ca-f163-97a7-692d-2cfeecf819bd@intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 18 Feb 2021 10:53:54 -0800, Ranjit Menon wrote: > > + > > + if (get_device_pci_address(dev_info, &device_info_data, &addr) != 0) > > + continue; > > + > > + if (rte_pci_ignore_device(&addr)) > > + continue; > > + > > ret = pci_scan_one(dev_info, &device_info_data); > > if (ret == ERROR_SUCCESS) > > found_device++; > I think this change can be made inside the pci_scan_one() function where > we already call > > get_device_pci_address(). +1, even to place this check before other actions in pci_scan_one().