From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C01AA034F; Sun, 21 Feb 2021 02:28:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33B7140696; Sun, 21 Feb 2021 02:28:41 +0100 (CET) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mails.dpdk.org (Postfix) with ESMTP id 5AFE140683 for ; Sun, 21 Feb 2021 02:28:40 +0100 (CET) Received: by mail-lj1-f175.google.com with SMTP id v6so44509677ljh.9 for ; Sat, 20 Feb 2021 17:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dabZV/QpiO6hazMAgb/o8Ly0n9ja0mcjN+WZ26BR0EY=; b=rBbG/gVu5k2J71TWmJ3d6Nor1uw3adMvPjVJsfCFLni/Z8Iaw743PSGOZkUbeKQoIJ jixNKbf7jpj8/EsdkIuKLEmQhuhuu9JdkwXyUF+sV08PtFBBu4ulfoEyttaRfiKfMsxH N9mrbqFaxVOcfDcV/yHx+e92TPPAL4hoVOOWxD7BnakV0pf70fzHW0uvXNdNjUYjCdgk BLe26x2ewGXg35bOnvxyg+RQMaL0bk0Tuhh9E2r7esywcLm8oNepUBF4P9YCR6REmvT4 tZIsyZ4F/CJmYVgJT1xDi3wimJZqxeq8HRu7MWbDk0t4XslSzKbcDy/4r79b2SUTH9mb eKnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dabZV/QpiO6hazMAgb/o8Ly0n9ja0mcjN+WZ26BR0EY=; b=ByvzN+eCOffniiT+cSxqKtZ5liZQzxaEIMEIpjNaYdvQjQPMKNNfkmBkXgdNZBKhpa 1CZO519XRoqVPbDqjW/abyr9o/LrWWXDSHmlk2QYQ1gosq93OAQvwdMNOpE4zvqoMj3U wCFh38y7VVYegYpevJrEp4vUDKZIGz3dY5HKMyPvvA4Uwdo6ifpb2HD93NMhdEL4PMMF dFK/sp3UJmuVjG8k4B4dedNwbkG4c7nhLUrg26fcO5cvkA2W2gaMzMkoGTrtk89QeKT5 A+JUw035UI69zZJ9cyHGN9OGBwccDPAAWfS356eAGNQgKVfNglkROER9lmEdrIyp/PD2 dStA== X-Gm-Message-State: AOAM533ftNQTcuy/eivOj0GYOsvwiRJxSHFoD7dFmvQoL4vWVDIGqAXm 8rJlGV05Z+TFAnS0wX3FCB03KZ3Wpqhq+0qm X-Google-Smtp-Source: ABdhPJxNEkx6s0C0qiXXuryvh4KxUNd8zZqnRDLnvZ3fwzxM5GdjZ7wV1aiIxsBOuA0kNydZu9M7Dg== X-Received: by 2002:a05:6512:3383:: with SMTP id h3mr9760509lfg.273.1613870919647; Sat, 20 Feb 2021 17:28:39 -0800 (PST) Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id d5sm1401666lfe.232.2021.02.20.17.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 17:28:39 -0800 (PST) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Tyler Retzlaff , Nick Connolly , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Date: Sun, 21 Feb 2021 04:28:24 +0300 Message-Id: <20210221012831.14643-1-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210220232910.772-1-dmitry.kozliuk@gmail.com> References: <20210220232910.772-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/7] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Windows, rte_os.h contains a small POSIX compatibility set of functions and macros. Exposing it from EAL can break consumer own POSIX compatibility layer and is against standards in general. First define required wrappers, then fix POSIX dependencies in Windows-enabled libraries and drivers, then eliminate POSIX symbols from Windows EAL API. Commits are arranged so that they all compile and are limited in scope; patches 5, 6, 7 can be squashed if needed. No "Fixes" tags, because it's really an enhancement, preventing issues rather then solving direct ones. v2: fix compilation issues in 3/7 and 6/7. Dmitry Kozlyuk (7): eal: add wrappers for POSIX string functions eal: add macro for maximum path length eal: add sleep API eal: add asprintf() internal wrapper lib: remove POSIX dependencies drivers: remove POSIX dependencies eal/windows: do not expose POSIX symbols doc/guides/rel_notes/release_21_05.rst | 9 ++ drivers/bus/pci/private.h | 2 +- drivers/bus/vdev/vdev.c | 4 +- drivers/bus/vdev/vdev_params.c | 3 +- drivers/common/mlx5/mlx5_common_pci.c | 4 +- drivers/common/mlx5/mlx5_common_pci.h | 1 + drivers/net/i40e/i40e_ethdev.c | 56 +++++------ lib/librte_cmdline/cmdline.c | 1 + lib/librte_eal/common/eal_common_config.c | 2 +- lib/librte_eal/common/eal_common_dev.c | 6 +- lib/librte_eal/common/eal_common_devargs.c | 7 +- lib/librte_eal/common/eal_common_errno.c | 4 + lib/librte_eal/common/eal_common_fbarray.c | 8 +- lib/librte_eal/common/eal_common_lcore.c | 2 +- lib/librte_eal/common/eal_common_log.c | 5 +- lib/librte_eal/common/eal_common_options.c | 42 ++++---- lib/librte_eal/common/eal_common_timer.c | 5 +- lib/librte_eal/common/eal_common_trace.c | 2 +- lib/librte_eal/common/eal_common_trace_ctf.c | 4 +- .../common/eal_common_trace_utils.c | 13 +-- lib/librte_eal/common/eal_filesystem.h | 8 +- lib/librte_eal/common/eal_hugepages.h | 2 +- lib/librte_eal/common/eal_internal_cfg.h | 2 +- lib/librte_eal/common/eal_private.h | 23 +++++ lib/librte_eal/common/eal_trace.h | 2 +- lib/librte_eal/freebsd/include/rte_os.h | 6 +- lib/librte_eal/include/rte_string_fns.h | 42 ++++++++ lib/librte_eal/include/rte_thread.h | 11 +++ lib/librte_eal/linux/include/rte_os.h | 6 +- lib/librte_eal/rte_eal_exports.def | 2 + lib/librte_eal/unix/rte_thread.c | 10 +- lib/librte_eal/version.map | 3 + lib/librte_eal/windows/eal.c | 30 ++++++ lib/librte_eal/windows/eal_thread.c | 9 +- lib/librte_eal/windows/include/dirent.h | 21 ++-- lib/librte_eal/windows/include/rte_os.h | 99 ++----------------- lib/librte_ethdev/rte_class_eth.c | 2 +- lib/librte_ethdev/rte_ethdev.c | 2 +- lib/librte_kvargs/rte_kvargs.c | 17 ++-- 39 files changed, 270 insertions(+), 207 deletions(-) -- 2.29.2