[dpdk-dev] [PATCH] dpdk-kmods: nvme support for netuio on Windows

[dpdk-dev] [PATCH] dpdk-kmods: nvme support for netuio on Windows

[Nick Connolly]

Enable the netuio driver for an NVMe storage controller on Windows.
Add the class ID 010802 and identify the device as
 'netuio NVM Express Controller'.

Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
---
 windows/netuio/netuio.inf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 7121a0f..06d2d23 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -28,6 +28,7 @@ HKR,,Icon,,-5
 
 [Standard.NT$ARCH$]
 %netuio.DeviceDesc%=netuio_Device, Root\netuio
+%netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
 
 [netuio_Device.NT]
 CopyFiles=Drivers_Dir
@@ -71,6 +72,7 @@ Provider = "Vendor"
 ClassName = "Windows UIO"
 DiskName = "DPDK netUIO Installation Disk"
 netuio.DeviceDesc = "netuio Device"
+netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
 netuio.SVCDESC = "netuio Service"
 
 [DMAr.reg]
-- 
2.25.1

Re: [dpdk-dev] [PATCH] dpdk-kmods: nvme support for netuio on Windows

[Nick Connolly]

Hi Harini,

As discussed - attaching zip file with images showing the NVMe device 
being attached under netuio management and the output from the spdk 
identify command.

Thanks,
Nick

On 25/01/2021 17:39, Nick Connolly wrote:
> Enable the netuio driver for an NVMe storage controller on Windows.
> Add the class ID 010802 and identify the device as
>   'netuio NVM Express Controller'.
>
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> ---
>   windows/netuio/netuio.inf | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index 7121a0f..06d2d23 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -28,6 +28,7 @@ HKR,,Icon,,-5
>   
>   [Standard.NT$ARCH$]
>   %netuio.DeviceDesc%=netuio_Device, Root\netuio
> +%netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
>   
>   [netuio_Device.NT]
>   CopyFiles=Drivers_Dir
> @@ -71,6 +72,7 @@ Provider = "Vendor"
>   ClassName = "Windows UIO"
>   DiskName = "DPDK netUIO Installation Disk"
>   netuio.DeviceDesc = "netuio Device"
> +netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
>   netuio.SVCDESC = "netuio Service"
>   
>   [DMAr.reg]

[dpdk-dev] [PATCH v2] dpdk-kmods: nvme support for netuio on Windows

[Nick Connolly]

Enable the netuio driver for an NVMe storage controller on Windows.
Add the class ID 010802 and identify the device as
 'netuio NVM Express Controller'.

Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
---
v2:
* rebase to latest netuio.inf

 windows/netuio/netuio.inf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 666a69c..64872de 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -28,6 +28,7 @@ HKR,,Icon,,-5
 
 [Standard.NT$ARCH$]
 %netuio.DeviceDesc%=netuio_Device, Root\netuio
+%netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
 %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
 %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
 %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
@@ -85,6 +86,7 @@ Provider = "Vendor"
 ClassName = "Windows UIO"
 DiskName = "DPDK netUIO Installation Disk"
 netuio.DeviceDesc = "netuio Device"
+netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
 Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
 Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
 Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"
-- 
2.25.1

Re: [dpdk-dev] [PATCH v2] dpdk-kmods: nvme support for netuio on Windows

[Thomas Monjalon]

23/02/2021 18:35, Nick Connolly:
> Enable the netuio driver for an NVMe storage controller on Windows.
> Add the class ID 010802 and identify the device as
>  'netuio NVM Express Controller'.
> 
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>

I don't understand why there is no review.

Applied, thanks.

Re: [dpdk-dev] [PATCH v2] dpdk-kmods: nvme support for netuio on Windows

[Nick Connolly]

Hi Thomas,

> I don't understand why there is no review.
>
> Applied, thanks.

Reviewed by the team at Microsoft who were happy, but looks like a 
formal 'Acked-by' didn't get sent.

Thanks,
Nick

Re: [dpdk-dev] [PATCH v2] dpdk-kmods: nvme support for netuio on Windows

[Thomas Monjalon]

17/03/2021 10:46, Nick Connolly:
> Hi Thomas,
> 
> > I don't understand why there is no review.
> >
> > Applied, thanks.
> 
> Reviewed by the team at Microsoft who were happy, but looks like a 
> formal 'Acked-by' didn't get sent.

To everybody working on Windows DPDK:
It is good to have meetings, but please avoid private discussions,
and do not forget the public communications.
It will make the community work smoother, thanks.