From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AF1AA054F; Wed, 24 Feb 2021 16:55:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18C6F4069B; Wed, 24 Feb 2021 16:55:02 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 1EFED40040 for <dev@dpdk.org>; Wed, 24 Feb 2021 16:55:01 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id e6so1720186pgk.5 for <dev@dpdk.org>; Wed, 24 Feb 2021 07:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Q+aCUrMBR4L8qRhPRab2ZIR6AdBmJzUIKoS3wQRPz4=; b=RfYDhBL+XZoJT1O/3KOzhV9rtXWB4zHtpMwypzD/+g8WMixNWUdtlXpgoKOMig756V J+yFulGX0OY/Gb73C7+gkQSTwJgMc+NmmgdqqLbLHrMMdxxVjmO6SeqP1+qi4sQLX5zp ZLpZ6nR7WxAIAxs1PudbwbOoGdKyLsw4pKCcnVPqL1wdJ7TZoCwM2E5h9QG/B25D3x2Y GoLTSPHnPBKWTzGg/HkT9o4F3IQ/sYaIgbxxElcsg7JmUGSGPZ1V0hXqSKOqJSGVBPOU NFMSC3/iHMwukZVbyFEDPuZT3irBNKi0obJuRaGSPDTwwPbFBVbR//uB1xeDfhg491cH UDrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Q+aCUrMBR4L8qRhPRab2ZIR6AdBmJzUIKoS3wQRPz4=; b=CXYSCRQ+u4THv5WaMHEegDswheiOXYhS3GxCcFXhPKizaDoIsC2g3aZGiSnSnxRJZ6 t0npRAjX0BBC5oAAQJu1W0cR0SwAY5niQE4/24asgdh/LySLCS5yjwLolqkE+nVzF7BJ SuHHWkHprNaJuRFhHrrLxv5dD4l42tZLnlTH6xVwn+iqwxNR4Ooo7V2cgCCov1hc0fGS 7VjSULbzBbDDNn1znua5BcYAatJHizX+Z4gQCfHF+iiHzacT+TOWSJ3Gr5SWvmXrD/mT tfKvsg8CjWto2m9DRDIzSolytkRbn2sCPuz381XyOCmh0h2cdxTLkWD3G5hMGZMQuwv8 Mcbw== X-Gm-Message-State: AOAM533EsWQLtvF7e066WflZeHNpfxdfIHpt/NhHRRZUuz4LHUwT2Y5j 0RlTmtQTLqpf2pNnG9vCjmZxAw== X-Google-Smtp-Source: ABdhPJwDeIq++g8yWDjrFx9PWrdcvUn/c4Zv8sEEDYDunUh/1pFxPqum8a46DcMYyMOVVdzKk4bexw== X-Received: by 2002:aa7:947d:0:b029:1ed:a78c:59ea with SMTP id t29-20020aa7947d0000b02901eda78c59eamr14708298pfq.36.1614182100181; Wed, 24 Feb 2021 07:55:00 -0800 (PST) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id g141sm3196045pfb.67.2021.02.24.07.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 07:54:59 -0800 (PST) Date: Wed, 24 Feb 2021 07:54:56 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Igor Ryzhov <iryzhov@nfware.com> Cc: Elad Nachman <eladv6@gmail.com>, Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org> Message-ID: <20210224075456.361a1b14@hermes.local> In-Reply-To: <CAF+s_Fza_63+4jL9anOEuBPgt+0WdicaWu9JfUOmr3vK-Qkr2Q@mail.gmail.com> References: <20201126144613.4986-1-eladv6@gmail.com> <20210223134504.699-1-eladv6@gmail.com> <CAF+s_Fza_63+4jL9anOEuBPgt+0WdicaWu9JfUOmr3vK-Qkr2Q@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, 24 Feb 2021 15:49:49 +0300 Igor Ryzhov <iryzhov@nfware.com> wrote: > This looks more like a hack than an actual fix to me. > > After this commit: > "ip link set up" is sent to the userspace with unlocked rtnl_lock > "ip link set down" is sent to the userspace with locked rtnl_lock Calling userspace with rtnl held is a recipe for disaster