From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCA76A034F; Thu, 25 Feb 2021 12:57:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E563406B4; Thu, 25 Feb 2021 12:57:27 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 920D040692 for ; Thu, 25 Feb 2021 12:57:26 +0100 (CET) IronPort-SDR: kXtdtH52jm38NCWKIjd+JL2Ry8tKRNYlgSs4k+WQ5IB22vnHTmXF3J7Z91ug74l5xPDzGK6cVM NTiwUqG00TjA== X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="185625789" X-IronPort-AV: E=Sophos;i="5.81,205,1610438400"; d="scan'208";a="185625789" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2021 03:57:25 -0800 IronPort-SDR: sOSiPkMNMkbMk+gCdKI5zptpgK4yYMo/4DKWRkxUEGXoUu1PfN/ecZ2YeqmRVNjGtpdSB6Gr0+ ihdmdWwI3u8A== X-IronPort-AV: E=Sophos;i="5.81,205,1610438400"; d="scan'208";a="404248469" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.64]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 25 Feb 2021 03:57:23 -0800 Date: Thu, 25 Feb 2021 11:57:20 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: David Marchand , dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20210225115720.GA1546@bricha3-MOBL.ger.corp.intel.com> References: <20210225111457.32540-1-david.marchand@redhat.com> <2047120.oh6f1MFQjV@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2047120.oh6f1MFQjV@thomas> Subject: Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > 25/02/2021 12:14, David Marchand: > > Add a check on versioned symbol duplicates in map files. > > > > Signed-off-by: David Marchand > > --- > > This check could be added to buildtools/check-symbols.sh so that > > regular developers catch the issue when building their changes... > > Opinions? > > In general I am against adding developer tools in the build process, > because it could cause more issues for normal users. > Is this really likely to cause issues for normal users? If we add this to the build process any issues will surely be caught be developers before merge.