From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map
Date: Thu, 25 Feb 2021 12:05:53 +0000 [thread overview]
Message-ID: <20210225120553.GB1546@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <5625752.shjfW9zSB4@thomas>
On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote:
> 25/02/2021 12:57, Bruce Richardson:
> > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote:
> > > 25/02/2021 12:14, David Marchand:
> > > > Add a check on versioned symbol duplicates in map files.
> > > >
> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > > ---
> > > > This check could be added to buildtools/check-symbols.sh so that
> > > > regular developers catch the issue when building their changes...
> > > > Opinions?
> > >
> > > In general I am against adding developer tools in the build process,
> > > because it could cause more issues for normal users.
> > >
> > Is this really likely to cause issues for normal users?
>
> Yes because some users will have a different shell,
> or other weird setup we don't think about yet.
>
I think it unlikely, but ok.
Now that meson (from version 0.53 onwards) has a "filesystem" module, with
an "exists" function, we can perhaps look to introduce a "developer mode"
build again, based off the presence of the .git folder. Alternatively, we
could make "developer mode" a regular meson option rather than trying to be
too smart about it. [Or combine both and have developer mode option with
"enabled"/"disabled"/"auto-detect" values]
/Bruce
next prev parent reply other threads:[~2021-02-25 12:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:14 David Marchand
2021-02-25 11:41 ` Thomas Monjalon
2021-02-25 11:57 ` Bruce Richardson
2021-02-25 12:01 ` Thomas Monjalon
2021-02-25 12:05 ` Bruce Richardson [this message]
2021-02-25 13:14 ` Thomas Monjalon
2021-05-05 14:30 ` [dpdk-dev] [PATCH v2 1/2] " David Marchand
2021-05-05 14:30 ` [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode David Marchand
2021-05-06 9:31 ` Kinsella, Ray
2021-05-12 20:24 ` Thomas Monjalon
2021-05-12 20:38 ` Thomas Monjalon
2021-05-13 7:06 ` David Marchand
2021-05-13 8:34 ` [dpdk-dev] [PATCH v3 1/3] devtools: fix orphan symbols check with busybox David Marchand
2021-05-13 8:34 ` [dpdk-dev] [PATCH v3 2/3] devtools: catch symbol duplicates in version map David Marchand
2021-05-13 8:34 ` [dpdk-dev] [PATCH v3 3/3] build: check symbol maps in developer mode David Marchand
2021-05-19 10:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225120553.GB1546@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).