From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBF53A034F; Thu, 25 Feb 2021 13:06:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7362D160826; Thu, 25 Feb 2021 13:06:09 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 8819A406B4 for ; Thu, 25 Feb 2021 13:06:08 +0100 (CET) IronPort-SDR: 18YiGUwLa6KkaKDoc7P4tUZ4DvfMb1SC90hfkqwrP7QzPNHWDi3B3X+aY0sZhYnzEHfsnPyzQH 2qQJ5VWUABZg== X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="164723367" X-IronPort-AV: E=Sophos;i="5.81,205,1610438400"; d="scan'208";a="164723367" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2021 04:05:58 -0800 IronPort-SDR: COYq9sW9sfP+AYAgV8rUzfa7G1gC1ER7+Eh1ceOKumIOZTJORpE0lpjTs9AVSfb7Btv8t/l/bM /FhXrJBC+4QQ== X-IronPort-AV: E=Sophos;i="5.81,205,1610438400"; d="scan'208";a="404251650" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.64]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 25 Feb 2021 04:05:56 -0800 Date: Thu, 25 Feb 2021 12:05:53 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: David Marchand , dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20210225120553.GB1546@bricha3-MOBL.ger.corp.intel.com> References: <20210225111457.32540-1-david.marchand@redhat.com> <2047120.oh6f1MFQjV@thomas> <20210225115720.GA1546@bricha3-MOBL.ger.corp.intel.com> <5625752.shjfW9zSB4@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5625752.shjfW9zSB4@thomas> Subject: Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote: > 25/02/2021 12:57, Bruce Richardson: > > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > > 25/02/2021 12:14, David Marchand: > > > > Add a check on versioned symbol duplicates in map files. > > > > > > > > Signed-off-by: David Marchand > > > > --- > > > > This check could be added to buildtools/check-symbols.sh so that > > > > regular developers catch the issue when building their changes... > > > > Opinions? > > > > > > In general I am against adding developer tools in the build process, > > > because it could cause more issues for normal users. > > > > > Is this really likely to cause issues for normal users? > > Yes because some users will have a different shell, > or other weird setup we don't think about yet. > I think it unlikely, but ok. Now that meson (from version 0.53 onwards) has a "filesystem" module, with an "exists" function, we can perhaps look to introduce a "developer mode" build again, based off the presence of the .git folder. Alternatively, we could make "developer mode" a regular meson option rather than trying to be too smart about it. [Or combine both and have developer mode option with "enabled"/"disabled"/"auto-detect" values] /Bruce