From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75544A034F; Thu, 25 Feb 2021 17:04:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 582BE406B4; Thu, 25 Feb 2021 17:04:41 +0100 (CET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 274E440692 for ; Thu, 25 Feb 2021 17:04:40 +0100 (CET) Received: by mail-lf1-f45.google.com with SMTP id 18so771009lff.6 for ; Thu, 25 Feb 2021 08:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H7ISyIwrbebY/G/ghIMjwS8E/ciXYOezEBm2LgT/4y0=; b=AWwlIYISxUEwnsBy6btbRFhx+o8e8+pyLap0KEseNqviEYoKPViFplc00cq/RJx8Zy aObWWVasaxJiPdB584eK+EfR8sSOhNigx51bKdMVa4Tv3zgTzZ0Z/OdFDwQvCuxppvYM hZizQGnrfTnIyLCHvn29t4kRNT7CxJq7zONPeR2KBoFPUoShgFbIKx47wI0VGbhvOllU UNALLKW2NEZYsQxRqre5Db/HihtonuYrKG4uQ7BbJuqwGzBoi7F1p6mDUKpijhOMUtWs NuIWvB1GXJwv4LuWHquUPkGbZHCgp7d3TM3h1AYOkppZpYaSpDMSzf9GUAlOjWt0dT2q ZyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H7ISyIwrbebY/G/ghIMjwS8E/ciXYOezEBm2LgT/4y0=; b=Q0FyEgwp1iSV5ZYNsZcxzgiE7EIU8tspYPl3tCI7kZw5v6wsCczXts9czCJkyhidBs tKM/NK+pgisroFlByuaWdk+OnrI0pdr/pKM9m45pvSEjj9YE0QqTBTy7/C1oXDm1TZ7k wOdgezDxHhb+bQGeH8D8obHeVThTSv/A3EQRmJgXDd2X0wyPZsugTU0K4vHV35351hfl aySikzcl0FJXDmUbe1gzlocq79o0JhyCxSyZsMQmphvV78KGqjyCZtsW4w1Tw23/0MB1 yHoaA8nSIIv079QJekq06KCy2EV4h3hEP0a2wMyW2VEHI+xg/bhDaO97X2n7fUhpZUZC NhXA== X-Gm-Message-State: AOAM533eG9J3WxvP9IaHeGJnV3qQ2edmA3YY6DEva3V5BL6NXGJxcErM Uh2JVXqfL/0UJWPc82cpSAs= X-Google-Smtp-Source: ABdhPJxRX+9Y/hxhpNM1no3MkaezKG4kGI4EnyXvF9dDkYCf1/V3s7jXpdUPBXaZosSRec2DcOHhxg== X-Received: by 2002:ac2:558d:: with SMTP id v13mr2173939lfg.582.1614269079689; Thu, 25 Feb 2021 08:04:39 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v16sm1126932lfp.24.2021.02.25.08.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 08:04:39 -0800 (PST) Date: Thu, 25 Feb 2021 19:04:38 +0300 From: Dmitry Kozlyuk To: Ferruh Yigit Cc: dev@dpdk.org, Tyler Retzlaff , Mike Wells , Bruce Richardson Message-ID: <20210225190438.56dfdd40@sovereign> In-Reply-To: <3e151d9d-7d80-41c8-8ade-d04aaedff687@intel.com> References: <20210214012013.23165-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-6-dmitry.kozliuk@gmail.com> <3e151d9d-7d80-41c8-8ade-d04aaedff687@intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-02-25 15:02, Ferruh Yigit: > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > WinPcap or Npcap, can be installed anywhere. > > Add a Meson option to specify SDK path. > > > > I am not sure if it is OK to add a meson option for this, can't we use the > default path? > > And does this mean we will need to add an option for each dependent library in > Windows? If not, why pcap is special? There are some meson options for SDK paths already. Are they exceptions? IMO, explicit specification is better because it allows switching dependency versions and library distributions. I understand that consensus it to keep build matrix size at minimum, but options to specify SDK path don't change the number of variants what can be found.