From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EDA3A034F; Thu, 25 Feb 2021 17:05:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E27C11607B4; Thu, 25 Feb 2021 17:05:04 +0100 (CET) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id B466340692 for ; Thu, 25 Feb 2021 17:05:03 +0100 (CET) Received: by mail-lf1-f48.google.com with SMTP id e7so9354863lft.2 for ; Thu, 25 Feb 2021 08:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fjC1ASyAyDgjnlpAl/fC6RaX699wp7sPDRyGXL1nkjE=; b=TpzwfW3LbRcgbmC7VilSavzsR/u2990I8BNgx1RQAsh6c0XMNirANAm0uAE48UGLNT XHrkBiykz8UBu6YBqEP60dbx957AtVFSveEsMLf9RbpLvntrCgQO8k1O4kdo1ktp/nLN iO8RQz58tugqt5HPg0m38OTy8GyE5Ad2MeqMoOUNlm3ck4NdWSKsiEd8SMFQmtuPS8pY 8VuXGINFPjyLD9KxhFISIG+ho4KPmV8tCUHQyx1uqjGvZYVbcAhOz/ET/RvwzyRvbzW1 6RwFyXeNQbZ8Yn4VJMnWXQ+pCOLU04qFz20jN2kqTOn4jYKkjsioxHBfqMR36Dz+abfk 8ihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fjC1ASyAyDgjnlpAl/fC6RaX699wp7sPDRyGXL1nkjE=; b=VEr6cUOQd6hMPuos335/6VZ+8+G9W7Gya5xH5Mo9SoQKZSNA2yPzxl44+M8BAlvWu/ vKuoWuLgYesOli3p36fepNgbPBLfbb7bku5QbLWMFUprOIx2l8ESlPoddwfcdQb97Vod To0eeZG9WZmtFhsl19i7r3D8gaXfkEQ6jzUIR5IzNL8dpKshrzDsNgmmhkQtQ0WPEU/9 gN/ZSdJ2zer6qN+bfT8v6Jf64ZzYnp9fuIxzKpnB4YDtGEA1dCI3nw9PRsok17uPbZ/9 Rp2VCTDoWq6PowhpQ2e5+DHmAMs02F2jaZtc7H4Kui0ELSWyDlGB6uwWG3gNUyYx0jXd evtQ== X-Gm-Message-State: AOAM532jre9OyEQzyEQJO0jFm2vpVJ89z0z3esXAbHjDv/U0UbEj7vRs tJcsL/gMpowuSo7qOPDZVWOtO6kjSLPhsw== X-Google-Smtp-Source: ABdhPJzw0K8MOGJb0oIja4dyFIyzcmyvfiFtPSJmjh/ZW70bTUWVFs8vYgx/qxiLrbmHvU8NaYjT3w== X-Received: by 2002:a19:400d:: with SMTP id n13mr2370214lfa.354.1614269103439; Thu, 25 Feb 2021 08:05:03 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id q15sm1152455lfc.60.2021.02.25.08.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 08:05:02 -0800 (PST) Date: Thu, 25 Feb 2021 19:05:00 +0300 From: Dmitry Kozlyuk To: Ferruh Yigit Cc: dev@dpdk.org, Tyler Retzlaff , Mike Wells Message-ID: <20210225190500.49092371@sovereign> In-Reply-To: <0605b40f-d655-8a7f-89c9-802af0ff6d94@intel.com> References: <20210214012013.23165-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-4-dmitry.kozliuk@gmail.com> <0605b40f-d655-8a7f-89c9-802af0ff6d94@intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/6] net/pcap: move OS-dependent code to separate files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-02-25 14:51, Ferruh Yigit: > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > PCAP PMD queries interface information differently for Linux and > > FreeBSD, OS-specific code is guarded by #ifdef. In preparation to add > > Windows-specific part and libpcap wrapper, extract OS-independent > > interface and move implementations to separate files. Rename > > rte_eth_pcap.c to pcap_ethdev.c for consistency with the rest of DPDK. > > > > Signed-off-by: Dmitry Kozlyuk > > <...> > > > +int > > +osdep_iface_index_get(const char *name) > > +{ > > + return if_nametoindex(name); > > +} > > > The 'osdep_iface_index_get' wrapper is not required for this patch and can be > done in patch 6/6, but OK to have here to make the switch clear. Yes, it was my intention to keep Windows patches separate.