From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5ED03A034F; Thu, 25 Feb 2021 18:42:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D602B406B4; Thu, 25 Feb 2021 18:42:33 +0100 (CET) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id 0357140692 for ; Thu, 25 Feb 2021 18:42:32 +0100 (CET) Received: by mail-lf1-f49.google.com with SMTP id f1so9832236lfu.3 for ; Thu, 25 Feb 2021 09:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MmFHEbkw62Gfaz/zdidoxuVK/+UnKMvRhTYptZVAyto=; b=cPxLSeDK/kSsQcdZJNi7DCvPhjtZTDob91jq8Quw4pkufauRoVIONSJ/P2FpnB0DQc q+Uk4+XRDZ7ay5x/bFmLBmXGEikO3JbFLA4PAENDKscZnrxH9StaHissWdn+pr77WhLs jek90YKSpeiWKkVCniZt0yfujwNC/QT2Fj5t/qdWxLjQNtoaY073QIOoVy6goRcI2lh6 qk9x+qEjSH21mtPR334etWIJNH7AKbQzrUAv05Jux8isLW7QooYzr6XQGTsGCdNYt67P ksBbbYZO3SeunZd8QV0jG+wlj8zpzqQVOjOlH4oiYwkgcVRuVOi6INHkiQCohsJ7/ozX 3A5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MmFHEbkw62Gfaz/zdidoxuVK/+UnKMvRhTYptZVAyto=; b=m8CB+un/cDJGeLXZuCkbBSk901wt+lEEutPeYsRAYqHJuNK7ZlavS/mCNe76XZ1D8L bJeiofT9IEvpAvAuZw2Ma2vof3iOyDcJF2Tkd6JuMFbyjfJ14b2Ml2x2xKv70iBC0g/+ joEFA++gUl0Kl9hVch2QcfI6HWqg+xicv13jtkkq5cMOMfI/BXpDld9RJZ1nwg7wi/dw 4X76Vf5Cowhe5+ON4Jwj8EcKahVRU6yKLfKdC5Ojr6FUQ3Fv66d90btK8xwNrcUmL46A tHsPPIrOyrgNSUzaGI4hdQQabDBdZ8c0+66rOmgfm56pgFNT2Ak+/bE3trR3L+s725/c C9BQ== X-Gm-Message-State: AOAM531wzeXESxiNBwYxpegPonXyTr1CFSD7M0cZbzUH+IJysZUjVsl6 sT5usBByj8reGjGzDYmZXXk= X-Google-Smtp-Source: ABdhPJzOYw+o9bWTzqW7XLHusj6fTlLKDyFVyGAOsroOn9JVj6zV5f6/vpupu9qRVGQbqDRDumo6KA== X-Received: by 2002:ac2:491d:: with SMTP id n29mr2525494lfi.18.1614274952624; Thu, 25 Feb 2021 09:42:32 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id f3sm1148575ljo.6.2021.02.25.09.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 09:42:32 -0800 (PST) Date: Thu, 25 Feb 2021 20:42:30 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org, Tyler Retzlaff , Mike Wells Message-ID: <20210225204230.117a41fe@sovereign> In-Reply-To: <20210225163337.GA1575@bricha3-MOBL.ger.corp.intel.com> References: <20210214012013.23165-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-6-dmitry.kozliuk@gmail.com> <3e151d9d-7d80-41c8-8ade-d04aaedff687@intel.com> <20210225190438.56dfdd40@sovereign> <20210225163337.GA1575@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-02-25 16:33, Bruce Richardson: > On Thu, Feb 25, 2021 at 07:04:38PM +0300, Dmitry Kozlyuk wrote: > > 2021-02-25 15:02, Ferruh Yigit: > > > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > > > WinPcap or Npcap, can be installed anywhere. > > > > Add a Meson option to specify SDK path. > > > > > > > > > > I am not sure if it is OK to add a meson option for this, can't we use the > > > default path? > > > > > > And does this mean we will need to add an option for each dependent library in > > > Windows? If not, why pcap is special? > > > > There are some meson options for SDK paths already. Are they exceptions? > > > Right now, yes, they are exceptions, but there is work underway to remove > them and just replace them with use of pkg-config. Is there some automatic > path discovery mechanism on windows, similar to pkg-config, that can be > used rather than having to add explicit dependency paths? pkg-config itself works on Windows if installed and given a PKG_CONFIG_PATH. Npcap doesn't provide a .pc file, despite libpcap commit 4f6b2b99 having it. Another quirk is that library is named libpcap.a/wpcap.lib on Unix/Windows. I can just handle the name difference and assume it's in the search path.