From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 305F3A034F; Fri, 26 Feb 2021 10:08:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EACCE407FF; Fri, 26 Feb 2021 10:08:13 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 31DB240692; Fri, 26 Feb 2021 10:08:12 +0100 (CET) IronPort-SDR: hxlgXaclpyc2rgItg2MoED0KWtzYRoY2tVy1vlZbG7d/kDbMKeAekF8d9PCE4GyuxypQTGxfhe h3h8pDn2WRkg== X-IronPort-AV: E=McAfee;i="6000,8403,9906"; a="165686718" X-IronPort-AV: E=Sophos;i="5.81,208,1610438400"; d="scan'208";a="165686718" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2021 01:08:11 -0800 IronPort-SDR: EGLgONxha0iZw4easfYxZhVQth/7OFsG56tXSzAjHiOHSDBqHrEvWG/ekwhIcDblgMy8Hm8wiw oSce7cE722LA== X-IronPort-AV: E=Sophos;i="5.81,208,1610438400"; d="scan'208";a="404821881" Received: from dsgurupr-mobl1.gar.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.16.207]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Feb 2021 01:08:07 -0800 Date: Fri, 26 Feb 2021 09:08:03 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, ncopa@alpinelinux.org, stable@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@oss.nxp.com>, Jakub Grajciar <jgrajcia@cisco.com>, Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, John McNamara <john.mcnamara@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Marcin Smoczynski <marcinx.smoczynski@intel.com> Message-ID: <20210226090803.GA1308@bricha3-MOBL.ger.corp.intel.com> References: <20190313170657.16688-1-ncopa@alpinelinux.org> <20210225182250.1149592-1-thomas@monjalon.net> <20210225182250.1149592-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225182250.1149592-5-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > There was an intent to define _GNU_SOURCE globally, > but it was not set in pkg-config for external applications. > Is this something that we really want to do, to force all external apps to use _GNU_SOURCE when compiling? Do some of our header files rely on definitions only available with _GNU_SOURCE? If so, we should probably look to remove that dependency rather than mandating the define.