From: Stephen Hemminger <stephen@networkplumber.org>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: Elad Nachman <eladv6@gmail.com>,
Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4
Date: Mon, 1 Mar 2021 08:38:20 -0800 [thread overview]
Message-ID: <20210301083820.640dde15@hermes.local> (raw)
In-Reply-To: <CAF+s_FwHiHs9TkS90UpLBtzowFo-c667nWVOF+y1p8Qn_-_5WQ@mail.gmail.com>
On Mon, 1 Mar 2021 11:10:01 +0300
Igor Ryzhov <iryzhov@nfware.com> wrote:
> Stephen,
>
> No, I don't have a better proposal, but I think it is not correct to change
> the behavior of KNI (making link down without a real response).
> Even though we know that communicating with userspace under rtnl_lock is a
> bad idea, it works as it is for many years already.
>
> Elad,
>
> I agree with you that KNI should be removed from the main tree if it is not
> possible to fix this __dev_close_many issue.
> There were discussions about this multiple times already, but no one is
> working on this AFAIK.
> Last time the discussion was a month ago:
> https://www.mail-archive.com/dev@dpdk.org/msg196033.html
>
> Igor
The better proposal would be to make DPDK virtio smarter.
There already is virtio devices that must handle this (VDPA) etc.
And when you can control link through virtio, then put a big warning
in KNI that says "Don't use this"
next prev parent reply other threads:[~2021-03-01 16:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 14:46 [dpdk-dev] [PATCH] kni: fix rtnl deadlocks and race conditions Elad Nachman
2021-02-19 18:41 ` Ferruh Yigit
2021-02-21 8:03 ` Elad Nachman
2021-02-22 15:58 ` Ferruh Yigit
2021-02-23 12:05 ` [dpdk-dev] [PATCH V2] kni: fix rtnl deadlocks and race conditions v2 Elad Nachman
2021-02-23 12:53 ` Ferruh Yigit
2021-02-23 13:44 ` [dpdk-dev] [PATCH 1/2] kni: fix rtnl deadlocks and race conditions v3 Elad Nachman
2021-02-23 13:45 ` [dpdk-dev] [PATCH 2/2] " Elad Nachman
2021-02-24 12:49 ` Igor Ryzhov
2021-02-24 13:33 ` Elad Nachman
2021-02-24 14:04 ` Igor Ryzhov
2021-02-24 14:06 ` Elad Nachman
2021-02-24 14:41 ` Igor Ryzhov
2021-02-24 14:56 ` Elad Nachman
2021-02-24 15:18 ` Igor Ryzhov
[not found] ` <CACXF7qkhkzFc-=v=iiBzh2V7rLjk1U34VUfPbNrnYJND_0TKHQ@mail.gmail.com>
2021-02-24 16:31 ` Igor Ryzhov
2021-02-24 15:54 ` Stephen Hemminger
2021-02-25 14:32 ` [dpdk-dev] [PATCH 1/2] kni: fix kernel deadlock when using mlx devices Elad Nachman
2021-02-25 14:32 ` [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4 Elad Nachman
2021-02-25 21:01 ` Igor Ryzhov
2021-02-26 15:48 ` Stephen Hemminger
2021-02-26 17:43 ` Elad Nachman
2021-03-01 8:10 ` Igor Ryzhov
2021-03-01 16:38 ` Stephen Hemminger [this message]
2021-03-15 16:58 ` Ferruh Yigit
2021-03-01 20:27 ` Dan Gora
2021-03-01 21:26 ` Dan Gora
2021-03-02 16:44 ` Elad Nachman
2021-03-15 17:17 ` Ferruh Yigit
2021-03-16 18:35 ` Elad Nachman
2021-03-16 18:42 ` Ferruh Yigit
2021-03-15 17:17 ` [dpdk-dev] [PATCH 1/2] kni: fix kernel deadlock when using mlx devices Ferruh Yigit
2021-03-29 14:36 ` [dpdk-dev] [PATCH v5 1/3] kni: refactor user request processing Ferruh Yigit
2021-03-29 14:36 ` [dpdk-dev] [PATCH v5 2/3] kni: support async user request Ferruh Yigit
2021-03-29 14:36 ` [dpdk-dev] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices Ferruh Yigit
2021-04-09 14:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-12 14:35 ` Elad Nachman
2021-04-20 23:07 ` Thomas Monjalon
2021-04-23 8:41 ` Igor Ryzhov
2021-04-23 8:59 ` Ferruh Yigit
2021-04-23 12:43 ` Igor Ryzhov
2021-04-23 12:58 ` Igor Ryzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301083820.640dde15@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=eladv6@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).