From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEB5CA054F; Mon, 1 Mar 2021 17:38:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B6D222A2D5; Mon, 1 Mar 2021 17:38:30 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id A0ABF40041 for ; Mon, 1 Mar 2021 17:38:29 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id q20so11862589pfu.8 for ; Mon, 01 Mar 2021 08:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ORIYSEO3NScAEdjE4/Goe5NYDzsXAt0V4YRd9n/YezU=; b=lz8IAJAUewUYWm2+RbrsCVkFTY+dKKo4T39+iqRWOIik3N9zB3X8qBLHPf3uM9WLXh yEkzpGmsSDUHaXtNKyvMWbJWlIX3WMpmSrx4qUrGFzAHlXNCp+SlZ95Px03bTYnlZoRx KBDypLlTHa8HPN/i1f0pYjbdLiPiRc5NFtjo7necxKdJK+BoyIJbNdFIQl83rGokD/1h /+Xsvf2MIjd41JUuUpNR2J1JTROi5xxMX89WAD1IMS/AYHulbV4Rqgp+5mzfpr0JAn52 7xIkwZwFMZcXWctInj8v/kVQBghKYXVXsW15DmH2cwnBGRdoNNM6DGWUeersi/RU5+Dg 6irA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ORIYSEO3NScAEdjE4/Goe5NYDzsXAt0V4YRd9n/YezU=; b=PhV4vKh4qSwfS1JD+25z6m4LkiQA5jl69w83fuPEQG6nPJk4Q4KGMPk1ckLUGLz8xZ 1eweva9UzqXUJHwD8jFOjUZk1y+JcDYbUJ/SmW+RUn3+dmIKd5eVyadb048te5goUaCd 4czAoYnqyK2HdoJd2Mfrin4BP1asGrJwcSQSANqSJAd9qoNMYxTx6QPA2GejfT+TGeGH g9nFVQQ8nF2FWo3HQH4LTLpT+XlfGZUDszjzBa8scfiYChj8TC+Z9gW4vzuGKNyANO1b +8Qvf2UBM5E15IsH6OyNjHJ4JbEPu2Fz2iHUn04DujnlqrAfQ8FFb3T63Yjuoc/TKsqh 0ATg== X-Gm-Message-State: AOAM530okcWH6AY6/NcCWOnSx/VK0KtpWzZy3FyvDP1MGOG9mxN5Tcv8 DBt6BCsJRfB8bxeVLHKlrVhhHQ== X-Google-Smtp-Source: ABdhPJxMR7fajvuDn73UM2uOXxIXvo2YVel1pBKslWNgfgJaG29CChM8E3opJcg+a+/l5LGEZR2n7g== X-Received: by 2002:a63:da41:: with SMTP id l1mr6773411pgj.165.1614616708693; Mon, 01 Mar 2021 08:38:28 -0800 (PST) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id ch15sm12632545pjb.46.2021.03.01.08.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 08:38:28 -0800 (PST) Date: Mon, 1 Mar 2021 08:38:20 -0800 From: Stephen Hemminger To: Igor Ryzhov Cc: Elad Nachman , Ferruh Yigit , dev Message-ID: <20210301083820.640dde15@hermes.local> In-Reply-To: References: <20201126144613.4986-1-eladv6@gmail.com> <20210225143239.14220-1-eladv6@gmail.com> <20210225143239.14220-2-eladv6@gmail.com> <20210226074817.7e9e0a71@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 1 Mar 2021 11:10:01 +0300 Igor Ryzhov wrote: > Stephen, > > No, I don't have a better proposal, but I think it is not correct to change > the behavior of KNI (making link down without a real response). > Even though we know that communicating with userspace under rtnl_lock is a > bad idea, it works as it is for many years already. > > Elad, > > I agree with you that KNI should be removed from the main tree if it is not > possible to fix this __dev_close_many issue. > There were discussions about this multiple times already, but no one is > working on this AFAIK. > Last time the discussion was a month ago: > https://www.mail-archive.com/dev@dpdk.org/msg196033.html > > Igor The better proposal would be to make DPDK virtio smarter. There already is virtio devices that must handle this (VDPA) etc. And when you can control link through virtio, then put a big warning in KNI that says "Don't use this"