DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Kevin Laatz <kevin.laatz@intel.com>,
	ciara.power@intel.com, dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] telemetry logs
Date: Tue, 2 Mar 2021 10:42:32 +0000	[thread overview]
Message-ID: <20210302104232.GC1396@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2447657.GpPAYfsJW5@thomas>

On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote:
> 02/03/2021 11:14, Bruce Richardson:
> > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote:
> > > Hi,
> > > Sorry if I already asked this question.
> > > Would it be possible to use rte_log in rte_telemetry
> > > instead of returning telemetry_log_error at init?
> > > 
> > It probably could be made to work by passing in the log function at init
> > time. Haven't delved too much into the details, though.
> 
> Actually I think a better question is about the need to init telemetry
> if not used. It can generate an error without a need.
> Instead of the existing option --no-telemetry,
> what do you think of initializing the telemetry on its first use?
> This way we could remove the dependency of EAL on telemetry?
> 
There is no real first use - the various libraries all register their callbacks
inside the init functions of the shared libraries. Having it initialized
inside EAL makes things very useful, because it means that all DPDK apps
automatically have telemetry available.

For example, end of last week I was able to put together a quick python
script to print out PPS stats for any DPDK app using the telemetry data.
Tested and developed initially using testpmd as a reference app, but ran
perfectly first time using OVS running in the background.

/Bruce

  reply	other threads:[~2021-03-02 10:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 19:22 Thomas Monjalon
2021-03-02 10:14 ` Bruce Richardson
2021-03-02 10:23   ` Thomas Monjalon
2021-03-02 10:42     ` Bruce Richardson [this message]
2021-03-02 11:01       ` Thomas Monjalon
2021-03-02 11:18         ` Bruce Richardson
2021-03-02 12:40           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302104232.GC1396@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).