From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33350A054F; Tue, 2 Mar 2021 11:42:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB1DD4014E; Tue, 2 Mar 2021 11:42:39 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EE9AB40142 for ; Tue, 2 Mar 2021 11:42:38 +0100 (CET) IronPort-SDR: BDuhLhrbFiEVW3n+t4d6Qe1GZjcEOGawFM9/fqxoU5ms+OmSnmzY9KsbPNh7p4/G31kQY1iq5c 9i4YJVQ1TMtQ== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="186100764" X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="186100764" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 02:42:38 -0800 IronPort-SDR: 3PvNyAktgNuoyJZo40S6gKuCMGB2j1ButH2Bvtvvt8gPFRj0BKrjjvomUIPy+rTdYApY1KCThU 1ZvJ14C7XgaQ== X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="398953056" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.13]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Mar 2021 02:42:36 -0800 Date: Tue, 2 Mar 2021 10:42:32 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Kevin Laatz , ciara.power@intel.com, dev@dpdk.org, david.marchand@redhat.com Message-ID: <20210302104232.GC1396@bricha3-MOBL.ger.corp.intel.com> References: <2019455.957uq3bD9f@thomas> <20210302101427.GB1396@bricha3-MOBL.ger.corp.intel.com> <2447657.GpPAYfsJW5@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2447657.GpPAYfsJW5@thomas> Subject: Re: [dpdk-dev] telemetry logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote: > 02/03/2021 11:14, Bruce Richardson: > > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > > > Hi, > > > Sorry if I already asked this question. > > > Would it be possible to use rte_log in rte_telemetry > > > instead of returning telemetry_log_error at init? > > > > > It probably could be made to work by passing in the log function at init > > time. Haven't delved too much into the details, though. > > Actually I think a better question is about the need to init telemetry > if not used. It can generate an error without a need. > Instead of the existing option --no-telemetry, > what do you think of initializing the telemetry on its first use? > This way we could remove the dependency of EAL on telemetry? > There is no real first use - the various libraries all register their callbacks inside the init functions of the shared libraries. Having it initialized inside EAL makes things very useful, because it means that all DPDK apps automatically have telemetry available. For example, end of last week I was able to put together a quick python script to print out PPS stats for any DPDK app using the telemetry data. Tested and developed initially using testpmd as a reference app, but ran perfectly first time using OVS running in the background. /Bruce