* [dpdk-dev] [PATCH v2] net/ice: fix wrong RSS hash update
[not found] <20210302053105.63783-1>
@ 2021-03-03 7:56 ` Wenjun Wu
2021-03-04 2:18 ` Yang, Qiming
0 siblings, 1 reply; 2+ messages in thread
From: Wenjun Wu @ 2021-03-03 7:56 UTC (permalink / raw)
To: dev, qiming.yang, qi.z.zhang; +Cc: Wenjun Wu, stable
This patch change redundant judgment statements to disable RSS
when users need to disable RSS or RSS hash function configured
is not supported.
Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
Cc: stable@dpdk.org
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
v2: do pf->rss_hf = 0 when rss_conf->rss_hf == 0 instead of direct
removal to avoid unnecessary judgment.
---
drivers/net/ice/ice_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index f43b2e0b2..299162286 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4461,8 +4461,10 @@ ice_rss_hash_update(struct rte_eth_dev *dev,
if (status)
return status;
- if (rss_conf->rss_hf == 0)
+ if (rss_conf->rss_hf == 0) {
+ pf->rss_hf = 0;
return 0;
+ }
/* RSS hash configuration */
ice_rss_hash_set(pf, rss_conf->rss_hf);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ice: fix wrong RSS hash update
2021-03-03 7:56 ` [dpdk-dev] [PATCH v2] net/ice: fix wrong RSS hash update Wenjun Wu
@ 2021-03-04 2:18 ` Yang, Qiming
0 siblings, 0 replies; 2+ messages in thread
From: Yang, Qiming @ 2021-03-04 2:18 UTC (permalink / raw)
To: Wu, Wenjun1, dev, Zhang, Qi Z; +Cc: stable
Acked-by: Qiming Yang <qiming.yang@intel.com>
> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: 2021年3月3日 15:57
> To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/ice: fix wrong RSS hash update
>
> This patch change redundant judgment statements to disable RSS when users
> need to disable RSS or RSS hash function configured is not supported.
>
> Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
>
> ---
> v2: do pf->rss_hf = 0 when rss_conf->rss_hf == 0 instead of direct removal to
> avoid unnecessary judgment.
> ---
> drivers/net/ice/ice_ethdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> f43b2e0b2..299162286 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4461,8 +4461,10 @@ ice_rss_hash_update(struct rte_eth_dev *dev,
> if (status)
> return status;
>
> - if (rss_conf->rss_hf == 0)
> + if (rss_conf->rss_hf == 0) {
> + pf->rss_hf = 0;
> return 0;
> + }
>
> /* RSS hash configuration */
> ice_rss_hash_set(pf, rss_conf->rss_hf);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-04 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210302053105.63783-1>
2021-03-03 7:56 ` [dpdk-dev] [PATCH v2] net/ice: fix wrong RSS hash update Wenjun Wu
2021-03-04 2:18 ` Yang, Qiming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).