From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 06BC1A0567;
	Thu,  4 Mar 2021 00:03:46 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 851FE40FDF;
	Thu,  4 Mar 2021 00:03:46 +0100 (CET)
Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com
 [209.85.167.43]) by mails.dpdk.org (Postfix) with ESMTP id D176640147
 for <dev@dpdk.org>; Thu,  4 Mar 2021 00:03:45 +0100 (CET)
Received: by mail-lf1-f43.google.com with SMTP id f1so39936391lfu.3
 for <dev@dpdk.org>; Wed, 03 Mar 2021 15:03:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=9vMmX5IAwYWRsk4k2vWFuvUBqsNKY3rWAyqxwKRMoOI=;
 b=bI4qZeqw37cXwVVABbULFdY+jGKJfDIMHqOAb7lI6sa1svKoPlMgTz7SzdAFqdgTLW
 WUZxUJlJ11klQaF//x5vw3jW9WcjQlseOJg02r580PVW/gXoJjlI0mLTQ+qBTxhPtMzp
 0wHg0O1CxcAbgT/INC0hF/xcEYa69d6OMt89oaKMaUgVHynE1uO8/R7umKY3ft2XXCZv
 ZtmqTWIbwZ3g/ciP2LIQJpnlXS6vPyCPDWpAWlX84jlLkLkhYZpRZUzxajgh2eXnVMfI
 TLzox1ieChib4zm4W+ju+xFAGR3n4i6ovlXj/kVRGg6Svexu85IKYYeJQ5p5cNz/wQpL
 A1og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=9vMmX5IAwYWRsk4k2vWFuvUBqsNKY3rWAyqxwKRMoOI=;
 b=e/B4RB2autOViBUkBP3yuBRdlyps5DHxEyML6XPnEHauOQIKuZtgEd51vAjg9/yFgf
 KM/rSxYIqn44MIBBFxVauvPXBwBWWjtt/4rideckBvERprrpQJIFT4itXDMlNbo4dE8H
 vXosLr9pR1dC58jE/O0/7gfjO8wA43MaZ2YrCChaUqsWSHX9EpHjdJJ4ICYIGG3igJAU
 Hq/3mpq+hkSCzK8/SxxYqDgyCWColhxx1S15BcAKBUcSTK9gDoryLIP6GWSw5b5ndtgz
 iu1XPBQQJ9FC64dnHxKE1nFARH6J5pppCnoFE5m3oMe3rw5aL54LsylKhA9qXat+UiDN
 kShg==
X-Gm-Message-State: AOAM532ILZsjiwyS+9TQtJcw23xjWmPSOQ6V03SJqVRxt8g1sulbCIF8
 O1906PCFqLOLesbVET1xVpU=
X-Google-Smtp-Source: ABdhPJybbwRz4ojlSwduy2LTKfTL8aUvdAYctVtNdvfILgDR1YHe0pb3VlLjut6C4JV/fki7AFaSOw==
X-Received: by 2002:a05:6512:1284:: with SMTP id
 u4mr594873lfs.175.1614812625421; 
 Wed, 03 Mar 2021 15:03:45 -0800 (PST)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id w1sm1480928lfu.239.2021.03.03.15.03.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 03 Mar 2021 15:03:44 -0800 (PST)
Date: Thu, 4 Mar 2021 02:03:43 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Tyler Retzlaff <roretzla@microsoft.com>, Nick Connolly
 <nick.connolly@mayadata.io>, dev@dpdk.org, Mike Wells
 <mike.wells@telchemy.com>, Narcisa Ana Maria Vasile
 <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>, Jie Zhou
 <jizh@linux.microsoft.com>
Message-ID: <20210304020343.2db602a6@sovereign>
In-Reply-To: <eb015e64-1ee3-ac3d-a1be-e9b4e1744940@intel.com>
References: <20210214012013.23165-1-dmitry.kozliuk@gmail.com>
 <20210214021616.26970-1-dmitry.kozliuk@gmail.com>
 <20210214021616.26970-5-dmitry.kozliuk@gmail.com>
 <6c5e9d34-abfa-d808-eef0-165315baf3ce@intel.com>
 <20210225220440.2bda87c3@sovereign>
 <ac14b4fc-7e0a-f3f5-a75d-65bc6e8f90fa@mayadata.io>
 <20210226021001.73829588@sovereign>
 <826eb0d3-3c0b-7581-99be-77e9bb6e8fa2@mayadata.io>
 <20210302020559.6d3317d7@sovereign>
 <65bd9188-0fcd-ab0c-2434-6a298be19b1a@mayadata.io>
 <20210303193240.2b83d9c9@sovereign>
 <e742d4a5-41c7-d78b-e6e2-d2be853c6e92@intel.com>
 <20210303211920.59ad403d@sovereign>
 <eb015e64-1ee3-ac3d-a1be-e9b4e1744940@intel.com>
X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2021-03-03 19:30, Ferruh Yigit:
> On 3/3/2021 6:19 PM, Dmitry Kozlyuk wrote:
> > 2021-03-03 16:47, Ferruh Yigit:  
> >> On 3/3/2021 4:32 PM, Dmitry Kozlyuk wrote:  
[...]
> > +#pragma push_macro("s_addr")
> > +#ifdef s_addr
> > +#undef s_addr
> > +#endif  
> 
> I guess this needs to be as following, in case this header included before the 
> windows header:
> 
> #ifdef s_addr
> #pragma push_macro("s_addr")
> #undef s_addr
> #endif

It actually works both ways.
I used #ifdef inside so that #pragma pop_macro doesn't need its own guard.