From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1111A0567; Thu, 4 Mar 2021 00:12:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51D2D40FDF; Thu, 4 Mar 2021 00:12:14 +0100 (CET) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mails.dpdk.org (Postfix) with ESMTP id A39F040147 for ; Thu, 4 Mar 2021 00:12:13 +0100 (CET) Received: by mail-lj1-f179.google.com with SMTP id h4so30740079ljl.0 for ; Wed, 03 Mar 2021 15:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H43pcfVLFEWrmyn8QY4O45MpqECk4RncLI55pcLUDH4=; b=ZW8b5R8q+hinbPPa/YxyZZvNasXVYxTcZPjOD11s6x6qZidKxHEYD1n8tued09PDif YQmDWAjE2tZG2Mm4rEGpaY6ozUXZJWg6ouShlEFZFrLbRiEDyDAEoPDhPgxgyp/oMV4K NlOUerTyRu6tX3++4qwCLfhDsqEpgFiFOSkYOAQ477wRf8gf2iZ0zKE8TpaFiHPGwejA GSUUBINhvbwS0vmW5Az4RiOqAbL/u3Wz5TAL2M/4OPIry+bRJNX0LLIISRiDKK3b4a8A ASJWq7wjm8pD87vq87xFlleyvj/AztyWng7eZXPgTjIfiscuzN072KmyUg/Yb1myFcfU j68g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H43pcfVLFEWrmyn8QY4O45MpqECk4RncLI55pcLUDH4=; b=GIjSsIr6UC/zVduZcZzDT1WDDTubR12e/y3rPbX0cHeBKW+xu53LVjNozId2omA8we Q1+m+GGgNeIGZZ+HPdeEy382p7qQnxslyLhzbgwnuRCMlkYraPOQjoYTvH14AO5hYR0J 1tSuNzQc2wuPHS81sOO+fmWci8H/3JoUJ1X8jA1YEnwJi3TuzesHYYKnTU14m28Lyv/5 OQYCdyNYTPKn8PNMrhzhZzaAoOY//eamRxm2sBukLRdQmjfMbknYYhtV3/xUjACRceaI +V1vDupdqXrzPgjfSLVyX3LAJEuqZHa0QoIZTvLuK3bSSgfVWyi9MdIQkEWckAR+IUKs hIeQ== X-Gm-Message-State: AOAM532JSoeeh45laWKrIif3eNM73xgwr9/mYNbz44xd06q1u6d23ar9 rDesHs52ptKa9aeE2nzYMk4= X-Google-Smtp-Source: ABdhPJzTiChiaTRQpVsKvVdg0TYueyPtUDTaMTcq/onP3Sr7ws/i0vgFV+Z4KTk5fiounGdFc3dLxQ== X-Received: by 2002:a2e:9e48:: with SMTP id g8mr661381ljk.47.1614813133264; Wed, 03 Mar 2021 15:12:13 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id b3sm3074969lfb.191.2021.03.03.15.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 15:12:12 -0800 (PST) Date: Thu, 4 Mar 2021 02:12:11 +0300 From: Dmitry Kozlyuk To: Pallavi Kadam Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com Message-ID: <20210304021211.2dbac1a9@sovereign> In-Reply-To: <20210303215929.5616-4-pallavi.kadam@intel.com> References: <20210303215929.5616-1-pallavi.kadam@intel.com> <20210303215929.5616-4-pallavi.kadam@intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-03-03 13:59, Pallavi Kadam: > Disable loading of private DDP packages in ice PMD on Windows. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > drivers/net/ice/ice_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) Are DDP packages unavailable on Windows or is their loading disabled because reading from PCI config space is not implemented by netuio? In the former case, please document the reason in commit (and probably in used guide?). In the latter case, could you instead fix rte_pci_config_read() to return (-1) on Windows, so that DDP loading automatically fails at reading capabilities? This would ensure ICE PMD remains portable by compiling all of its code in every platform.