From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AAD4A0548; Sat, 6 Mar 2021 21:18:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D847522A421; Sat, 6 Mar 2021 21:18:13 +0100 (CET) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mails.dpdk.org (Postfix) with ESMTP id 6280122A337 for ; Sat, 6 Mar 2021 21:18:12 +0100 (CET) Received: by mail-lj1-f172.google.com with SMTP id r25so9361770ljk.11 for ; Sat, 06 Mar 2021 12:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5p774vaYSZiNKdKII6AxnW3uUrRl2WgsIlu+/vB4yxs=; b=AwRos/89TNNitOHDUFEU+RfBfnroSqmPRMYp4GMIbNkFXoT/BUstX1d4M4ZB20vUbH 6q9QUKY4A2JX4LgcO2VPxx261uC4O8z7qspWFpdTc/cM7OqD/cVevH0pMY0WTp1onlH2 8sC3WMsLSH6mOGcfmfLztme6Qja+S9vax9nBY1L3u0jndUzBGfhSiHCxkP0qOLTCupRW M0tGUoUCwFkkRlo4UivrP02VLT4X1wijRvbfvYaV/aaAlRtQTeBj9wVk/E0BZKaOslZz SsEFBZ5tcBctCrabX9urLAwZJqeu0tcKAD+TKW3T8zkbv8r7cEOkoExjNz96+y9GP96b Xhow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5p774vaYSZiNKdKII6AxnW3uUrRl2WgsIlu+/vB4yxs=; b=pJXAXLHvzIbeu5uUxTx8L9yT4+DCXuFBBA2injlrJ8tlbE0BFSRYYqpYHIPZSuhBme xwmKWsYMBcPlPnMA+lZxVEbtiauZ+fZooJNxG8CZN66emdoY9MA86LXrXvzL+AWAyRpu HJzWnfv4mshxtP0M69GmsEp9vTF3+A0qcfwyI3N3Svb2cUIbqKhz3j6XMZBEWGeYMX3h emjdUfLR49aTG/OfUyP8LkHOF4NNBUbNgkoB5f/AmSldkmOwZmTmCoWmSj6BzUoDpYVD a+GacLe8cENhWZDM9l/4GiVhXW0rzPZkoZbCnmhM9oHBM0nN+mVIoOCxcJYSicZ2fWYr tDhQ== X-Gm-Message-State: AOAM533SaC8txtE0OCaGse3yEul5PZlJ0YjZlMRi2dfgz1zVFYML7zbD qoxOVHuGUBVkXnF3xaLcw50= X-Google-Smtp-Source: ABdhPJxjNmJBdZK/JB+5dqpJvsXUwnWy+s/O4XhJDva0phwv8iP76yA9jnavZ0XpCHCqa3Y5a5B1hg== X-Received: by 2002:a2e:9198:: with SMTP id f24mr8818126ljg.32.1615061892008; Sat, 06 Mar 2021 12:18:12 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id m7sm759052lfg.285.2021.03.06.12.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 12:18:11 -0800 (PST) Date: Sat, 6 Mar 2021 23:18:10 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, bruce.richardson@intel.com Message-ID: <20210306231810.34156af8@sovereign> In-Reply-To: <1614192383-20597-1-git-send-email-jizh@linux.microsoft.com> References: <1614121272-26776-1-git-send-email-jizh@linux.microsoft.com> <1614192383-20597-1-git-send-email-jizh@linux.microsoft.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] rte_metrics: unconditionally exports rte_metrics_tel_xxx functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-02-24 10:46 (UTC-0800), Jie Zhou: [...] > V2 changes: > Address comments from Dmitry Kozlyuk and > Bruce Richardson : > - Set dpdk.conf RTE_HAS_JANSSON in metrics meson.build > - Reduce #ifdef RTE_HAS_JANSSON blocks > > V3 changes: > Address comment from Bruce Richardson : > - Remove redundant includes line on librte_telemetry Nit: change log should be below "---" so that it's not included in commit. Acked-by: Dmitry Kozlyuk