From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 770C5A0562; Sun, 7 Mar 2021 10:12:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A818422A355; Sun, 7 Mar 2021 10:12:29 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2086.outbound.protection.outlook.com [40.107.220.86]) by mails.dpdk.org (Postfix) with ESMTP id A2AD222A337 for ; Sun, 7 Mar 2021 10:12:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fL5Sxxjm7gqulZmApCC/UkKnUN04OS8jbyZEn61PgLXBBiawmbiRfzhA+hGUbJ6KHmoAef7LPe96DLMiZZxzDcsdWsfty8iUrWx9/hAK8E5sUrGMFfwKtAwKHMuVtLBJjPS0tb5FWvcCgADVYy4uzBRWhrWfDH+8UvHzId19IShxW38seLL7R1mJa26kw4x0OXr74bDZbrp4cSV4zuZHjUs5CLYCIccNp1Y1+U4oIQ3jMe4DATSjUbiA96QHsti9xaojkJab3KuYt8f1hJNXJxyK3aL55qiEYg/bZ4NXxPY25+pAiGvvXuB4VaD0mU+B1wugC3TOSqehfSAJ4jwUTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=QVq/YLVyacjpCoUeuopYE2xtsUHHZvdLbEDxMmH1Ftxcg/P3FTtJMUEhc/+MPELYMDALsFWNCFLRgYOI2mIs9MFEW9WtmS52KonMGFopJL5HiwuL1AY+2LNC0fnai9ZscI6sIBpHbhrYueTZM5XK/3r5Avz7SkxXYPPkUIlV7Vnx54qQCHNEre7idJWCG/I7Pgmr56HzAQpgEvgpLl/zx+6UfNZdkDxfXkvnNxodo+y6K7AFY44Ae5ADztXSz+PcLyJ8xYN38xta67n4U4sweRt3EAqCmbHRaDx+2IFc/4HQT2EG3r/UC1l0myBbMyKZy3jGsleUopRYcpqwWCzqgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=bdpjx7Y7iEkAhPiNDF2dfEqSx+gvOkrUsvwJ3nJABtNs+rOwugidIzTtvozq4M2vyiktyxv/rwxfj+dOLstmRzv41JD0JeErUYMQdo4MyIZMnA4XBaj+zl7+BAO+D/fg0aGKatYmUt11owhfEbJZIi8yZ9B1n0AD9KJQP7fT2A0= Received: from DM5PR19CA0039.namprd19.prod.outlook.com (2603:10b6:3:9a::25) by MN2PR12MB3392.namprd12.prod.outlook.com (2603:10b6:208:cb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Sun, 7 Mar 2021 09:12:24 +0000 Received: from DM6NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:3:9a:cafe::a5) by DM5PR19CA0039.outlook.office365.com (2603:10b6:3:9a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Sun, 7 Mar 2021 09:12:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT048.mail.protection.outlook.com (10.13.173.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3912.17 via Frontend Transport; Sun, 7 Mar 2021 09:12:24 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 7 Mar 2021 09:12:22 +0000 From: Wisam Jaddo To: , , , , CC: Date: Sun, 7 Mar 2021 11:12:00 +0200 Message-ID: <20210307091202.586-4-wisamm@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210307091202.586-1-wisamm@nvidia.com> References: <20210307091202.586-1-wisamm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8cb2536c-86f8-4b9e-b654-08d8e1491f4d X-MS-TrafficTypeDiagnostic: MN2PR12MB3392: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:204; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hWEGdoPvIL2Gmx1lIFqkPHkLY/gVGCbfeofruZWEVcr9rNnQI0tuie8xvJCnhRY56zvHPwUevUIzPnbGcETuwad1u8DlTKxZyvDUa0AbfW2JUdBhBaqzYsDLBqgiyu+ZOMDRxNbbEHec14YkEmm+upgAZCj94vciO42GkBKtup/rdikDPbFrg2OER8Y4XzJp4C//k5zdBNXwDBzCyH+7pg2RZRBKubRFaX7L1bqTVn3iU9G3GNtgHounKLwCU24uYPc+QmYG3qAXBn4F7aIacQg1kZst5XOYeXCRa9WDQlIFr7lyibJkPwmy1oanIo91LWysBy4MQRxXGBeZj581O6gIm0+Tpps6RZlPz0+IIU7XQyJ0cw7GQzoB+BaqxUm096AXq35Icb/fDwo3G6kNapdGnLN20TvElDgWBC7TUp6zlZEvdB9JY9oRZe6FfrutFks/mNgFr/tSGJJMwmb9+JuQInvBgh0Ek5gMFh5sw4J2OytwvkAklGBXNevujskfGje/PQ8eZ7RqSi8OeKf11o+W+wu9uLYUxL9s0slgpK/pekNqhM5AkLfUME8HoRDQMunPRS49ytA+860g51JpKfOfzP7BsKK6UaoNdU2LDMTZRnMzRvLl2SeboNg27PH5lK4cwy7Y10eUNpCdHkiUgCj28r0LvNs7kS5OeQ4m/78TiH4J65oyq5g+DVuyX3SS X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(376002)(39860400002)(136003)(396003)(36840700001)(46966006)(4326008)(107886003)(34020700004)(55016002)(83380400001)(36906005)(5660300002)(8936002)(36860700001)(110136005)(47076005)(82740400003)(86362001)(26005)(36756003)(316002)(2616005)(7636003)(7696005)(2906002)(70586007)(186003)(82310400003)(356005)(426003)(478600001)(336012)(1076003)(8676002)(16526019)(6666004)(70206006)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2021 09:12:24.6004 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8cb2536c-86f8-4b9e-b654-08d8e1491f4d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3392 Subject: [dpdk-dev] [PATCH 3/5] app/flow-perf: fix naming of CPU used structured data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongzhou@nvidia.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index 4054178273..01607881df 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -105,8 +105,8 @@ struct used_cpu_time { struct multi_cores_pool { uint32_t cores_count; uint32_t rules_count; - struct used_cpu_time create_meter; - struct used_cpu_time create_flow; + struct used_cpu_time meters_record; + struct used_cpu_time flows_record; int64_t last_alloc[RTE_MAX_LCORE]; int64_t current_alloc[RTE_MAX_LCORE]; } __rte_cache_aligned; @@ -1013,10 +1013,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops) cpu_time_used, insertion_rate); if (ops == METER_CREATE) - mc_pool.create_meter.insertion[port_id][core_id] + mc_pool.meters_record.insertion[port_id][core_id] = cpu_time_used; else - mc_pool.create_meter.deletion[port_id][core_id] + mc_pool.meters_record.deletion[port_id][core_id] = cpu_time_used; } @@ -1134,7 +1134,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list) printf(":: Port %d :: Core %d :: The time for deleting %d rules is %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.deletion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.deletion[port_id][core_id] = cpu_time_used; } static struct rte_flow ** @@ -1241,7 +1241,7 @@ insert_flows(int port_id, uint8_t core_id) printf(":: Port %d :: Core %d :: The time for creating %d in rules %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.insertion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.insertion[port_id][core_id] = cpu_time_used; return flows_list; } @@ -1439,9 +1439,9 @@ run_rte_flow_handler_cores(void *data __rte_unused) RTE_ETH_FOREACH_DEV(port) { if (has_meter()) dump_used_cpu_time("Meters:", - port, &mc_pool.create_meter); + port, &mc_pool.meters_record); dump_used_cpu_time("Flows:", - port, &mc_pool.create_flow); + port, &mc_pool.flows_record); dump_used_mem(port); } -- 2.17.1