DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: prefix telemetry initialization message
@ 2021-03-08 22:23 Thomas Monjalon
  2021-03-09 10:59 ` Bruce Richardson
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2021-03-08 22:23 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

If the telemetry library initialization has some issue,
the error message is returned in a string
(to avoid circular dependency with EAL log system).

In order to make clear where the message comes from,
a prefix is added.
Before:   EAL: message
After:    EAL: telemetry: message

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/freebsd/eal.c | 2 +-
 lib/librte_eal/linux/eal.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c
index e2cdad5283..afbbb1c523 100644
--- a/lib/librte_eal/freebsd/eal.c
+++ b/lib/librte_eal/freebsd/eal.c
@@ -949,7 +949,7 @@ rte_eal_init(int argc, char **argv)
 			return -1;
 		}
 		if (error_str != NULL)
-			RTE_LOG(NOTICE, EAL, "%s\n", error_str);
+			RTE_LOG(NOTICE, EAL, "telemetry: %s\n", error_str);
 	}
 
 	eal_mcfg_complete();
diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
index 6c34ac8903..bc966150a5 100644
--- a/lib/librte_eal/linux/eal.c
+++ b/lib/librte_eal/linux/eal.c
@@ -1322,7 +1322,7 @@ rte_eal_init(int argc, char **argv)
 			return -1;
 		}
 		if (error_str != NULL)
-			RTE_LOG(NOTICE, EAL, "%s\n", error_str);
+			RTE_LOG(NOTICE, EAL, "telemetry: %s\n", error_str);
 	}
 
 	eal_mcfg_complete();
-- 
2.30.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: prefix telemetry initialization message
  2021-03-08 22:23 [dpdk-dev] [PATCH] eal: prefix telemetry initialization message Thomas Monjalon
@ 2021-03-09 10:59 ` Bruce Richardson
  2021-03-09 14:03   ` Bruce Richardson
  0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2021-03-09 10:59 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote:
> If the telemetry library initialization has some issue,
> the error message is returned in a string
> (to avoid circular dependency with EAL log system).
> 
> In order to make clear where the message comes from,
> a prefix is added.
> Before:   EAL: message
> After:    EAL: telemetry: message
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: prefix telemetry initialization message
  2021-03-09 10:59 ` Bruce Richardson
@ 2021-03-09 14:03   ` Bruce Richardson
  2021-03-25 14:32     ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2021-03-09 14:03 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Tue, Mar 09, 2021 at 10:59:52AM +0000, Bruce Richardson wrote:
> On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote:
> > If the telemetry library initialization has some issue,
> > the error message is returned in a string
> > (to avoid circular dependency with EAL log system).
> > 
> > In order to make clear where the message comes from,
> > a prefix is added.
> > Before:   EAL: message
> > After:    EAL: telemetry: message
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

By the way, I have a nearly completed patch for the telemetry library to
switch it to doing its own logging instead of passing back a string. It
does require a function pointer to rte_log to be passed to the init call,
but thereafter things are pretty normal in it and simplifies things. I'll
send it on as soon as it is ready.

/Bruce

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: prefix telemetry initialization message
  2021-03-09 14:03   ` Bruce Richardson
@ 2021-03-25 14:32     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-03-25 14:32 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, david.marchand

09/03/2021 15:03, Bruce Richardson:
> On Tue, Mar 09, 2021 at 10:59:52AM +0000, Bruce Richardson wrote:
> > On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote:
> > > If the telemetry library initialization has some issue,
> > > the error message is returned in a string
> > > (to avoid circular dependency with EAL log system).
> > > 
> > > In order to make clear where the message comes from,
> > > a prefix is added.
> > > Before:   EAL: message
> > > After:    EAL: telemetry: message
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> By the way, I have a nearly completed patch for the telemetry library to
> switch it to doing its own logging instead of passing back a string. It
> does require a function pointer to rte_log to be passed to the init call,
> but thereafter things are pretty normal in it and simplifies things. I'll
> send it on as soon as it is ready.

Thank you for the rework.
This patch is now classified as "Superseded".



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-25 14:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 22:23 [dpdk-dev] [PATCH] eal: prefix telemetry initialization message Thomas Monjalon
2021-03-09 10:59 ` Bruce Richardson
2021-03-09 14:03   ` Bruce Richardson
2021-03-25 14:32     ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git