From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8F761A0567;
Wed, 10 Mar 2021 00:32:18 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 5CEC522A569;
Wed, 10 Mar 2021 00:31:49 +0100 (CET)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id CDE3222A560
for <dev@dpdk.org>; Wed, 10 Mar 2021 00:31:46 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 80FCA5C0094;
Tue, 9 Mar 2021 18:31:46 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Tue, 09 Mar 2021 18:31:46 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=fm3; bh=ywZyCC55L5BjT
VALckc7Kac3T0SK6uVjjahD62zVzLA=; b=mFL1HJDPJGMzOdsrwQCMjFApAVrQ0
AY8qDUpDygPXXC+AghGrue3uL+ZjYb1jcGctsinEAnvFdEf8dEMnR3lAr9rERqC6
W0NFtZ31zDwT47UgGnRd38wVlRNpW9lYzbDbtnz4U5vmlI5PDJTMXtZySfWsatWu
fbyNTkL9dG4waFsI7kwBuFkKzBu+x7/2kPTiaw4skeonT6vIYnrqqvEQ/UBBNhg+
B5UaHK/9WW2uzvL2X5V82z8uEAiQyNoq3u1DFMYnpaCeUh1fWLbStGVfZm6t/obf
zDZHdHPKhdOgjRdR2zLejpiNiaTIli1Ftz6r4LImJqyjs8H4c8DTQxEcg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm2; bh=ywZyCC55L5BjTVALckc7Kac3T0SK6uVjjahD62zVzLA=; b=wBImsznO
Mc1W+JRje+IMsE4Jux3h1OwFnhsyyt54sVYXhTFdG4v1bDYSIx39+ttwvVaR8VdI
SOr9czOTnh9WrOfMAU1eqtI6EWcYNhlhWjUHXpfIOva0bNhJ3E6ATILZ3t8vGb6P
V8XUPM57AVMBcnzLl1ZBxQ14hLqqf85B7QZZiioPysy+SgOoo1pzNQTPxDncBT7F
emBOgYxZnAS8Fpi17w4ptp+xH6lCGgPIF3mHlklyljIdBYKpdc0G0jrr/0UA6R28
MBD+fYyEbKfvvtwvqYwthvlY8AGQdTkUSLyv+NV+wkxJ4SSOslydwni7YywHsYvL
GH7K92YHI+XSdA==
X-ME-Sender: <xms:YgVIYJNySbBzb3Nmo3o2AyRCUVIlGpxW9Znfbnfh3NI2kRmqnud5hQ>
<xme:YgVIYMFbSzA3aCgfxmwoJNEPSF7WGL83fcsTEGBPo6qGpQ5RelYuUp9WbjFdlBX6F
ZRhLKJ9P7loyjJz9g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudduiedgudejgecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke
ertdertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs
sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdehgfeivdejgedtve
ehfefhteelfefgieevgfffveefjeegtdfguedthedtgeevnecukfhppeejjedrudefgedr
vddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:YgVIYAOBRKYDgoLTvfiZ5U0shNIZvzxT9L5vwqx0MVf0IB1o_xjLZw>
<xmx:YgVIYN9gBkOkbJJOKMD2fXIZCYpUXzNpqLNjTtTxDF7kv7Ie-4rfUw>
<xmx:YgVIYMSmPWKgwW9M7it7fs_LsYMa8gytSJbNcXT5lEBFsXULr0wMEw>
<xmx:YgVIYMfPj-OwMpD_B6i2AP3VXHINRaeaoFpReK__CG9i38md66e7og>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 20CE524005A;
Tue, 9 Mar 2021 18:31:46 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: david.marchand@redhat.com
Date: Wed, 10 Mar 2021 00:31:09 +0100
Message-Id: <20210309233116.1934666-6-thomas@monjalon.net>
X-Mailer: git-send-email 2.30.1
In-Reply-To: <20210309233116.1934666-1-thomas@monjalon.net>
References: <20210309233116.1934666-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH 05/11] eal: introduce maximum log level macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
RTE_DIM(...) and RTE_LOG_DEBUG were used to get the highest log level.
For better clarity a new constant RTE_LOG_MAX is introduced
and mapped to RTE_LOG_DEBUG.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_eal/common/eal_common_log.c | 8 ++++----
lib/librte_eal/common/eal_common_options.c | 2 +-
lib/librte_eal/include/rte_log.h | 1 +
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index 85364ee47a..7f40c36f7e 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -140,7 +140,7 @@ rte_log_set_level(uint32_t type, uint32_t level)
{
if (type >= rte_logs.dynamic_types_len)
return -1;
- if (level > RTE_LOG_DEBUG)
+ if (level > RTE_LOG_MAX)
return -1;
rte_logs.dynamic_types[type].loglevel = level;
@@ -155,7 +155,7 @@ rte_log_set_level_regexp(const char *regex, uint32_t level)
regex_t r;
size_t i;
- if (level > RTE_LOG_DEBUG)
+ if (level > RTE_LOG_MAX)
return -1;
if (regcomp(&r, regex, 0) != 0)
@@ -219,7 +219,7 @@ rte_log_set_level_pattern(const char *pattern, uint32_t level)
{
size_t i;
- if (level > RTE_LOG_DEBUG)
+ if (level > RTE_LOG_MAX)
return -1;
for (i = 0; i < rte_logs.dynamic_types_len; i++) {
@@ -323,7 +323,7 @@ rte_log_register_type_and_pick_level(const char *name, uint32_t level_def)
return type;
TAILQ_FOREACH(opt_ll, &opt_loglevel_list, next) {
- if (opt_ll->level > RTE_LOG_DEBUG)
+ if (opt_ll->level > RTE_LOG_MAX)
continue;
if (opt_ll->pattern) {
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 02374ee09e..febc99612a 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -1249,7 +1249,7 @@ eal_parse_log_priority(const char *level)
return -1;
/* look for named values, skip 0 which is not a valid level */
- for (i = 1; i < RTE_DIM(levels); i++) {
+ for (i = 1; i < RTE_LOG_MAX; i++) {
if (strncmp(levels[i], level, len) == 0)
return i;
}
diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
index 173004fd71..394e8682b9 100644
--- a/lib/librte_eal/include/rte_log.h
+++ b/lib/librte_eal/include/rte_log.h
@@ -72,6 +72,7 @@ extern "C" {
#define RTE_LOG_NOTICE 6U /**< Normal but significant condition. */
#define RTE_LOG_INFO 7U /**< Informational. */
#define RTE_LOG_DEBUG 8U /**< Debug-level messages. */
+#define RTE_LOG_MAX RTE_LOG_DEBUG /**< Most detailed log level. */
/**
* Change the stream that will be used by the logging system.
--
2.30.1