From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86C86A0567; Wed, 10 Mar 2021 16:17:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B72C22A340; Wed, 10 Mar 2021 16:17:01 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id E99504069F for ; Wed, 10 Mar 2021 16:16:59 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id ba1so8639134plb.1 for ; Wed, 10 Mar 2021 07:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tPRyA05m8+JZN+fzwPNY2/Dfkkn7NJvo/d8nLjyRIdg=; b=t1Wc0newksSRxBXJBTiKiK+z9rhwMZKcVwB6pADiCrY0Eb2nVmafuTJVd1LYD/4vsh jBURdUFUEXqaOWOUz5EkdlauvTQtygounPNmyQpO0f+vgCSESM8pSR3tbmx+O7Vmt30A b1h99dIogWJBsH2ZbpyWmuVdCgnQn+sROO+xWR4QluYeGYHG9xIVHLHwDiIum3RRGPfi O1EFbk2whmVsrWA52IM2a0LfVBNjwo5Q42zPwAU55PsVVKsdi0ZW6qZstx7dARBgAtTf SsDibLctFUzCS6HL+k5nZ3VuvA1c++LFtGeBV1F+Av8nd7IKo6z56kNP4koW9V1Sqi/o HLlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tPRyA05m8+JZN+fzwPNY2/Dfkkn7NJvo/d8nLjyRIdg=; b=fDQ/zE15qKyTP+E94Ca/bHM8hBiW9RAAjoJc+5/yiIfKbQGj6LZm8+P/Htr4jU2Hqw YUwJDbjVhdoGc0ie1xgaA1zbeuVFZTuYIdJ7axz/VezgM1yIwke4cxyGm+uucpoPp35N a3yG26honEQHF74gKA3oMP2nIvRF74wvzMBVz655mo8osuSxnMH5mwWU0DzWuLgu1oWy ArfYXKLFMoPhjbYhVShceX0tZbyBdlTPWlFOsSYXRIGIxvDS2gvFbXqDHKAXZQ8uu/tR skmbC1nym7fQgBawF34kVCAvsq2R7VUbx8Wf+Z6AkFakngTQ7vImQan1NgZ2xM5Ad84W FZyA== X-Gm-Message-State: AOAM531dDG6eDd3bkFvwjq48FtFiQdgWNJsOOTHboMNJtpkKHNey4mv8 eWQ8qQvc5xE+mWePzdPnWkLexA== X-Google-Smtp-Source: ABdhPJwUpy+DVZuI9ie7GNNR5IzMhw5jSLN10rjRXy0wfObgi1CJLVeIdcwLvLk0DvlSKfaQgbu/iw== X-Received: by 2002:a17:90a:c389:: with SMTP id h9mr4116491pjt.226.1615389419012; Wed, 10 Mar 2021 07:16:59 -0800 (PST) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id v185sm16991171pfb.125.2021.03.10.07.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 07:16:58 -0800 (PST) Date: Wed, 10 Mar 2021 07:16:55 -0800 From: Stephen Hemminger To: Bruce Richardson Cc: Thomas Monjalon , dev@dpdk.org, david.marchand@redhat.com Message-ID: <20210310071655.029e6fad@hermes.local> In-Reply-To: <20210310121924.GA1267@bricha3-MOBL.ger.corp.intel.com> References: <20210309233116.1934666-1-thomas@monjalon.net> <20210309233116.1934666-7-thomas@monjalon.net> <20210310121924.GA1267@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 06/11] eal: catch invalid log level number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 10 Mar 2021 12:19:24 +0000 Bruce Richardson wrote: > On Wed, Mar 10, 2021 at 12:31:10AM +0100, Thomas Monjalon wrote: > > The parsing check for invalid log level was not trying to catch > > irrelevant numeric values. > > A log level 0 or too high is now a failure in options parsing > > so it can be caught early. > > > > Signed-off-by: Thomas Monjalon > > One thing I'd note here is that our log range of 1 to 8 is a little > strange, and that it would be nice if we could accept 9 as a valid log > level too on the cmdline. Ideally 0 would also be acceptable, for all > logging off, but it's more likely that people want to up the log level than > reduce it, and 9 is a more expected max value than 8. It all goes back to syslog values.