DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] bnxt bug fixes
@ 2021-03-10  7:50 Kalesh A P
  2021-03-10  7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kalesh A P @ 2021-03-10  7:50 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, ajit.khaparde

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

This series contain couple of bug fixes in bnxt PMD.

Kalesh AP (2):
  net/bnxt: fix HWRM and FW incompatibility handling
  net/bnxt: mute some failure logs

 drivers/net/bnxt/bnxt_hwrm.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

-- 
2.10.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling
  2021-03-10  7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
@ 2021-03-10  7:50 ` Kalesh A P
  2021-03-10  7:50 ` [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs Kalesh A P
  2021-03-11 23:58 ` [dpdk-dev] [PATCH 0/2] bnxt bug fixes Ajit Khaparde
  2 siblings, 0 replies; 4+ messages in thread
From: Kalesh A P @ 2021-03-10  7:50 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, ajit.khaparde

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

Fix to return an error when the HWRM version that the driver
is compiled against is incompatible with the FW that is actually
running on the card. This is determined based on the req length
indicated by FW against the value supported in the HWRM.

Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code")
Cc: stable@dpdk.org

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 0b5318e..582f4d1 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1143,6 +1143,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
 	if (bp->max_req_len > resp->max_req_win_len) {
 		PMD_DRV_LOG(ERR, "Unsupported request length\n");
 		rc = -EINVAL;
+		goto error;
 	}
 
 	bp->chip_num = rte_le_to_cpu_16(resp->chip_num);
-- 
2.10.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs
  2021-03-10  7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
  2021-03-10  7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
@ 2021-03-10  7:50 ` Kalesh A P
  2021-03-11 23:58 ` [dpdk-dev] [PATCH 0/2] bnxt bug fixes Ajit Khaparde
  2 siblings, 0 replies; 4+ messages in thread
From: Kalesh A P @ 2021-03-10  7:50 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, ajit.khaparde

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

In the init path, driver ignores few of the HWRM command failures.
There is no need to log the error message in those cases.

Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information")
Fixes: 4e3f887bec4b ("net/bnxt: support HWRM port PHY qcaps")
Cc: stable@dpdk.org

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 582f4d1..8927d41 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1414,7 +1414,7 @@ int bnxt_hwrm_port_phy_qcaps(struct bnxt *bp)
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
-	HWRM_CHECK_RESULT();
+	HWRM_CHECK_RESULT_SILENT();
 
 	bp->port_cnt = resp->port_cnt;
 	if (resp->supported_speeds_auto_mode)
@@ -3250,7 +3250,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
-	HWRM_CHECK_RESULT();
+	HWRM_CHECK_RESULT_SILENT();
 
 	memcpy(bp->parent->mac_addr, resp->mac_address, RTE_ETHER_ADDR_LEN);
 	bp->parent->vnic = rte_le_to_cpu_16(resp->dflt_vnic_id);
@@ -3259,7 +3259,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
 
 	/* FIXME: Temporary workaround - remove when firmware issue is fixed. */
 	if (bp->parent->vnic == 0) {
-		PMD_DRV_LOG(ERR, "Error: parent VNIC unavailable.\n");
+		PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n");
 		/* Use hard-coded values appropriate for current Wh+ fw. */
 		if (bp->parent->fid == 2)
 			bp->parent->vnic = 0x100;
@@ -4263,7 +4263,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)
 	req.port_id = bp->pf->port_id;
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
-	HWRM_CHECK_RESULT();
+	HWRM_CHECK_RESULT_SILENT();
 
 	if (resp->num_leds > 0 && resp->num_leds < BNXT_MAX_LED) {
 		unsigned int i;
-- 
2.10.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes
  2021-03-10  7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
  2021-03-10  7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
  2021-03-10  7:50 ` [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs Kalesh A P
@ 2021-03-11 23:58 ` Ajit Khaparde
  2 siblings, 0 replies; 4+ messages in thread
From: Ajit Khaparde @ 2021-03-11 23:58 UTC (permalink / raw)
  To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On Tue, Mar 9, 2021 at 11:28 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> This series contain couple of bug fixes in bnxt PMD.
>
> Kalesh AP (2):
>   net/bnxt: fix HWRM and FW incompatibility handling
>   net/bnxt: mute some failure logs
Patchset applied to dpdk-next-net-brcm.

>
>  drivers/net/bnxt/bnxt_hwrm.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> --
> 2.10.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-11 23:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10  7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
2021-03-10  7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
2021-03-10  7:50 ` [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs Kalesh A P
2021-03-11 23:58 ` [dpdk-dev] [PATCH 0/2] bnxt bug fixes Ajit Khaparde

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git