From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B07C7A0567; Wed, 10 Mar 2021 10:14:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8813C22A412; Wed, 10 Mar 2021 10:14:39 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id F2DE94068C for ; Wed, 10 Mar 2021 10:14:37 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id n10so10996805pgl.10 for ; Wed, 10 Mar 2021 01:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WrYm5K8f0GrCNXRNnnuaXqz95Jqp2Y7PGB6Px7oz44o=; b=VgOZMtjCgzsVkUz0ukQtF5OuIWpB++JDo0W4ChcslI9OJhZcUTLRqcFpMjbweG98M7 zsg5OLV4lG92bX/JRUX40YoaNOmPc00S0pgdKP773RInn9JtRKuwSH6cruklOFKM32NM ANXh+ozX0f6nCwD6f0c4x4G6gqNcQu/5UqXL7b+4eR8+rSSvMcgkyB9jjiZRMmpnlANC mQo+wmf6+N8aoO1bPEQlK1Yt8a5PzeEIyruFnwb0uFUdTpib9QRQAKt2sFu2P8CorCGn mn8NBRgjvqhLUBAlYOIu1ms59FvYV3KwxT2seOQQsKSL4jsk4Ek3P3NaGQYnOvU6C+PY ZFqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WrYm5K8f0GrCNXRNnnuaXqz95Jqp2Y7PGB6Px7oz44o=; b=fyLzkRTP0yZUyZTtq3HA7OiHEeTbqWUYQVHus9gwwlUq5tDil4/ZlyPUMcbZ8391sJ yB5PPXDrOURf5Qqfe/nYXAY6V07fFI5dCepLj/wuwrc/o/oFGyv8qNHiK7HG0YX63lVn ejosHjlntlPzrRUUhAhiWOlFIyByqNysll8/ortrtQ0oWUh4IRWoAnRp80x56CBzBje5 svMb6KYeKoo4BB8cLjwcVpSvr6OuzRiqqOwIowUsTHEv0OKOPbzDaoPp80uMeeY0MKgP dLPnrqYrnoiL1bJLhdHCP+BpRAbrPaQhnaM3Uh5ptxGwrvchf04L8r59ekZ6IKi3Jts/ 9+bg== X-Gm-Message-State: AOAM533Dgm5bEKGRg66Z3F11PU776YxQfJaJ5iJ/9HaxbB5qo25RD+ee AelaLXDEKM2oBcBXmV2DNGY= X-Google-Smtp-Source: ABdhPJzEOD98Kk2r1fyANmCgpn8jKkb4UvfJjNbKSdPE4QnqV8MQWQCgAu9bV2Tr/bj8h0NlSQw0Bg== X-Received: by 2002:a65:63c6:: with SMTP id n6mr2070093pgv.298.1615367677173; Wed, 10 Mar 2021 01:14:37 -0800 (PST) Received: from BG-LT7405.marvell.com (117.205.98.34.bc.googleusercontent.com. [34.98.205.117]) by smtp.gmail.com with ESMTPSA id o62sm14803784pga.43.2021.03.10.01.14.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Mar 2021 01:14:36 -0800 (PST) Date: Wed, 10 Mar 2021 14:44:31 +0530 From: Shijith Thotton To: "Carrillo, Erik G" Cc: Shijith Thotton , Pavan Nikhilesh , Jerin Jacob , "dev@dpdk.org" Message-ID: <20210310091431.GA21@BG-LT7405.marvell.com> References: <20210308204543.2903723-1-sthotton@marvell.com> <20210308204543.2903723-2-sthotton@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Erik, On Tue, Mar 09, 2021 at 08:04:32PM +0000, Carrillo, Erik G wrote: > > A timer adapter in periodic mode can be used to arm periodic timers. > > This patch adds flags used to advertise capability and configure timer adapter > > in periodic mode. Capability flag should be set for adapters which support > > periodic mode. > > > > Below is a programming sequence on the usage: > > /* check for periodic mode support by reading capability. */ > > rte_event_timer_adapter_caps_get(...); > > > > /* create adapter in periodic mode by setting periodic flag > > (RTE_EVENT_TIMER_ADAPTER_F_PERIODIC) and resolution. */ > > rte_event_timer_adapter_create_ext(...); > > It looks like periodic support is an operating mode of the adapter itself, and > that all timers created with a periodic adapter instance will be periodic > timers. > > Is it possible to instead have "periodic/single-shot" be an attribute of an > event timer itself, such that a single adapter instance could support either > type of timer? > With single type of timer per adapter, application can decide to create multiple adapters of required type/mode and use as needed. For an adapter to support both type of timers, driver ops implementation has to follow different paths based on timer type and new capability flag should be introduced to expose this feature. Our HW only supports single type of timer per adapter. Please let me know the approach you are aligned with. Thanks, Shijith