From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5E4C2A0567;
Wed, 10 Mar 2021 14:46:37 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D02DA22A627;
Wed, 10 Mar 2021 14:46:20 +0100 (CET)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86])
by mails.dpdk.org (Postfix) with ESMTP id A470222A5C2
for <dev@dpdk.org>; Wed, 10 Mar 2021 14:46:17 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=lGOjFqUrunV4OFW977MB8pe7ugF+hI1+ABFH9Rn9PnJfaMOgPO3I9Ma/x30Egc2ekb9gM07TCcJ2L286LMExZFTL1vPVLsYPVngnxax1ffLSbekfOCTV2l5Kn0Ci1hcmo9L49k/84z9pk80mHvg77t9x7n3FRnPCygR5GxE29xEdEI5HUBR5AvFFaymzTIf6uohRvChV6LiBH2L1nV09ojurrUuGZpsW5LJRm1VXjYzLzBA2NeEXao1XbvbFlVlM1d/tnYt8e8w3HWz9RTy8x7pCMliJMJoAZlVkKobGi+Fxn01APlRlmgEa4ATsYclhaZHAn4Xq50JHBOcR/x0cSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=;
b=PSObJNaelGYc4LzhBAKQYzV1uFyk/tBJ+SKO6dkBVsbcOWA4i1J9k5GHEkNrWh3WthPZFM0yAuCdsiTZ9hfMSGclX1uoDLf657qmbNVw4PCMYfpHj1Fd6erixcj0FnvN9awWk5wy5/+Oe+krhYPUlv2jsalTlUemKSzxblSMxI/c4nQfnrNZ+DoWGLxYZ8qjstPc2Z6wn5wiEl6OXyfahUwgEmm+dIqiHyGxxEI54oXdsf2GBlGcKigSd7cd5dTmlWJjzSNN3WVhThNDhbPcrdWkxXBXiXEZzJCyZyOzikrHFFP398Yd6OpQxnh1DPHEocQZwYh6ovQhWKM7bVsvcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;
dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;
dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=;
b=Xqf7hY+FUYeSUc0b3E8oh4uE7h9EnbJTE9m0qrTXH0QJIqTxbLXF5S6Gb0e5/h2zOXuw8eQGpLHPfvZR0/vmtOTHEVGM/GoJXvwHP9wEtydf1/nsXCh8XzMzobcM7q/+d3fZtEaMXIBbPsQpF2Uf1Se+cXFOJvQBPYbOhYBAUMBMGwZ7bfOo4UIp9lad/tCDMS8ALIEdPt0dLqjGBufeDY+EFwYon/ZjUchQSYIZsdRiwGEbgoZj+V0zrUmou1sr3DCam5Nk45kb5fhczSxVMwYcNdQuwTmPSIwz3BMdDgTZWtSiAEK2ZoteOV0GNZRBJvftlz1HEEW9Xtv/CPd+0w==
Received: from DM6PR14CA0059.namprd14.prod.outlook.com (2603:10b6:5:18f::36)
by BN9PR12MB5308.namprd12.prod.outlook.com (2603:10b6:408:105::19) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.8; Wed, 10 Mar
2021 13:46:16 +0000
Received: from DM6NAM11FT030.eop-nam11.prod.protection.outlook.com
(2603:10b6:5:18f:cafe::b7) by DM6PR14CA0059.outlook.office365.com
(2603:10b6:5:18f::36) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend
Transport; Wed, 10 Mar 2021 13:46:16 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34)
smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)
header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.112.34 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.112.34; helo=mail.nvidia.com;
Received: from mail.nvidia.com (216.228.112.34) by
DM6NAM11FT030.mail.protection.outlook.com (10.13.172.146) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 13:46:16 +0000
Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com
(172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar
2021 13:46:13 +0000
From: Wisam Jaddo <wisamm@nvidia.com>
To: <arybchenko@solarflare.com>, <thomas@monjalon.net>, <akozyrev@nvidia.com>,
<rasland@nvidia.com>, <dev@dpdk.org>
CC: <dongzhou@nvidia.com>
Date: Wed, 10 Mar 2021 15:45:50 +0200
Message-ID: <20210310134554.7948-4-wisamm@nvidia.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20210310134554.7948-1-wisamm@nvidia.com>
References: <20210307091202.586-2-wisamm@nvidia.com>
<20210310134554.7948-1-wisamm@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
HQMAIL107.nvidia.com (172.20.187.13)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 843395b9-b6e3-4cc8-6c25-08d8e3cae090
X-MS-TrafficTypeDiagnostic: BN9PR12MB5308:
X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
X-Microsoft-Antispam-PRVS: <BN9PR12MB53086A6DE854B1BCBB732B47A4919@BN9PR12MB5308.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:204;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ogqAom1Hy7PtYws/OvTlhwLYuJh9H3UlMhCK4467MWhXIntNRuHAom9A8kAZKEPIL02jWUxf3tupRZ4oOaSPVfW/GTXr9zR+f01z/mhPF5+xd15bDkhV+Ump4lq2XdRbDZnFKoAJD+BIFPFkbJ+Dx3lXwH0efzpv8KUt8g8xcJW9iRVZBe5p3mMFp/v+cbXsqzsblelP6lTU+tCiIbBFZr9NV1gKZRtKH13SqmjB0wkIIDYMf6797MHoAZ/KRui7kYkta/XkND6qnbIpTiVDsxpxz8jHILiTBCc2JANA3r3MKeTTYuPZ5XBg8VcAIOqi0BoLwCn9KEgiSaoiP8o/zu562Ht/HWZITbSR2NmxdrBhZk+VW2tg4TQ2R0q1vWwIqeBhppJ2sr9rpO38/vlIlidCiMGakT+vZCrWE4JJHGBRaae75k0EDI1VXDzZZnEiC6Oyor/woLgwCGRc5iZrQDhCwjJGod6pipXh0DsAeuzjHAdbqbJfdEVjMyIxmgVTqYVteMCuVPY6xGqd5pmUyqZc74/8r/d9kTN0flJBpUCI0PmevcjiX24oiLP22Y/igFbp7f+Pf+S59QSZm5KyLw8Az5h2vZgAuKzsHeL2I53iSUBvDJbOS1FhZ/8vPPuyceql7Rh9AgdnRWENmiTHcylsNthJTtLjBfpvYRBL3pv12WqpvipQQOBYDwnHWrzx
X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;
SFS:(4636009)(39860400002)(376002)(396003)(136003)(346002)(36840700001)(46966006)(16526019)(36756003)(336012)(83380400001)(82310400003)(70206006)(34020700004)(36906005)(186003)(426003)(316002)(1076003)(478600001)(47076005)(2906002)(8676002)(8936002)(5660300002)(36860700001)(7696005)(4326008)(2616005)(82740400003)(55016002)(6286002)(356005)(86362001)(6666004)(110136005)(70586007)(107886003)(26005)(7636003);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 13:46:16.2325 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 843395b9-b6e3-4cc8-6c25-08d8e3cae090
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT030.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5308
Subject: [dpdk-dev] [PATCH v2 3/7] app/flow-perf: fix naming of CPU used
structured data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
create_flow and create_meter are not correct names since those
are records that contain creation and deletion, which makes
them more of a record for such data.
Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions")
Cc: dongzhou@nvidia.com
Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
---
app/test-flow-perf/main.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
index 4054178273..01607881df 100644
--- a/app/test-flow-perf/main.c
+++ b/app/test-flow-perf/main.c
@@ -105,8 +105,8 @@ struct used_cpu_time {
struct multi_cores_pool {
uint32_t cores_count;
uint32_t rules_count;
- struct used_cpu_time create_meter;
- struct used_cpu_time create_flow;
+ struct used_cpu_time meters_record;
+ struct used_cpu_time flows_record;
int64_t last_alloc[RTE_MAX_LCORE];
int64_t current_alloc[RTE_MAX_LCORE];
} __rte_cache_aligned;
@@ -1013,10 +1013,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops)
cpu_time_used, insertion_rate);
if (ops == METER_CREATE)
- mc_pool.create_meter.insertion[port_id][core_id]
+ mc_pool.meters_record.insertion[port_id][core_id]
= cpu_time_used;
else
- mc_pool.create_meter.deletion[port_id][core_id]
+ mc_pool.meters_record.deletion[port_id][core_id]
= cpu_time_used;
}
@@ -1134,7 +1134,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list)
printf(":: Port %d :: Core %d :: The time for deleting %d rules is %f seconds\n",
port_id, core_id, rules_count_per_core, cpu_time_used);
- mc_pool.create_flow.deletion[port_id][core_id] = cpu_time_used;
+ mc_pool.flows_record.deletion[port_id][core_id] = cpu_time_used;
}
static struct rte_flow **
@@ -1241,7 +1241,7 @@ insert_flows(int port_id, uint8_t core_id)
printf(":: Port %d :: Core %d :: The time for creating %d in rules %f seconds\n",
port_id, core_id, rules_count_per_core, cpu_time_used);
- mc_pool.create_flow.insertion[port_id][core_id] = cpu_time_used;
+ mc_pool.flows_record.insertion[port_id][core_id] = cpu_time_used;
return flows_list;
}
@@ -1439,9 +1439,9 @@ run_rte_flow_handler_cores(void *data __rte_unused)
RTE_ETH_FOREACH_DEV(port) {
if (has_meter())
dump_used_cpu_time("Meters:",
- port, &mc_pool.create_meter);
+ port, &mc_pool.meters_record);
dump_used_cpu_time("Flows:",
- port, &mc_pool.create_flow);
+ port, &mc_pool.flows_record);
dump_used_mem(port);
}
--
2.17.1