From: Wisam Jaddo <wisamm@nvidia.com>
To: <arybchenko@solarflare.com>, <thomas@monjalon.net>,
<akozyrev@nvidia.com>, <rasland@nvidia.com>, <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH v3 1/7] app/flow-perf: start using more generic wrapper for cycles
Date: Wed, 10 Mar 2021 15:53:47 +0200 [thread overview]
Message-ID: <20210310135353.8429-2-wisamm@nvidia.com> (raw)
In-Reply-To: <20210310135353.8429-1-wisamm@nvidia.com>
rdtsc() is x86 related, while this might fail for other archs,
so it's better to use more generic API for cycles measurement.
Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
---
app/test-flow-perf/main.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
index 99d0463456..8b5a11c15e 100644
--- a/app/test-flow-perf/main.c
+++ b/app/test-flow-perf/main.c
@@ -969,7 +969,7 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops)
end_counter = (core_id + 1) * rules_count_per_core;
cpu_time_used = 0;
- start_batch = rte_rdtsc();
+ start_batch = rte_get_timer_cycles();
for (counter = start_counter; counter < end_counter; counter++) {
if (ops == METER_CREATE)
create_meter_rule(port_id, counter);
@@ -984,10 +984,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops)
if (!((counter + 1) % rules_batch)) {
rules_batch_idx = ((counter + 1) / rules_batch) - 1;
cpu_time_per_batch[rules_batch_idx] =
- ((double)(rte_rdtsc() - start_batch))
- / rte_get_tsc_hz();
+ ((double)(rte_get_timer_cycles() - start_batch))
+ / rte_get_timer_hz();
cpu_time_used += cpu_time_per_batch[rules_batch_idx];
- start_batch = rte_rdtsc();
+ start_batch = rte_get_timer_cycles();
}
}
@@ -1089,7 +1089,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list)
if (flow_group > 0 && core_id == 0)
rules_count_per_core++;
- start_batch = rte_rdtsc();
+ start_batch = rte_get_timer_cycles();
for (i = 0; i < (uint32_t) rules_count_per_core; i++) {
if (flows_list[i] == 0)
break;
@@ -1107,12 +1107,12 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list)
* for this batch.
*/
if (!((i + 1) % rules_batch)) {
- end_batch = rte_rdtsc();
+ end_batch = rte_get_timer_cycles();
delta = (double) (end_batch - start_batch);
rules_batch_idx = ((i + 1) / rules_batch) - 1;
- cpu_time_per_batch[rules_batch_idx] = delta / rte_get_tsc_hz();
+ cpu_time_per_batch[rules_batch_idx] = delta / rte_get_timer_hz();
cpu_time_used += cpu_time_per_batch[rules_batch_idx];
- start_batch = rte_rdtsc();
+ start_batch = rte_get_timer_cycles();
}
}
@@ -1185,7 +1185,7 @@ insert_flows(int port_id, uint8_t core_id)
flows_list[flow_index++] = flow;
}
- start_batch = rte_rdtsc();
+ start_batch = rte_get_timer_cycles();
for (counter = start_counter; counter < end_counter; counter++) {
flow = generate_flow(port_id, flow_group,
flow_attrs, flow_items, flow_actions,
@@ -1211,12 +1211,12 @@ insert_flows(int port_id, uint8_t core_id)
* for this batch.
*/
if (!((counter + 1) % rules_batch)) {
- end_batch = rte_rdtsc();
+ end_batch = rte_get_timer_cycles();
delta = (double) (end_batch - start_batch);
rules_batch_idx = ((counter + 1) / rules_batch) - 1;
- cpu_time_per_batch[rules_batch_idx] = delta / rte_get_tsc_hz();
+ cpu_time_per_batch[rules_batch_idx] = delta / rte_get_timer_hz();
cpu_time_used += cpu_time_per_batch[rules_batch_idx];
- start_batch = rte_rdtsc();
+ start_batch = rte_get_timer_cycles();
}
}
--
2.17.1
next prev parent reply other threads:[~2021-03-10 13:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 9:11 [dpdk-dev] [PATCH 0/5] New flow-perf fixes Wisam Jaddo
2021-03-07 9:11 ` [dpdk-dev] [PATCH 1/5] app/flow-perf: start using more generic wrapper for cycles Wisam Jaddo
2021-03-10 13:45 ` [dpdk-dev] [PATCH v2 0/7] Enhancements and fixes for flow-perf Wisam Jaddo
2021-03-10 13:45 ` [dpdk-dev] [PATCH v2 1/7] app/flow-perf: start using more generic wrapper for cycles Wisam Jaddo
2021-03-10 13:45 ` [dpdk-dev] [PATCH v2 2/7] app/flow-perf: add new option to use unique data on the fly Wisam Jaddo
2021-03-10 13:45 ` [dpdk-dev] [PATCH v2 3/7] app/flow-perf: fix naming of CPU used structured data Wisam Jaddo
2021-03-10 13:45 ` [dpdk-dev] [PATCH v2 4/7] app/flow-perf: fix report total stats for masked ports Wisam Jaddo
2021-03-10 13:45 ` [dpdk-dev] [PATCH v2 5/7] app/flow-perf: fix the incremental IPv6 src set Wisam Jaddo
2021-03-10 13:45 ` [dpdk-dev] [PATCH v2 6/7] app/flow-perf: add first flow latency support Wisam Jaddo
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 0/7] Enhancements and fixes for flow-perf Wisam Jaddo
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 1/7] app/flow-perf: start using more generic wrapper for cycles Wisam Jaddo
2021-03-10 13:53 ` [dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf Wisam Jaddo
2021-03-10 13:53 ` Wisam Jaddo [this message]
2021-03-10 13:53 ` [dpdk-dev] [PATCH v3 2/7] app/flow-perf: add new option to use unique data on the fly Wisam Jaddo
2021-03-10 13:53 ` [dpdk-dev] [PATCH v3 3/7] app/flow-perf: fix naming of CPU used structured data Wisam Jaddo
2021-03-10 13:53 ` [dpdk-dev] [PATCH v3 4/7] app/flow-perf: fix report total stats for masked ports Wisam Jaddo
2021-03-10 13:53 ` [dpdk-dev] [PATCH v3 5/7] app/flow-perf: fix the incremental IPv6 src set Wisam Jaddo
2021-03-10 13:53 ` [dpdk-dev] [PATCH v3 6/7] app/flow-perf: add first flow latency support Wisam Jaddo
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf Wisam Jaddo
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 1/7] app/flow-perf: start using more generic wrapper for cycles Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v4 1/7] app/flow-perf: start using more generic wrapper for cycles Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v4 2/7] app/flow-perf: add new option to use unique data on the fly Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v4 3/7] app/flow-perf: fix naming of CPU used structured data Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v4 4/7] app/flow-perf: fix report total stats for masked ports Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v4 5/7] app/flow-perf: fix the incremental IPv6 src set Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v4 6/7] app/flow-perf: add first flow latency support Wisam Jaddo
2021-03-14 9:54 ` [dpdk-dev] [PATCH v4 7/7] app/flow-perf: fix setting decap data for decap actions Wisam Jaddo
2021-04-12 14:33 ` [dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf Thomas Monjalon
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 2/7] app/flow-perf: add new option to use unique data on the fly Wisam Jaddo
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 3/7] app/flow-perf: fix naming of CPU used structured data Wisam Jaddo
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 4/7] app/flow-perf: fix report total stats for masked ports Wisam Jaddo
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 5/7] app/flow-perf: fix the incremental IPv6 src set Wisam Jaddo
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 6/7] app/flow-perf: add first flow latency support Wisam Jaddo
2021-03-10 13:55 ` [dpdk-dev] [PATCH v3 7/7] app/flow-perf: fix setting decap data for decap actions Wisam Jaddo
2021-03-10 21:54 ` [dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf Alexander Kozyrev
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 2/7] app/flow-perf: add new option to use unique data on the fly Wisam Jaddo
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 3/7] app/flow-perf: fix naming of CPU used structured data Wisam Jaddo
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 4/7] app/flow-perf: fix report total stats for masked ports Wisam Jaddo
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 5/7] app/flow-perf: fix the incremental IPv6 src set Wisam Jaddo
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 6/7] app/flow-perf: add first flow latency support Wisam Jaddo
2021-03-10 13:48 ` [dpdk-dev] [PATCH v2 7/7] app/flow-perf: fix setting decap data for decap actions Wisam Jaddo
2021-03-07 9:11 ` [dpdk-dev] [PATCH 2/5] app/flow-perf: add new option to use unique data on the fly Wisam Jaddo
2021-03-07 9:12 ` [dpdk-dev] [PATCH 3/5] app/flow-perf: fix naming of CPU used structured data Wisam Jaddo
2021-03-07 9:12 ` [dpdk-dev] [PATCH 4/5] app/flow-perf: fix report total stats for masked ports Wisam Jaddo
2021-03-07 9:12 ` [dpdk-dev] [PATCH 5/5] app/flow-perf: fix the incremental IPv6 src set Wisam Jaddo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310135353.8429-2-wisamm@nvidia.com \
--to=wisamm@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).