From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BFCDA0567; Wed, 10 Mar 2021 14:56:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7857A22A6AE; Wed, 10 Mar 2021 14:56:09 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2080.outbound.protection.outlook.com [40.107.244.80]) by mails.dpdk.org (Postfix) with ESMTP id 46D3222A670 for ; Wed, 10 Mar 2021 14:56:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YKFrb4f06J2Ep6xagJCwWxeC61EznQZrmNXDL4WqMqQzGlyy76dMFn+zEjq4VwkiCW5zah4EcrShuChOhkUiR9C153q6PNK9RBZZiHpGFOPdb9d25z5B653loQ0PYxaOV+SjFbAlP/ebXBCvJYlFcsbqTAd/sOvIW/XTkYJxrpmg0mGxjTr8YlFXFGdFFkRPJzs3+6e96qFhKT2PQONwJ/dSeB84T9AzrAbSBCjd5G+X3UYo1Y1sw9fAFGc8wjNI5scz0LfB7whvTEBSzlm7HIWgkOGJu3RKYsxYCC93eMsoKpZcXPR3nOxv/Ae3E+TP4yLHrlYymzoCiWKz6Ivorg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=AnQgBEt1Ll3OF/dk+OzUAXtKcAQ3wv70ktOz6WEV2uVfHg3OqiwKzvV8FMRiVVvpS39eo3TyjqKk38qajql4ktCyzfV4UthiQwRFBG7aLv7HfF2iX4+ESYwo3lr0bdxiNTUOByLaCJVItSPsO1upwVyLHBCpE0ftys2fa70v99QIR5nTLg7Q9luJIdgP979wbOnNSNHD2ZEN7YKvI4cm6COy36SSW9VsmvAvrpfsgnZ2lIn1ZRdHMw7o0PRI2MUSs5TfoO7ZW3AL892RHJNxgB1mJIlwqAl1f0J9s0iQ5xf7SaBtJ8VSoVsnciJqiPJcQEJA4mraMQQ6N08w0NdvTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=fLRHUgEy+i6BUJwf2rkMhnsEFLRUd0VCrWZjPyP0kYU77Wvgo4DBf0tLRyHF8j5Z8v0Z9XKetDzRMEotVnScwex4GWbJYcxB/jYak/o53GesWK8W9LkgOaQ80YmJgx8naHAB2BYeUDpvNDeMqQuproO+pC6DpKTWTOob2cRJs1P0gsifwQmOA8FXKqVmYf7e4k0MS688EY2RNqstylDa2kjcKa4o5YyRA6QUxyhZdj+YYKusyeIjUfpqMLaAXfqRKPz1qwGJsS6nZbHKGGY0mFSc+yg2tolaW2PYBSQSm+0Dw5AWaDMYSkjqEq2NcBnHjmoBB3xc8oKn/8FeoplzIQ== Received: from BN9PR03CA0014.namprd03.prod.outlook.com (2603:10b6:408:fa::19) by MW3PR12MB4425.namprd12.prod.outlook.com (2603:10b6:303:5e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.18; Wed, 10 Mar 2021 13:56:06 +0000 Received: from BN8NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fa:cafe::52) by BN9PR03CA0014.outlook.office365.com (2603:10b6:408:fa::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26 via Frontend Transport; Wed, 10 Mar 2021 13:56:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT064.mail.protection.outlook.com (10.13.176.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 13:56:06 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar 2021 13:56:03 +0000 From: Wisam Jaddo To: , , , , CC: Date: Wed, 10 Mar 2021 15:55:42 +0200 Message-ID: <20210310135546.8680-4-wisamm@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210310135546.8680-1-wisamm@nvidia.com> References: <20210310134858.8104-2-wisamm@nvidia.com> <20210310135546.8680-1-wisamm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bcf8efb3-f6e6-4052-0ea1-08d8e3cc402c X-MS-TrafficTypeDiagnostic: MW3PR12MB4425: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:204; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 74TIZOfi/JKU+vQRUqwpe32tPrBKBgSLZZRP4fwdQvFFzoIQGI9JHECVbaTjwI/a7HqB43QsmIJ6IIQp2RPj0CR3wsaC1XdM+ZJdyysksBBaxN510quXZrtLQ7WCVcV4l0MzfFMN7Mn6QnX3a5wXTGutQA9IYSJ/P3ulh73lqwHecbx4kvb8uciQ4efwDyulqwfXiR3QmWUnafPfqX8FgdOwG73nPjnT6Fgonf376AQM4itWPLcPZBJ1QyQJzFJRhfxseDwa7UHEM4/kTUNQtVyIIbqvT/A9Zz82NSCroFnm3yZWhThngWKXS7Wiaehicf1gt6gBCQy6eaNKGuw+fY8gYiGyRxFLJSKjirzRzJpWGwro7aFuA7+AkS68D8YNgYAXydao2IvTw2WW8OLS6a/I8mMw8Jjiu7kepc6smkoV2v0hLJRLSgNaK1OIM4+7DJqVP5SahJZoGttnOP+qpKCcu9rF3aVs+iAbgjl82TDwXVPGPrb4g8RssJovKX90zQ7JUVmpXtX8/UjVBXOpmaMu2UcdbuouJxvmeJEZxeh3rUMeZ1/yr+HqAXwakWmrlQuSCPbrQK3fvoLv6zwshIIG3jIZ6QxDHFtoaYJW/HFxZwlLrqHB8rm74II9/3fo7shsxucwEsnUwd9m/QqZxBep1a2at8a+IRGbMcyrrko0ACcEa6KiN0mBNgAM2R/F X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(136003)(396003)(376002)(39860400002)(36840700001)(46966006)(36860700001)(55016002)(6286002)(47076005)(110136005)(7636003)(2616005)(4326008)(356005)(6666004)(83380400001)(36756003)(8936002)(316002)(82310400003)(26005)(5660300002)(86362001)(34020700004)(70206006)(36906005)(426003)(336012)(2906002)(8676002)(107886003)(1076003)(478600001)(16526019)(186003)(7696005)(70586007)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 13:56:06.0718 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcf8efb3-f6e6-4052-0ea1-08d8e3cc402c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4425 Subject: [dpdk-dev] [PATCH v3 3/7] app/flow-perf: fix naming of CPU used structured data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongzhou@nvidia.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index 4054178273..01607881df 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -105,8 +105,8 @@ struct used_cpu_time { struct multi_cores_pool { uint32_t cores_count; uint32_t rules_count; - struct used_cpu_time create_meter; - struct used_cpu_time create_flow; + struct used_cpu_time meters_record; + struct used_cpu_time flows_record; int64_t last_alloc[RTE_MAX_LCORE]; int64_t current_alloc[RTE_MAX_LCORE]; } __rte_cache_aligned; @@ -1013,10 +1013,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops) cpu_time_used, insertion_rate); if (ops == METER_CREATE) - mc_pool.create_meter.insertion[port_id][core_id] + mc_pool.meters_record.insertion[port_id][core_id] = cpu_time_used; else - mc_pool.create_meter.deletion[port_id][core_id] + mc_pool.meters_record.deletion[port_id][core_id] = cpu_time_used; } @@ -1134,7 +1134,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list) printf(":: Port %d :: Core %d :: The time for deleting %d rules is %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.deletion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.deletion[port_id][core_id] = cpu_time_used; } static struct rte_flow ** @@ -1241,7 +1241,7 @@ insert_flows(int port_id, uint8_t core_id) printf(":: Port %d :: Core %d :: The time for creating %d in rules %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.insertion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.insertion[port_id][core_id] = cpu_time_used; return flows_list; } @@ -1439,9 +1439,9 @@ run_rte_flow_handler_cores(void *data __rte_unused) RTE_ETH_FOREACH_DEV(port) { if (has_meter()) dump_used_cpu_time("Meters:", - port, &mc_pool.create_meter); + port, &mc_pool.meters_record); dump_used_cpu_time("Flows:", - port, &mc_pool.create_flow); + port, &mc_pool.flows_record); dump_used_mem(port); } -- 2.17.1