From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46BFDA056A; Wed, 10 Mar 2021 18:24:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32A8F22A3C2; Wed, 10 Mar 2021 18:24:54 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id F1F6C22A3AC for ; Wed, 10 Mar 2021 18:24:51 +0100 (CET) IronPort-SDR: 9dRGjqe47AfPtpJ6SKkiNg0l9qLLm/zV29A7qWdD3tB7TI34Qh7lnDJ2hCEqAAnDIK++vcVnS3 f0PntnGYJGhw== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="185164649" X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="185164649" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 09:24:47 -0800 IronPort-SDR: dbRJQW43GY4ruCszICgtONrXr384unCGc9pPh4cpiY6VhqSb+Hp7dVGaxwxXD7CBfIq6Q4UrCy I1Lolh8oCfGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="410271688" Received: from silpixa00399126.ir.intel.com ([10.237.223.188]) by orsmga008.jf.intel.com with ESMTP; 10 Mar 2021 09:24:46 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , Kevin Laatz , Ray Kinsella , Neil Horman Date: Wed, 10 Mar 2021 17:24:28 +0000 Message-Id: <20210310172430.412405-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210310172430.412405-1-bruce.richardson@intel.com> References: <20210310172430.412405-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration function internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function for registration of callbacks for legacy telemetry was documented as internal-only in the API documents, but marked as experimental in the version.map file. Since this is an internal-only function, for consistency we update the version mapping to have it as internal. Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/release_21_05.rst | 5 +++++ lib/librte_telemetry/rte_telemetry_legacy.h | 2 +- lib/librte_telemetry/version.map | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 23f7f0bff9..1624f43d73 100644 --- a/doc/guides/rel_notes/release_21_05.rst +++ b/doc/guides/rel_notes/release_21_05.rst @@ -117,6 +117,11 @@ ABI Changes * No ABI change that would break compatibility with 20.11. +* The experimental function ``rte_telemetry_legacy_register`` has been + removed from the public API and is now an internal-only function. This + function was already marked as internal in the API documentation for it, + and was not for use by external applications. + Known Issues ------------ diff --git a/lib/librte_telemetry/rte_telemetry_legacy.h b/lib/librte_telemetry/rte_telemetry_legacy.h index c83f9a8d90..fb44740186 100644 --- a/lib/librte_telemetry/rte_telemetry_legacy.h +++ b/lib/librte_telemetry/rte_telemetry_legacy.h @@ -78,7 +78,7 @@ legacy_client_handler(void *sock_id); * @return * -ENOENT if max callbacks limit has been reached. */ -__rte_experimental +__rte_internal int rte_telemetry_legacy_register(const char *cmd, enum rte_telemetry_legacy_data_req data_req, diff --git a/lib/librte_telemetry/version.map b/lib/librte_telemetry/version.map index ec0ebc1bec..bde80ce29b 100644 --- a/lib/librte_telemetry/version.map +++ b/lib/librte_telemetry/version.map @@ -14,12 +14,12 @@ EXPERIMENTAL { rte_tel_data_start_array; rte_tel_data_start_dict; rte_tel_data_string; - rte_telemetry_legacy_register; rte_telemetry_register_cmd; local: *; }; INTERNAL { + rte_telemetry_legacy_register; rte_telemetry_init; }; -- 2.27.0