From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>
Subject: [dpdk-dev] [PATCH 3/4] telemetry: create internal-only header file
Date: Wed, 10 Mar 2021 17:24:29 +0000 [thread overview]
Message-ID: <20210310172430.412405-4-bruce.richardson@intel.com> (raw)
In-Reply-To: <20210310172430.412405-1-bruce.richardson@intel.com>
The header file containing the legacy telemetry function prototypes was all
internal-only, so we rename the file to be an internal-only one to make it
clearer it's not for installation.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/librte_metrics/rte_metrics_telemetry.c | 2 +-
lib/librte_telemetry/telemetry.c | 2 +-
.../{rte_telemetry_legacy.h => telemetry_internal.h} | 6 +++---
lib/librte_telemetry/telemetry_legacy.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
rename lib/librte_telemetry/{rte_telemetry_legacy.h => telemetry_internal.h} (93%)
diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c
index b8ee56ef01..bbc6a79f88 100644
--- a/lib/librte_metrics/rte_metrics_telemetry.c
+++ b/lib/librte_metrics/rte_metrics_telemetry.c
@@ -7,7 +7,7 @@
#include <rte_ethdev.h>
#include <rte_string_fns.h>
#ifdef RTE_LIB_TELEMETRY
-#include <rte_telemetry_legacy.h>
+#include <telemetry_internal.h>
#endif
#include "rte_metrics.h"
diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c
index 18f2ae2e2f..c3c988e972 100644
--- a/lib/librte_telemetry/telemetry.c
+++ b/lib/librte_telemetry/telemetry.c
@@ -21,7 +21,7 @@
#include "rte_telemetry.h"
#include "telemetry_json.h"
#include "telemetry_data.h"
-#include "rte_telemetry_legacy.h"
+#include "telemetry_internal.h"
#define MAX_CMD_LEN 56
#define MAX_HELP_LEN 64
diff --git a/lib/librte_telemetry/rte_telemetry_legacy.h b/lib/librte_telemetry/telemetry_internal.h
similarity index 93%
rename from lib/librte_telemetry/rte_telemetry_legacy.h
rename to lib/librte_telemetry/telemetry_internal.h
index fb44740186..ad076b9119 100644
--- a/lib/librte_telemetry/rte_telemetry_legacy.h
+++ b/lib/librte_telemetry/telemetry_internal.h
@@ -2,8 +2,8 @@
* Copyright(c) 2020 Intel Corporation
*/
-#ifndef _RTE_TELEMETRY_LEGACY_H_
-#define _RTE_TELEMETRY_LEGACY_H_
+#ifndef _RTE_TELEMETRY_INTERNAL_H_
+#define _RTE_TELEMETRY_INTERNAL_H_
#include <rte_compat.h>
#include "rte_telemetry.h"
@@ -14,7 +14,7 @@
* @b EXPERIMENTAL: this API may change without prior notice
* @file
- * RTE Telemetry Legacy
+ * RTE Telemetry Legacy and internal definitions
*
***/
diff --git a/lib/librte_telemetry/telemetry_legacy.c b/lib/librte_telemetry/telemetry_legacy.c
index edd76ca359..5e9af37db1 100644
--- a/lib/librte_telemetry/telemetry_legacy.c
+++ b/lib/librte_telemetry/telemetry_legacy.c
@@ -15,7 +15,7 @@
#include <rte_common.h>
#include <rte_spinlock.h>
-#include "rte_telemetry_legacy.h"
+#include "telemetry_internal.h"
#define MAX_LEN 128
#define BUF_SIZE 1024
--
2.27.0
next prev parent reply other threads:[~2021-03-10 17:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 17:24 [dpdk-dev] [PATCH 0/4] telemetry logging improvements and cleanup Bruce Richardson
2021-03-10 17:24 ` [dpdk-dev] [PATCH 1/4] telemetry: use rte_log for logging Bruce Richardson
2021-03-11 12:50 ` Power, Ciara
2021-03-10 17:24 ` [dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration function internal Bruce Richardson
2021-03-11 12:50 ` Power, Ciara
2021-03-10 17:24 ` Bruce Richardson [this message]
2021-03-11 12:51 ` [dpdk-dev] [PATCH 3/4] telemetry: create internal-only header file Power, Ciara
2021-03-10 17:24 ` [dpdk-dev] [PATCH 4/4] telemetry: move init function to internal header Bruce Richardson
2021-03-11 12:51 ` Power, Ciara
2021-03-24 21:11 ` [dpdk-dev] [PATCH 0/4] telemetry logging improvements and cleanup Thomas Monjalon
2021-03-25 8:55 ` Bruce Richardson
2021-03-25 13:57 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2021-03-25 13:57 ` [dpdk-dev] [PATCH v2 1/4] telemetry: use rte_log for logging Bruce Richardson
2021-03-25 14:09 ` David Marchand
2021-03-25 14:16 ` Bruce Richardson
2021-03-25 13:57 ` [dpdk-dev] [PATCH v2 2/4] telemetry: make the legacy registration function internal Bruce Richardson
2021-03-25 13:57 ` [dpdk-dev] [PATCH v2 3/4] telemetry: rename internal-only header file Bruce Richardson
2021-03-25 13:57 ` [dpdk-dev] [PATCH v2 4/4] telemetry: move init function to internal header Bruce Richardson
2021-03-25 16:36 ` [dpdk-dev] [PATCH v2 0/4] telemetry logging improvements and cleanup Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310172430.412405-4-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).