From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com,
dmitry.kozliuk@gmail.com, dmitrym@microsoft.com,
david.marchand@redhat.com, anatoly.burakov@intel.com,
vladimir.medvedkin@intel.com, mb@smartsharesystems.com
Subject: Re: [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for thread TLS API
Date: Wed, 10 Mar 2021 11:45:34 -0800 [thread overview]
Message-ID: <20210310194534.GA12609@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20210310124856.8188-2-talshn@nvidia.com>
On Wed, Mar 10, 2021 at 02:48:55PM +0200, Tal Shnaiderman wrote:
> add error number reporting to rte_errno in all
> functions in the rte_thread_tls_* API.
>
> Suggested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/include/rte_thread.h | 14 +++++++++++---
> lib/librte_eal/unix/rte_thread.c | 6 ++++++
> lib/librte_eal/windows/rte_thread.c | 6 ++++++
> 3 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/include/rte_thread.h b/lib/librte_eal/include/rte_thread.h
After we introduce a translation function to map from Windows error
codes to errno style codes (as part of EAL threads API),
should we change this to directly return the error code from the functions?
Or do we follow the pattern of setting rte_errno?
next prev parent reply other threads:[~2021-03-10 19:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 15:26 [dpdk-dev] [PATCH v2 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-02 15:26 ` [dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-02 17:09 ` Dmitry Kozlyuk
2021-03-03 10:37 ` Tal Shnaiderman
2021-03-03 11:10 ` Dmitry Kozlyuk
2021-03-03 11:53 ` Tal Shnaiderman
2021-03-10 12:06 ` [dpdk-dev] [PATCH v3 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-10 12:06 ` [dpdk-dev] [PATCH v3 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-10 12:48 ` [dpdk-dev] [PATCH v4 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-10 12:48 ` [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-10 19:45 ` Narcisa Ana Maria Vasile [this message]
2021-03-15 15:37 ` Tal Shnaiderman
2021-03-13 2:29 ` Dmitry Kozlyuk
2021-03-15 23:14 ` Thomas Monjalon
2021-03-16 9:15 ` [dpdk-dev] [PATCH v5 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-16 9:15 ` [dpdk-dev] [PATCH v5 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-16 13:28 ` [dpdk-dev] [PATCH v6 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-16 13:28 ` [dpdk-dev] [PATCH v6 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-16 13:28 ` [dpdk-dev] [PATCH v6 2/2] eal: rename key opaque pointer and functions in " Tal Shnaiderman
2021-03-26 8:24 ` [dpdk-dev] [PATCH v6 0/2] EAL Thread TLS API enhancements Thomas Monjalon
2021-03-16 9:15 ` [dpdk-dev] [PATCH v5 2/2] eal: rename key opaque pointer and functions in TLS API Tal Shnaiderman
2021-03-10 12:48 ` [dpdk-dev] [PATCH v4 " Tal Shnaiderman
2021-03-15 23:16 ` Thomas Monjalon
2021-03-16 9:17 ` Tal Shnaiderman
2021-03-10 12:06 ` [dpdk-dev] [PATCH v3 " Tal Shnaiderman
2021-03-10 12:22 ` Morten Brørup
2021-03-02 15:26 ` [dpdk-dev] [PATCH v2 2/2] eal: rename key opaque pointer " Tal Shnaiderman
2021-03-02 15:36 ` Morten Brørup
2021-03-04 11:16 ` Tal Shnaiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310194534.GA12609@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=navasile@linux.microsoft.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=mb@smartsharesystems.com \
--cc=pallavi.kadam@intel.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).