From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7F015A056A;
	Wed, 10 Mar 2021 20:45:36 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0A3FC22A403;
	Wed, 10 Mar 2021 20:45:36 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id D403A40F35
 for <dev@dpdk.org>; Wed, 10 Mar 2021 20:45:34 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 1523D208CFB0; Wed, 10 Mar 2021 11:45:34 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1523D208CFB0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1615405534;
 bh=ADw8rpFkVUkRE/Hd3OxN+XgmuI/c9r6La2Yru9Iy0O0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=JoJg3tMek1r5wj9WnMV51YKhJaBHDjDQkjpb/2AtL1Imwlod7wgF8yBCs77OJ2TJE
 fKt2Vv2Uj30jyo+oZKlTW6f1mufyGpHNdpPsbkNjl1BAPuFGEVla6ZLDuIFNQq+rVx
 VNtBRSdimv61w8lTOIrA8ICrQuTLfKxaOl3kO1L0=
Date: Wed, 10 Mar 2021 11:45:34 -0800
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com,
 dmitry.kozliuk@gmail.com, dmitrym@microsoft.com,
 david.marchand@redhat.com, anatoly.burakov@intel.com,
 vladimir.medvedkin@intel.com, mb@smartsharesystems.com
Message-ID: <20210310194534.GA12609@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20210310120632.14464-2-talshn@nvidia.com>
 <20210310124856.8188-1-talshn@nvidia.com>
 <20210310124856.8188-2-talshn@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210310124856.8188-2-talshn@nvidia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for
 thread TLS API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 10, 2021 at 02:48:55PM +0200, Tal Shnaiderman wrote:
> add error number reporting to rte_errno in all
> functions in the rte_thread_tls_* API.
> 
> Suggested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>  lib/librte_eal/include/rte_thread.h | 14 +++++++++++---
>  lib/librte_eal/unix/rte_thread.c    |  6 ++++++
>  lib/librte_eal/windows/rte_thread.c |  6 ++++++
>  3 files changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eal/include/rte_thread.h b/lib/librte_eal/include/rte_thread.h

After we introduce a translation function to map from Windows error 
codes to errno style codes (as part of EAL threads API),
should we change this to directly return the error code from the functions?
Or do we follow the pattern of setting rte_errno?