From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08B62A056A; Wed, 10 Mar 2021 22:27:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E49C22A58B; Wed, 10 Mar 2021 22:26:57 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 7080722A572 for ; Wed, 10 Mar 2021 22:26:54 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id s7so9138059plg.5 for ; Wed, 10 Mar 2021 13:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=UZjcAhK1Nd0AFFaxS8Sn1DV8uvO+U/ogdqg5L3Cmgdc=; b=BX0HpJr5AdZaBjuWLlZSAodvErFglL8k+2DH6B4R+SHGtCLRdSy/kXYAY7EHO5dLi6 jlIuN6Y5owJwoNwxB6WtfBFy4XNGx3YVtij/4IEzBMxmop/Xai19ACz7QHK97m5bSV8f 2udzs3OStmUSzv6yj8eId7BgoSzG2qI4RO+5U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=UZjcAhK1Nd0AFFaxS8Sn1DV8uvO+U/ogdqg5L3Cmgdc=; b=PhC0UDpOQ1oqsvaPrHxY0o5IOmzhpnYK01Iy0fykl0wib6hlCYhpOLmjlJmyPkSgY0 pAAWv40F+ckv+wLLeAjTPuCM7pRBO75VvjKUsuk5UbXdR87/OaHtBUMq/MtntuUg88cW lyK//Ja0NjbvU+hf26UppU9OUzr7NViXu6S1gxQP+3g24QahB3RfUOrSMDHh0X+WgqvD AQ0QZmgCFQ8u0ZEYUU9Q0Y705JQxpyUCWNP8ABKKhjcGJR4DEzTEtGxT2TdO5szpSaJi 1n398XRFkqdE/SJ+3bymcacaRNOs5dqwZDDwI5edk/BKDDt+8LW9az1cL7OrLHM24Id7 Jprg== X-Gm-Message-State: AOAM5337248DTtGYcDpwzzFUCIRUSBVAo1ebaTZ3RTPJN6YB36YO7AFa pC/iDKoRk7GiffIdkPncrqWneg== X-Google-Smtp-Source: ABdhPJw1ylA/2It6Cx4kH1dXBeF2Orx8Qsr+fqu1p+Z9tIv/yaAVsb4nk5HP7UEP7tROLn9FxInczA== X-Received: by 2002:a17:90a:bd90:: with SMTP id z16mr5633871pjr.123.1615411613557; Wed, 10 Mar 2021 13:26:53 -0800 (PST) Received: from localhost.localdomain ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id f2sm265059pju.46.2021.03.10.13.26.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Mar 2021 13:26:52 -0800 (PST) From: Ajit Khaparde To: ferruh.yigit@intel.com Cc: ajit.khaparde@broadcom.com, dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com, Venkat Duvvuru , stable@dpdk.org, Somnath Kotur Date: Wed, 10 Mar 2021 13:26:30 -0800 Message-Id: <20210310212637.72205-6-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210310212637.72205-1-ajit.khaparde@broadcom.com> References: <20210310212637.72205-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000697cd505bd3553bd" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v2 05/12] net/bnxt: fix queues per VNIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000697cd505bd3553bd Content-Transfer-Encoding: 8bit From: Venkat Duvvuru Update queues per VNIC in single queue mode. bp->rx_num_qs_per_vnic is not initialized in the single queue mode. As a result of this when an interface is reconfigured to single queue mode from an existing multiqueue mode, bp->rx_num_qs_per_vnic is not updated to the value of 1. Hence, the driver will try to access more than one queue resulting in a crash. This patch fixes it by initializing bp->rx_num_qs_per_vnic in the single queue mode as well. Fixes: 36024b2e7fe5 ("net/bnxt: allow dynamic creation of VNIC") Cc: stable@dpdk.org Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index f46b10c1c5..53a9b52a46 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -106,7 +106,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp) pools = RTE_MIN(pools, bp->rx_cp_nr_rings); nb_q_per_grp = bp->rx_cp_nr_rings / pools; - bp->rx_num_qs_per_vnic = nb_q_per_grp; PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp); start_grp_id = 0; @@ -165,6 +164,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp) } out: + bp->rx_num_qs_per_vnic = nb_q_per_grp; + if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) { struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf; -- 2.21.1 (Apple Git-122.3) --000000000000697cd505bd3553bd--