From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C661A056A; Wed, 10 Mar 2021 22:27:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC60A22A5DA; Wed, 10 Mar 2021 22:27:03 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 7892A22A59C for ; Wed, 10 Mar 2021 22:27:00 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id l7so13042316pfd.3 for ; Wed, 10 Mar 2021 13:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=0hB3qKqxMWuyOVxkYdK/0O8Z7IXGBB4yu4YVPIex280=; b=Ay/oT88SF1SLBpiuGJAlC8FY3wIJ3bQalzGWDkLlvbDbvaFd3Uzop1XD9mWzhFknBX 7DBV10AI9+Vlh5yIFdl/+tXrsRHh4W/F9nHd06ZVSyiEFBJOlgfx0vtIYU08hiS77nUY +pw53fVPaNyQz6Ohw1q6Akxg7/yx1eUr4C5Bk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=0hB3qKqxMWuyOVxkYdK/0O8Z7IXGBB4yu4YVPIex280=; b=cfe8GXKf+wkmtPXciEN6nbL0JzYRSQPCQFEwEy7VsTte6QIlq7J1Aol4y+AIzYWeAZ nqqru5XwBX6qHV0Hjijpbfuyggln07iJfI3HAdmmZfeSkgx/lkGfdeo0LbD2IjwICMSr wJVsuIjC252uJgmP6FAacAsNlZ+hLLyp9Ph8qZApM9/aKnd3q9YKCjz0+N6pDkSXGXsu pKU3gzXoW9JuoCVPkTdCL1JQrTK600RHgykdCRl4BUX0JE0TBRH9RdQdnF5a6Dvd7u5F EVzvVsI8XjsrbiLDwZPV2O0uUsS55ix3BvbHn9pmUhrsVEBpmI7ey4RdHVQeDUrLERCS 0LKQ== X-Gm-Message-State: AOAM5322L2gviyoj8JUv3NWSUiiKMbLxNVmC8uFNx3oz9lGeFBsvAGLR IyZpOd6Ufem9f9UYXGxjnwvQgA== X-Google-Smtp-Source: ABdhPJw2PWyp1KV6vUDgu0kizw9Q2hpeERKzxGdnI4Sj/JFUPhrLtzm8YqbIYsp3wvnm0+qf/K1Kkw== X-Received: by 2002:a65:560b:: with SMTP id l11mr95451pgs.362.1615411619675; Wed, 10 Mar 2021 13:26:59 -0800 (PST) Received: from localhost.localdomain ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id f2sm265059pju.46.2021.03.10.13.26.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Mar 2021 13:26:59 -0800 (PST) From: Ajit Khaparde To: ferruh.yigit@intel.com Cc: ajit.khaparde@broadcom.com, dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com, Somnath Kotur Date: Wed, 10 Mar 2021 13:26:33 -0800 Message-Id: <20210310212637.72205-9-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210310212637.72205-1-ajit.khaparde@broadcom.com> References: <20210310212637.72205-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000c6761905bd3553ef" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v2 08/12] net/bnxt: log port id in async events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000c6761905bd3553ef Content-Transfer-Encoding: 8bit From: Kalesh AP 1. Used port id in async event logs. 2. Added a debug log in bnxt_hwrm_func_driver_unregister(). Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 14 +++++++++----- drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c index b7be3e8e05..20b4f929ba 100644 --- a/drivers/net/bnxt/bnxt_cpr.c +++ b/drivers/net/bnxt/bnxt_cpr.c @@ -100,6 +100,7 @@ void bnxt_handle_async_event(struct bnxt *bp, struct hwrm_async_event_cmpl *async_cmp = (struct hwrm_async_event_cmpl *)cmp; uint16_t event_id = rte_le_to_cpu_16(async_cmp->event_id); + uint16_t port_id = bp->eth_dev->data->port_id; struct bnxt_error_recovery_info *info; uint32_t event_data; @@ -145,11 +146,13 @@ void bnxt_handle_async_event(struct bnxt *bp, if ((event_data & EVENT_DATA1_REASON_CODE_MASK) == EVENT_DATA1_REASON_CODE_FW_EXCEPTION_FATAL) { PMD_DRV_LOG(INFO, - "Firmware fatal reset event received\n"); + "Port %u: Firmware fatal reset event received\n", + port_id); bp->flags |= BNXT_FLAG_FATAL_ERROR; } else { PMD_DRV_LOG(INFO, - "Firmware non-fatal reset event received\n"); + "Port %u: Firmware non-fatal reset event received\n", + port_id); } bp->flags |= BNXT_FLAG_FW_RESET; @@ -163,7 +166,8 @@ void bnxt_handle_async_event(struct bnxt *bp, if (!info) return; - PMD_DRV_LOG(INFO, "Error recovery async event received\n"); + PMD_DRV_LOG(INFO, "Port %u: Error recovery async event received\n", + port_id); event_data = rte_le_to_cpu_32(async_cmp->event_data1) & EVENT_DATA1_FLAGS_MASK; @@ -178,8 +182,8 @@ void bnxt_handle_async_event(struct bnxt *bp, else info->flags &= ~BNXT_FLAG_RECOVERY_ENABLED; - PMD_DRV_LOG(INFO, "recovery enabled(%d), master function(%d)\n", - bnxt_is_recovery_enabled(bp), + PMD_DRV_LOG(INFO, "Port %u: recovery enabled(%d), master function(%d)\n", + port_id, bnxt_is_recovery_enabled(bp), bnxt_is_master_func(bp)); if (bp->flags & BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index fc47950fbd..37fa78e79f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1336,6 +1336,8 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf) HWRM_CHECK_RESULT(); HWRM_UNLOCK(); + PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n", + bp->eth_dev->data->port_id); return rc; } -- 2.21.1 (Apple Git-122.3) --000000000000c6761905bd3553ef--