From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBE32A0576; Thu, 11 Mar 2021 13:13:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F63E40689; Thu, 11 Mar 2021 13:13:45 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 3A1F940141 for ; Thu, 11 Mar 2021 13:13:43 +0100 (CET) IronPort-SDR: e+m/IgkgYDTKJrhjxmHYOkj5ODJWGrlcUKlDjJRveJR6GR1+mHB9U6EZ5HvNNBoo9MDkp3lG5q FA8nLcPcXy5A== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="185301104" X-IronPort-AV: E=Sophos;i="5.81,240,1610438400"; d="scan'208";a="185301104" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 04:13:39 -0800 IronPort-SDR: MVxsh0XijI6ZuM+YY6d+ZMnQQMwtnUVaXkGHUM9I7FsbEHAHSv1loSWLOU3OJqcHcdppenigOp nqC+nxJ0WvYQ== X-IronPort-AV: E=Sophos;i="5.81,240,1610438400"; d="scan'208";a="448268472" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.238]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Mar 2021 04:13:38 -0800 Date: Thu, 11 Mar 2021 12:13:34 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20210311121334.GA1509@bricha3-MOBL.ger.corp.intel.com> References: <20210310172137.59938-1-sthemmin@microsoft.com> <20210310172717.GE1267@bricha3-MOBL.ger.corp.intel.com> <20210310103350.133bfdf2@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310103350.133bfdf2@hermes.local> Subject: Re: [dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 10, 2021 at 10:33:50AM -0800, Stephen Hemminger wrote: > On Wed, 10 Mar 2021 17:27:17 +0000 > Bruce Richardson wrote: > > > On Wed, Mar 10, 2021 at 09:21:37AM -0800, Stephen Hemminger wrote: > > > There can be cases such as containers or other runtime environments > > > where DPDK may not be able to access the default runtime path. > > > This patch introduces DPDK_RUNTIME_DIR as an environment variable > > > to allow controlling and overriding the path. > > > > > > The example we have is DPDK application running in an untrusted > > > systemd container. In this case, it is not root, and XDG_RUNTIME_DIR > > > is not set (since it is not a user application), and /tmp is > > > blocked. The correct place for this application is to use /run. > > > > > > In any case, hard coded path assumptions are a problem. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > > Basic question, if the user/operator can set DPDK_RUNTIME_DIR in the > > container, can they not also set XDG_RUNTIME_DIR? > > Yes they could, but more about not having hard coded paths. As far as I can see, you aren't removing the hard-coded path to "/tmp" in your patch, so unless I'm missing something I'm not seeing the significance of the change here? It largely just seems to be adding a new environment variable on top of the existing one, while changing nothing if neither is set. /Bruce