From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: John Alexander <John.Alexander@datapath.co.uk>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Declan Doherty <declan.doherty@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Ashish Gupta <ashish.gupta@marvell.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility
Date: Thu, 11 Mar 2021 20:01:01 +0300 [thread overview]
Message-ID: <20210311200101.2031f1e0@sovereign> (raw)
In-Reply-To: <AM9PR09MB490036DF57F7D4BE28B449D9B4909@AM9PR09MB4900.eurprd09.prod.outlook.com>
2021-03-11 16:19 (UTC+0000), John Alexander:
[...]
> > * `struct rte_param_log2_range`, `struct rte_crypto_param_range`:
> >
> > * `min` -> `minimum`
> > * `max` -> `maximum`
>
>
> The min/max macros in the Windows headers cause issues with C++ projects also (breaks std::min/std::max). The fix there is to "#define NOMINMAX" prior to including windows.h, maybe that's appropriate here too?
We don't control include order in user code and we shouldn't #undef system
macros in public headers. We could push_macro/pop_macro around structure
definition and have min/max undefined in DPDK internal code, so that including
this header always works. Then, if user wants to access the fields, they
should take care of macros themselves.
next prev parent reply other threads:[~2021-03-11 17:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 22:51 [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields Dmitry Kozlyuk
2021-03-03 23:54 ` Stephen Hemminger
2021-03-04 7:09 ` Dmitry Kozlyuk
2021-05-20 14:28 ` Ferruh Yigit
2021-03-10 23:54 ` [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility Dmitry Kozlyuk
2021-03-11 16:19 ` John Alexander
2021-03-11 17:01 ` Dmitry Kozlyuk [this message]
2021-03-11 17:08 ` Tyler Retzlaff
2021-03-16 10:37 ` Thomas Monjalon
2021-05-20 18:42 ` [dpdk-dev] [PATCH v3] " Dmitry Kozlyuk
2021-05-20 18:59 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-20 19:31 ` Dmitry Kozlyuk
2021-05-20 20:17 ` Akhil Goyal
2021-06-09 15:52 ` Dmitry Kozlyuk
2021-06-23 15:14 ` Dmitry Kozlyuk
2021-06-17 14:27 ` Tyler Retzlaff
2021-07-21 19:55 ` [dpdk-dev] " Dmitry Kozlyuk
2021-07-21 19:55 ` [dpdk-dev] [PATCH v4] " Dmitry Kozlyuk
2021-08-02 12:13 ` Thomas Monjalon
2021-08-02 12:45 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-08-02 13:00 ` Dmitry Kozlyuk
2021-08-02 13:48 ` Akhil Goyal
2021-08-02 14:57 ` Tal Shnaiderman
2021-08-02 17:46 ` Thomas Monjalon
2021-05-20 14:24 ` [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields Ferruh Yigit
2021-05-20 15:06 ` Dmitry Kozlyuk
2021-05-20 15:27 ` Ferruh Yigit
2021-05-20 15:50 ` Dmitry Kozlyuk
2021-05-20 16:04 ` Ferruh Yigit
2021-05-20 16:16 ` Dmitry Kozlyuk
2021-05-20 16:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311200101.2031f1e0@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=John.Alexander@datapath.co.uk \
--cc=ashish.gupta@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=nhorman@tuxdriver.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).