From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0E95A0547; Fri, 12 Mar 2021 16:34:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7F691608BB; Fri, 12 Mar 2021 16:34:27 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 51FB61608AD for ; Fri, 12 Mar 2021 16:34:26 +0100 (CET) IronPort-SDR: bZGL2IB/Jv3GwGtRV9X+b3bZps/bm9GaVEmqY3S4hrLynXECQbOp09rqZHHamLE8KwqRkh7Vpz lUpe+xCdq0Jg== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="175971890" X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="175971890" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 07:34:25 -0800 IronPort-SDR: hJmCYPnvhQwqJJ930e80ZriSoVQn0S8S9amHRox068cBqzW/AmUHGOSb0JLS3BLUWBJyh5YCSb GIMNt/EfprJw== X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="510356059" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.209]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Mar 2021 07:34:23 -0800 Date: Fri, 12 Mar 2021 15:34:19 +0000 From: Bruce Richardson To: David Marchand Cc: Ferruh Yigit , Tyler Retzlaff , dev , Thomas Monjalon , Andrew Rybchenko Message-ID: <20210312153419.GB937@bricha3-MOBL.ger.corp.intel.com> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <2da8b376-9016-11e6-8891-6db3957c7d79@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 12, 2021 at 04:25:09PM +0100, David Marchand wrote: > On Fri, Mar 12, 2021 at 4:20 PM Ferruh Yigit wrote: > > > > On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: > > > Introduce a meson option enable_driver_sdk when true installs internal > > > driver headers for ethdev. this allows drivers that do not depend on > > > stable api/abi to be built external to the dpdk source tree. > > > > > > Signed-off-by: Tyler Retzlaff > > > --- > > > > > > it's still unclear to me if we should be renaming the headers: > > > > > > ethdev_driver.h -> rte_ethdev_driver.h > > > ethdev_pci.h -> rte_ethdev_pci.h > > > ethdev_vdev.h -> rte_ethdev_vdev.h > > > > > > lib/librte_ethdev/meson.build | 5 +++++ > > > meson_options.txt | 2 ++ > > > 2 files changed, 7 insertions(+) > > > > > > diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > > > index c37b2e377..7ecdec6f0 100644 > > > --- a/lib/librte_ethdev/meson.build > > > +++ b/lib/librte_ethdev/meson.build > > > @@ -20,6 +20,11 @@ headers = files('rte_ethdev.h', > > > 'rte_mtr_driver.h', > > > 'rte_tm.h', > > > 'rte_tm_driver.h') > > > +if get_option('enable_driver_sdk') > > > +headers += files('ethdev_driver.h', > > > + 'ethdev_pci.h', > > > + 'ethdev_vdev.h') > > > +endif > > > > Instead of adding the "get_option('enable_driver_sdk')" checks to the modules, > > what about a more generic solution, like: > > > > modules assign relevant headers into a new variable, let's say 'pmd_headers', > > and in a high level meson file, all 'pmd_headers' are installed if > > 'enable_driver_sdk' enabled? > > > > +1. > Just, I don't like "pmd_headers" as the list name. > It can be misunderstood as the list of pmd-specific headers (thinking > of rte_pmd_i40e.h), that are exposed to applications. > Since the option is called "enable_driver_sdk" the variable name of "driver_sdk_headers" would be a good match. We should try and keep variable names and option names in sync as much as possible.