From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 698A1A0547;
	Fri, 12 Mar 2021 19:43:57 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 26DE81608E1;
	Fri, 12 Mar 2021 19:43:57 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id BE49F1608DA
 for <dev@dpdk.org>; Fri, 12 Mar 2021 19:43:55 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id D6DB6209B340; Fri, 12 Mar 2021 10:43:54 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D6DB6209B340
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1615574634;
 bh=NxlR7HL4wFacHar/mXo0/DPrd4ED/r3juG3189ZvkQA=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=OsP/VAAu8Uzak9i4YLru/gYSKBvOGiKjKBXYrYBR8cme5LXROdHz4PQD0isNLKRRw
 GM4W3LoDhzHhabmEK6U1Ebnr61O2ai9YU2BbB8nfsicMMT927qH9lsl+2NcCqSeutZ
 T94EoU6s5d8sMaXO9fF0D24qcT+5Zbflsf1BMH8A=
Date: Fri, 12 Mar 2021 10:43:54 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <20210312184354.GC23744@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8x3nUawqjWUUGmraAYRXZqEcOz_GAiASsRmsY8M8R5yQA@mail.gmail.com>
 <20210312153419.GB937@bricha3-MOBL.ger.corp.intel.com>
 <2611050.R5Dl0tXAX9@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2611050.R5Dl0tXAX9@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to
 install driver headers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 12, 2021 at 04:52:05PM +0100, Thomas Monjalon wrote:
> 12/03/2021 16:34, Bruce Richardson:
> > > >
> > > > Instead of adding the "get_option('enable_driver_sdk')" checks to the modules,
> > > > what about a more generic solution, like:
> > > >
> > > > modules assign relevant headers into a new variable, let's say 'pmd_headers',
> > > > and in a high level meson file, all 'pmd_headers' are installed if
> > > > 'enable_driver_sdk' enabled?
> > > >
> > > 
> > > +1.
> > > Just, I don't like "pmd_headers" as the list name.
> > > It can be misunderstood as the list of pmd-specific headers (thinking
> > > of rte_pmd_i40e.h), that are exposed to applications.
> > >
> > Since the option is called "enable_driver_sdk" the variable name of
> > "driver_sdk_headers" would be a good match. We should try and keep variable
> > names and option names in sync as much as possible.
> 
> +1
> 

seems like there is consensus. i'll figure out how introduce a
driver_sdk_headers variable generically and remove the per-meson.build
conditional evaluation.

thanks