DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: dev@dpdk.org
Cc: Pallavi Kadam <pallavi.kadam@intel.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-dev] [PATCH v3 1/4] cmdline: remove POSIX dependency
Date: Sun, 14 Mar 2021 01:22:13 +0300	[thread overview]
Message-ID: <20210313222217.18271-2-dmitry.kozliuk@gmail.com> (raw)
In-Reply-To: <20210313222217.18271-1-dmitry.kozliuk@gmail.com>

Use <rte_ip.h> for IP-related defines instead of POSIX headers.

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols")

 examples/cmdline/commands.c                  | 1 -
 examples/cmdline/parse_obj_list.c            | 2 --
 lib/librte_cmdline/cmdline.c                 | 1 -
 lib/librte_cmdline/cmdline_parse.c           | 2 --
 lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 ------
 lib/librte_cmdline/cmdline_parse_ipaddr.c    | 6 ------
 lib/librte_cmdline/cmdline_parse_ipaddr.h    | 2 +-
 lib/librte_net/rte_ip.h                      | 3 +++
 8 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/examples/cmdline/commands.c b/examples/cmdline/commands.c
index f43eacfbad..2c62d04fb0 100644
--- a/examples/cmdline/commands.c
+++ b/examples/cmdline/commands.c
@@ -10,7 +10,6 @@
 #include <stdlib.h>
 #include <stdarg.h>
 #include <errno.h>
-#include <netinet/in.h>
 #ifdef RTE_EXEC_ENV_FREEBSD
 #include <sys/socket.h>
 #endif
diff --git a/examples/cmdline/parse_obj_list.c b/examples/cmdline/parse_obj_list.c
index b04adbea58..959bcd1452 100644
--- a/examples/cmdline/parse_obj_list.c
+++ b/examples/cmdline/parse_obj_list.c
@@ -6,11 +6,9 @@
 
 #include <stdio.h>
 #include <inttypes.h>
-#include <stdarg.h>
 #include <errno.h>
 #include <ctype.h>
 #include <string.h>
-#include <netinet/in.h>
 
 #include <cmdline_parse.h>
 #include <cmdline_parse_ipaddr.h>
diff --git a/lib/librte_cmdline/cmdline.c b/lib/librte_cmdline/cmdline.c
index 49770869bb..a176d15130 100644
--- a/lib/librte_cmdline/cmdline.c
+++ b/lib/librte_cmdline/cmdline.c
@@ -12,7 +12,6 @@
 #include <inttypes.h>
 #include <fcntl.h>
 #include <errno.h>
-#include <netinet/in.h>
 
 #include <rte_string_fns.h>
 
diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c
index fe366841cd..f5cc934782 100644
--- a/lib/librte_cmdline/cmdline_parse.c
+++ b/lib/librte_cmdline/cmdline_parse.c
@@ -11,8 +11,6 @@
 #include <inttypes.h>
 #include <ctype.h>
 
-#include <netinet/in.h>
-
 #include <rte_string_fns.h>
 
 #include "cmdline_private.h"
diff --git a/lib/librte_cmdline/cmdline_parse_etheraddr.c b/lib/librte_cmdline/cmdline_parse_etheraddr.c
index 5cb10de321..433b828a72 100644
--- a/lib/librte_cmdline/cmdline_parse_etheraddr.c
+++ b/lib/librte_cmdline/cmdline_parse_etheraddr.c
@@ -5,13 +5,7 @@
  */
 
 #include <stdio.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <errno.h>
-#include <inttypes.h>
-#include <ctype.h>
 #include <string.h>
-#include <sys/types.h>
 
 #include <rte_string_fns.h>
 #include <rte_ether.h>
diff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.c b/lib/librte_cmdline/cmdline_parse_ipaddr.c
index f8dbdf204c..5e278c963f 100644
--- a/lib/librte_cmdline/cmdline_parse_ipaddr.c
+++ b/lib/librte_cmdline/cmdline_parse_ipaddr.c
@@ -6,14 +6,8 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <stdarg.h>
-#include <inttypes.h>
-#include <ctype.h>
 #include <string.h>
 #include <errno.h>
-#include <arpa/inet.h>
-#include <netinet/in.h>
-#include <sys/socket.h>
 
 #include <rte_string_fns.h>
 
diff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.h b/lib/librte_cmdline/cmdline_parse_ipaddr.h
index 0ba81647bc..0118c31d44 100644
--- a/lib/librte_cmdline/cmdline_parse_ipaddr.h
+++ b/lib/librte_cmdline/cmdline_parse_ipaddr.h
@@ -8,7 +8,7 @@
 #define _PARSE_IPADDR_H_
 
 #include <cmdline_parse.h>
-#include <netinet/in.h>
+#include <rte_ip.h>
 
 #ifdef __cplusplus
 extern "C" {
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 212ff2c4fd..2cf7b0bd28 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -16,7 +16,10 @@
  */
 
 #include <stdint.h>
+
+#include <sys/socket.h>
 #include <sys/types.h>
+#include <arpa/inet.h>
 #include <netinet/in.h>
 #include <netinet/ip.h>
 
-- 
2.29.2


  reply	other threads:[~2021-03-13 22:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13  1:56 [dpdk-dev] [PATCH 0/4] net: replace Windows networking shim Dmitry Kozlyuk
2021-03-13  1:56 ` [dpdk-dev] [PATCH 1/4] cmdline: remove POSIX dependency Dmitry Kozlyuk
2021-03-13  1:56 ` [dpdk-dev] [PATCH 2/4] ethdev: " Dmitry Kozlyuk
2021-03-13  1:56 ` [dpdk-dev] [PATCH 3/4] net/mlx5: " Dmitry Kozlyuk
2021-03-13  1:56 ` [dpdk-dev] [PATCH 4/4] net: replace Windows networking shim Dmitry Kozlyuk
2021-03-13  2:56 ` [dpdk-dev] [PATCH v2 0/4] " Dmitry Kozlyuk
2021-03-13  2:56   ` [dpdk-dev] [PATCH v2 1/4] cmdline: remove POSIX dependency Dmitry Kozlyuk
2021-03-13  2:56   ` [dpdk-dev] [PATCH v2 2/4] ethdev: " Dmitry Kozlyuk
2021-03-13  2:56   ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: " Dmitry Kozlyuk
2021-03-13  2:56   ` [dpdk-dev] [PATCH v2 4/4] net: replace Windows networking shim Dmitry Kozlyuk
2021-03-13 22:22   ` [dpdk-dev] [PATCH v3 0/4] " Dmitry Kozlyuk
2021-03-13 22:22     ` Dmitry Kozlyuk [this message]
2021-03-17 17:22       ` [dpdk-dev] [PATCH v3 1/4] cmdline: remove POSIX dependency Tyler Retzlaff
2021-03-13 22:22     ` [dpdk-dev] [PATCH v3 2/4] ethdev: " Dmitry Kozlyuk
2021-03-17 17:22       ` Tyler Retzlaff
2021-03-13 22:22     ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: " Dmitry Kozlyuk
2021-03-17 17:22       ` Tyler Retzlaff
2021-03-13 22:22     ` [dpdk-dev] [PATCH v3 4/4] net: replace Windows networking shim Dmitry Kozlyuk
2021-03-15 13:03     ` [dpdk-dev] [PATCH v3 0/4] " Ferruh Yigit
2021-03-15 13:23       ` Dmitry Kozlyuk
2021-03-17 19:19     ` Ranjit Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210313222217.18271-2-dmitry.kozliuk@gmail.com \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=olivier.matz@6wind.com \
    --cc=pallavi.kadam@intel.com \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).