* [dpdk-dev] [RFC PATCH] meson: remove unnecessary explicit link to libpcap
@ 2021-03-15 10:52 Gabriel Ganne
0 siblings, 0 replies; only message in thread
From: Gabriel Ganne @ 2021-03-15 10:52 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, olivier.matz, thierry.herbelot
libpcap is already found and registered as a dependency by meson, and
the dependency is already correctly used in librte_port. This line is
just unnecessary.
It also has the side effect of messing with the meson link line: dpdk
link will be declared twice: manually and then through pkg-config. If
you configure meson to prefer static linking over dynamic, this will
cause the build to fail on librte_port, since the pcap deps are not yet
seen by the linker.
Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
---
config/meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/config/meson.build b/config/meson.build
index 0fb7e1b27a0f..3eb90327dfcc 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -177,7 +177,6 @@ if not pcap_dep.found()
endif
if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)
dpdk_conf.set('RTE_PORT_PCAP', 1)
- dpdk_extra_ldflags += '-lpcap'
endif
# for clang 32-bit compiles we need libatomic for 64-bit atomic ops
--
2.29.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-15 10:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 10:52 [dpdk-dev] [RFC PATCH] meson: remove unnecessary explicit link to libpcap Gabriel Ganne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).