[dpdk-dev] [PATCH] net/bnxt: fix unchecked return value

[dpdk-dev] [PATCH] net/bnxt: fix unchecked return value

[Kalesh A P]

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

CID 363716 (#1 of 1): Unchecked return value (CHECKED_RETURN)
check_return: Calling rte_pci_write_config without checking
return value (as is done elsewhere 46 out of 49 times).

Coverity issue: 363716

Fixes: be14720def9c ("net/bnxt: support FW reset")
Cc: stable@dpdk.org

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 6cc6af0..202b082 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3860,13 +3860,19 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, uint32_t index)
 	uint32_t val = info->reset_reg_val[index];
 	uint32_t reg = info->reset_reg[index];
 	uint32_t type, offset;
+	int ret;
 
 	type = BNXT_FW_STATUS_REG_TYPE(reg);
 	offset = BNXT_FW_STATUS_REG_OFF(reg);
 
 	switch (type) {
 	case BNXT_FW_STATUS_REG_TYPE_CFG:
-		rte_pci_write_config(bp->pdev, &val, sizeof(val), offset);
+		ret = rte_pci_write_config(bp->pdev, &val, sizeof(val), offset);
+		if (ret < 0) {
+			PMD_DRV_LOG(ERR, "Failed to write %#x at PCI offset %#x",
+				    val, offset);
+			return;
+		}
 		break;
 	case BNXT_FW_STATUS_REG_TYPE_GRC:
 		offset = bnxt_map_reset_regs(bp, offset);
-- 
2.10.1

Re: [dpdk-dev] [PATCH] net/bnxt: fix unchecked return value

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

On Mon, Mar 15, 2021 at 10:19 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> CID 363716 (#1 of 1): Unchecked return value (CHECKED_RETURN)
> check_return: Calling rte_pci_write_config without checking
> return value (as is done elsewhere 46 out of 49 times).
>
> Coverity issue: 363716
>
> Fixes: be14720def9c ("net/bnxt: support FW reset")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Patch applied to dpdk-next-net-brcm.

> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 6cc6af0..202b082 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3860,13 +3860,19 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, uint32_t index)
>         uint32_t val = info->reset_reg_val[index];
>         uint32_t reg = info->reset_reg[index];
>         uint32_t type, offset;
> +       int ret;
>
>         type = BNXT_FW_STATUS_REG_TYPE(reg);
>         offset = BNXT_FW_STATUS_REG_OFF(reg);
>
>         switch (type) {
>         case BNXT_FW_STATUS_REG_TYPE_CFG:
> -               rte_pci_write_config(bp->pdev, &val, sizeof(val), offset);
> +               ret = rte_pci_write_config(bp->pdev, &val, sizeof(val), offset);
> +               if (ret < 0) {
> +                       PMD_DRV_LOG(ERR, "Failed to write %#x at PCI offset %#x",
> +                                   val, offset);
> +                       return;
> +               }
>                 break;
>         case BNXT_FW_STATUS_REG_TYPE_GRC:
>                 offset = bnxt_map_reset_regs(bp, offset);
> --
> 2.10.1
>