From: Xueming Li <xuemingl@nvidia.com> Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com> Subject: [dpdk-dev] [PATCH] eal: update all buses default scan mode Date: Tue, 16 Mar 2021 20:45:20 +0800 Message-ID: <20210316124520.19726-1-xuemingl@nvidia.com> (raw) When parsing EAL allowed or blocked device arguments, only device bus being parsed got default scan mode updated. If the devargs was vdev, PCI bus default scan mode not touched, all PCI bus devices will got probed even none appear in allowed list. This patch update all buses default scan mode when parsing first devargs. Signed-off-by: Xueming Li <xuemingl@nvidia.com> --- lib/librte_eal/common/eal_common_bus.c | 16 ++++++++++++++++ lib/librte_eal/common/eal_common_devargs.c | 13 +++++-------- lib/librte_eal/common/eal_private.h | 9 +++++++++ lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/version.map | 2 ++ 5 files changed, 33 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index baa5b532af..ebbb3995f6 100644 --- a/lib/librte_eal/common/eal_common_bus.c +++ b/lib/librte_eal/common/eal_common_bus.c @@ -277,3 +277,19 @@ rte_bus_sigbus_handler(const void *failure_addr) return ret; } + +static bool mode_set; + +void +rte_bus_scan_mode_update(enum rte_bus_scan_mode mode) +{ + struct rte_bus *bus; + + if (mode_set) + return; + TAILQ_FOREACH(bus, &rte_bus_list, next) { + if (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED) + bus->conf.scan_mode = mode; + } + mode_set = true; +} diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index fcf3d9a3cc..3aedcb5c09 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -301,7 +301,6 @@ int rte_devargs_add(enum rte_devtype devtype, const char *devargs_str) { struct rte_devargs *devargs = NULL; - struct rte_bus *bus = NULL; const char *dev = devargs_str; /* use calloc instead of rte_zmalloc as it's called early at init */ @@ -312,15 +311,13 @@ rte_devargs_add(enum rte_devtype devtype, const char *devargs_str) if (rte_devargs_parse(devargs, dev)) goto fail; devargs->type = devtype; - bus = devargs->bus; if (devargs->type == RTE_DEVTYPE_BLOCKED) devargs->policy = RTE_DEV_BLOCKED; - if (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED) { - if (devargs->policy == RTE_DEV_ALLOWED) - bus->conf.scan_mode = RTE_BUS_SCAN_ALLOWLIST; - else if (devargs->policy == RTE_DEV_BLOCKED) - bus->conf.scan_mode = RTE_BUS_SCAN_BLOCKLIST; - } + + if (devargs->policy == RTE_DEV_ALLOWED) + rte_bus_scan_mode_update(RTE_BUS_SCAN_ALLOWLIST); + else if (devargs->policy == RTE_DEV_BLOCKED) + rte_bus_scan_mode_update(RTE_BUS_SCAN_BLOCKLIST); TAILQ_INSERT_TAIL(&devargs_list, devargs, next); return 0; diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index b8a0d20021..78b07508ec 100644 --- a/lib/librte_eal/common/eal_private.h +++ b/lib/librte_eal/common/eal_private.h @@ -452,6 +452,15 @@ int rte_eal_memory_detach(void); */ struct rte_bus *rte_bus_find_by_device_name(const char *str); +/** + * Update all buses scan mode if not set, used by EAL parameter parsing. + * + * @param mode + * Bus scan mode to be set. + */ +__rte_internal +void rte_bus_scan_mode_update(enum rte_bus_scan_mode mode); + /** * Create the unix channel for primary/secondary communication. * diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 474cf123fa..2757f31461 100644 --- a/lib/librte_eal/rte_eal_exports.def +++ b/lib/librte_eal/rte_eal_exports.def @@ -11,6 +11,7 @@ EXPORTS rte_bus_probe rte_bus_register rte_bus_scan + rte_bus_scan_mode_update rte_bus_unregister rte_calloc rte_calloc_socket diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map index fce90a112f..171bca478d 100644 --- a/lib/librte_eal/version.map +++ b/lib/librte_eal/version.map @@ -417,6 +417,8 @@ EXPERIMENTAL { INTERNAL { global: + rte_bus_scan_mode_update; + rte_mem_lock; rte_mem_map; rte_mem_page_size; -- 2.25.1
next reply other threads:[~2021-03-16 12:45 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-16 12:45 Xueming Li [this message] 2021-03-22 23:32 ` Dmitry Kozlyuk 2021-03-23 9:33 ` Kinsella, Ray 2021-03-23 9:34 ` Kinsella, Ray 2021-03-23 9:57 ` Dmitry Kozlyuk 2021-03-23 9:58 ` Kinsella, Ray 2021-03-28 13:14 ` Xueming(Steven) Li 2021-03-28 13:12 ` [dpdk-dev] [PATCH v1] " Xueming Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210316124520.19726-1-xuemingl@nvidia.com \ --to=xuemingl@nvidia.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=dmitrym@microsoft.com \ --cc=mdr@ashroe.eu \ --cc=navasile@linux.microsoft.com \ --cc=nhorman@tuxdriver.com \ --cc=pallavi.kadam@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git