From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1522DA054F; Tue, 16 Mar 2021 15:12:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 922A926005B; Tue, 16 Mar 2021 15:12:48 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 93F104069F for <dev@dpdk.org>; Tue, 16 Mar 2021 15:12:47 +0100 (CET) IronPort-SDR: fJkBxgjtFvB8738hOGrrw+rJkaxs1bJFzlDcsgfbV5lcUaACMDyTTLP2Suv3bdNkyyAamSBDzo Skb2Ygm9BcJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="250628697" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="250628697" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 07:12:45 -0700 IronPort-SDR: VY1xoRVphc+hEpNFl+KrYI7oAOYb97zG0nAb463TR6UeNZ///M96ffdt+jPT/hPZcKQHEMTbDy pc8jEETBtpfg== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="412231051" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.24.239]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Mar 2021 07:12:41 -0700 Date: Tue, 16 Mar 2021 14:12:37 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Qi Zhang <qi.z.zhang@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com Message-ID: <20210316141237.GA163@bricha3-MOBL.ger.corp.intel.com> References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210312121223.2028029-2-qi.z.zhang@intel.com> <93fd4fce-a961-8ccf-fd32-0386461e4e99@intel.com> <8879674.o8TafV64eK@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8879674.o8TafV64eK@thomas> Subject: Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Mar 16, 2021 at 02:39:05PM +0100, Thomas Monjalon wrote: > 16/03/2021 14:05, Ferruh Yigit: > > On 3/12/2021 12:12 PM, Qi Zhang wrote: > > > PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as compile option to wrap > > > data path debug code. As .config has been removed since the meson build, > > > It is not friendly for new DPDK users to notice those debug options. > > > > > > The patch introduces below compile options for specific Rx/Tx data path > > > debug, so PMD can choose to reuse them to avoid maintain their own. > > > > > > - RTE_LIBRTE_ETHDEV_DEBUG_RX > > > - RTE_LIBRTE_ETHDEV_DEBUG_TX > > > > > > Also, all the compile options are documented on the overview page, so > > > users can easily find them. > > English question: is "compile option" correct, > or should it be "compilation option"? > Cc Bruce to have a native in the discussion :) > "compilation options" is better. However, throughout this patch, I wonder if "build" might be a better verb to use than "compile".