DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: declare extern "C" link when building with __cplusplus
@ 2021-03-17  5:33 Tyler Retzlaff
  2021-03-17  5:59 ` Stephen Hemminger
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Tyler Retzlaff @ 2021-03-17  5:33 UTC (permalink / raw)
  To: dev; +Cc: thomas, david.marchand, bruce.richardson

Add missing extern "C" linkage for rte_reciprocal.h consistent with
other eal headers.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/librte_eal/include/rte_reciprocal.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/librte_eal/include/rte_reciprocal.h b/lib/librte_eal/include/rte_reciprocal.h
index 735adb029..fa1cb4854 100644
--- a/lib/librte_eal/include/rte_reciprocal.h
+++ b/lib/librte_eal/include/rte_reciprocal.h
@@ -29,6 +29,10 @@
 
 #include <rte_common.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 struct rte_reciprocal {
 	uint32_t m;
 	uint8_t sh1, sh2;
@@ -89,4 +93,8 @@ rte_reciprocal_divide_u64(uint64_t a, const struct rte_reciprocal_u64 *R)
 struct rte_reciprocal rte_reciprocal_value(uint32_t d);
 struct rte_reciprocal_u64 rte_reciprocal_value_u64(uint64_t d);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _RTE_RECIPROCAL_H_ */
-- 
2.30.0.vfs.0.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: declare extern "C" link when building with __cplusplus
  2021-03-17  5:33 [dpdk-dev] [PATCH] eal: declare extern "C" link when building with __cplusplus Tyler Retzlaff
@ 2021-03-17  5:59 ` Stephen Hemminger
  2021-03-17  7:29 ` Dmitry Kozlyuk
  2021-03-17 16:14 ` [dpdk-dev] [PATCH v2] eal: declare extern "C" linkage " Tyler Retzlaff
  2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2021-03-17  5:59 UTC (permalink / raw)
  To: Tyler Retzlaff; +Cc: dev, thomas, david.marchand, bruce.richardson

On Tue, 16 Mar 2021 22:33:18 -0700
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:

> Add missing extern "C" linkage for rte_reciprocal.h consistent with
> other eal headers.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Looks good all exported headers should have this

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: declare extern "C" link when building with __cplusplus
  2021-03-17  5:33 [dpdk-dev] [PATCH] eal: declare extern "C" link when building with __cplusplus Tyler Retzlaff
  2021-03-17  5:59 ` Stephen Hemminger
@ 2021-03-17  7:29 ` Dmitry Kozlyuk
  2021-03-17 16:14 ` [dpdk-dev] [PATCH v2] eal: declare extern "C" linkage " Tyler Retzlaff
  2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Kozlyuk @ 2021-03-17  7:29 UTC (permalink / raw)
  To: Tyler Retzlaff; +Cc: dev, thomas, david.marchand, bruce.richardson

2021-03-16 22:33 (UTC-0700), Tyler Retzlaff:
> Add missing extern "C" linkage for rte_reciprocal.h consistent with
> other eal headers.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
>  lib/librte_eal/include/rte_reciprocal.h | 8 ++++++++
>  1 file changed, 8 insertions(+)

This is worth backporting:

	Fixes: ffe3ec811ef5 ("sched: introduce reciprocal divide")
	Cc: stable@dpdk.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v2] eal: declare extern "C" linkage when building with __cplusplus
  2021-03-17  5:33 [dpdk-dev] [PATCH] eal: declare extern "C" link when building with __cplusplus Tyler Retzlaff
  2021-03-17  5:59 ` Stephen Hemminger
  2021-03-17  7:29 ` Dmitry Kozlyuk
@ 2021-03-17 16:14 ` Tyler Retzlaff
  2021-04-15 14:21   ` David Marchand
  2 siblings, 1 reply; 5+ messages in thread
From: Tyler Retzlaff @ 2021-03-17 16:14 UTC (permalink / raw)
  To: dev
  Cc: stable, thomas, david.marchand, bruce.richardson, stephen,
	dmitry.kozliuk

Add missing extern "C" linkage for rte_reciprocal.h consistent with
other eal headers.

Fixes: ffe3ec811ef5 ("sched: introduce reciprocal divide")
Cc: stable@dpdk.org

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---

* fixed commit title line link->linkage
* added Fixes and Cc from dmitryk feedback

 lib/librte_eal/include/rte_reciprocal.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/librte_eal/include/rte_reciprocal.h b/lib/librte_eal/include/rte_reciprocal.h
index 735adb029..fa1cb4854 100644
--- a/lib/librte_eal/include/rte_reciprocal.h
+++ b/lib/librte_eal/include/rte_reciprocal.h
@@ -29,6 +29,10 @@
 
 #include <rte_common.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 struct rte_reciprocal {
 	uint32_t m;
 	uint8_t sh1, sh2;
@@ -89,4 +93,8 @@ rte_reciprocal_divide_u64(uint64_t a, const struct rte_reciprocal_u64 *R)
 struct rte_reciprocal rte_reciprocal_value(uint32_t d);
 struct rte_reciprocal_u64 rte_reciprocal_value_u64(uint64_t d);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _RTE_RECIPROCAL_H_ */
-- 
2.30.0.vfs.0.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] eal: declare extern "C" linkage when building with __cplusplus
  2021-03-17 16:14 ` [dpdk-dev] [PATCH v2] eal: declare extern "C" linkage " Tyler Retzlaff
@ 2021-04-15 14:21   ` David Marchand
  0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2021-04-15 14:21 UTC (permalink / raw)
  To: Tyler Retzlaff
  Cc: dev, dpdk stable, Thomas Monjalon, Bruce Richardson,
	Stephen Hemminger, Dmitry Kozlyuk

On Wed, Mar 17, 2021 at 5:14 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Add missing extern "C" linkage for rte_reciprocal.h consistent with
> other eal headers.
>
> Fixes: ffe3ec811ef5 ("sched: introduce reciprocal divide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-15 14:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17  5:33 [dpdk-dev] [PATCH] eal: declare extern "C" link when building with __cplusplus Tyler Retzlaff
2021-03-17  5:59 ` Stephen Hemminger
2021-03-17  7:29 ` Dmitry Kozlyuk
2021-03-17 16:14 ` [dpdk-dev] [PATCH v2] eal: declare extern "C" linkage " Tyler Retzlaff
2021-04-15 14:21   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).