* [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512
@ 2021-03-17 9:17 Leyi Rong
2021-03-24 10:40 ` Coyle, David
0 siblings, 1 reply; 3+ messages in thread
From: Leyi Rong @ 2021-03-17 9:17 UTC (permalink / raw)
To: qi.z.zhang, wenzhuo.lu, beilei.xing; +Cc: dev, Leyi Rong
Fix pkt_len parsing when DEV_RX_OFFLOAD_KEEP_CRC is set in AVX512 path.
Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx")
Fixes: 6df587028e57 ("net/iavf: enable AVX512 for flexible Rx")
Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c b/drivers/net/iavf/iavf_rxtx_vec_avx512.c
index 5cb4c7cda6..67184ae3f4 100644
--- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c
+++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c
@@ -380,7 +380,7 @@ _iavf_recv_raw_pkts_vec_avx512(struct iavf_rx_queue *rxq,
len4_7);
__m512i mb4_7 = _mm512_shuffle_epi8(desc4_7, shuf_msk);
- mb4_7 = _mm512_add_epi16(mb4_7, crc_adjust);
+ mb4_7 = _mm512_add_epi32(mb4_7, crc_adjust);
/**
* to get packet types, shift 64-bit values down 30 bits
* and so ptype is in lower 8-bits in each
@@ -411,7 +411,7 @@ _iavf_recv_raw_pkts_vec_avx512(struct iavf_rx_queue *rxq,
len0_3);
__m512i mb0_3 = _mm512_shuffle_epi8(desc0_3, shuf_msk);
- mb0_3 = _mm512_add_epi16(mb0_3, crc_adjust);
+ mb0_3 = _mm512_add_epi32(mb0_3, crc_adjust);
/* get the packet types */
const __m512i ptypes0_3 = _mm512_srli_epi64(desc0_3, 30);
const __m256i ptypes2_3 = _mm512_extracti64x4_epi64(ptypes0_3, 1);
@@ -869,7 +869,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct iavf_rx_queue *rxq,
*/
__m512i mb4_7 = _mm512_shuffle_epi8(raw_desc4_7, shuf_msk);
- mb4_7 = _mm512_add_epi16(mb4_7, crc_adjust);
+ mb4_7 = _mm512_add_epi32(mb4_7, crc_adjust);
/**
* to get packet types, ptype is located in bit16-25
* of each 128bits
@@ -898,7 +898,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct iavf_rx_queue *rxq,
*/
__m512i mb0_3 = _mm512_shuffle_epi8(raw_desc0_3, shuf_msk);
- mb0_3 = _mm512_add_epi16(mb0_3, crc_adjust);
+ mb0_3 = _mm512_add_epi32(mb0_3, crc_adjust);
/**
* to get packet types, ptype is located in bit16-25
* of each 128bits
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 2021-03-17 9:17 [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 Leyi Rong @ 2021-03-24 10:40 ` Coyle, David 2021-03-25 7:56 ` Zhang, Qi Z 0 siblings, 1 reply; 3+ messages in thread From: Coyle, David @ 2021-03-24 10:40 UTC (permalink / raw) To: Rong, Leyi, Zhang, Qi Z, Lu, Wenzhuo, Xing, Beilei; +Cc: dev, Rong, Leyi Hi Leyi > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Leyi Rong > Sent: Wednesday, March 17, 2021 9:18 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com> > Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com> > Subject: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 > > Fix pkt_len parsing when DEV_RX_OFFLOAD_KEEP_CRC is set in AVX512 > path. > > Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx") > Fixes: 6df587028e57 ("net/iavf: enable AVX512 for flexible Rx") > > Signed-off-by: Leyi Rong <leyi.rong@intel.com> > --- > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > index 5cb4c7cda6..67184ae3f4 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > +++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > @@ -380,7 +380,7 @@ _iavf_recv_raw_pkts_vec_avx512(struct > iavf_rx_queue *rxq, > len4_7); > __m512i mb4_7 = _mm512_shuffle_epi8(desc4_7, > shuf_msk); > > - mb4_7 = _mm512_add_epi16(mb4_7, crc_adjust); > + mb4_7 = _mm512_add_epi32(mb4_7, crc_adjust); > /** > * to get packet types, shift 64-bit values down 30 bits > * and so ptype is in lower 8-bits in each @@ -411,7 +411,7 > @@ _iavf_recv_raw_pkts_vec_avx512(struct iavf_rx_queue *rxq, > len0_3); > __m512i mb0_3 = _mm512_shuffle_epi8(desc0_3, > shuf_msk); > > - mb0_3 = _mm512_add_epi16(mb0_3, crc_adjust); > + mb0_3 = _mm512_add_epi32(mb0_3, crc_adjust); > /* get the packet types */ > const __m512i ptypes0_3 = _mm512_srli_epi64(desc0_3, 30); > const __m256i ptypes2_3 = > _mm512_extracti64x4_epi64(ptypes0_3, 1); @@ -869,7 +869,7 @@ > _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct iavf_rx_queue *rxq, > */ > __m512i mb4_7 = _mm512_shuffle_epi8(raw_desc4_7, > shuf_msk); > > - mb4_7 = _mm512_add_epi16(mb4_7, crc_adjust); > + mb4_7 = _mm512_add_epi32(mb4_7, crc_adjust); > /** > * to get packet types, ptype is located in bit16-25 > * of each 128bits > @@ -898,7 +898,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct > iavf_rx_queue *rxq, > */ > __m512i mb0_3 = _mm512_shuffle_epi8(raw_desc0_3, > shuf_msk); > > - mb0_3 = _mm512_add_epi16(mb0_3, crc_adjust); > + mb0_3 = _mm512_add_epi32(mb0_3, crc_adjust); > /** > * to get packet types, ptype is located in bit16-25 > * of each 128bits > -- > 2.25.1 This patch fixes the issue Tested-by: David Coyle <david.coyle@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 2021-03-24 10:40 ` Coyle, David @ 2021-03-25 7:56 ` Zhang, Qi Z 0 siblings, 0 replies; 3+ messages in thread From: Zhang, Qi Z @ 2021-03-25 7:56 UTC (permalink / raw) To: Coyle, David, Rong, Leyi, Lu, Wenzhuo, Xing, Beilei; +Cc: dev, Rong, Leyi > -----Original Message----- > From: Coyle, David <david.coyle@intel.com> > Sent: Wednesday, March 24, 2021 6:41 PM > To: Rong, Leyi <leyi.rong@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, > Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com> > Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com> > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 > > Hi Leyi > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Leyi Rong > > Sent: Wednesday, March 17, 2021 9:18 AM > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo > > <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com> > > Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com> > > Subject: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 > > > > Fix pkt_len parsing when DEV_RX_OFFLOAD_KEEP_CRC is set in AVX512 > > path. > > > > Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx") > > Fixes: 6df587028e57 ("net/iavf: enable AVX512 for flexible Rx") > > > > Signed-off-by: Leyi Rong <leyi.rong@intel.com> > > --- > > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > index 5cb4c7cda6..67184ae3f4 100644 > > --- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > +++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > @@ -380,7 +380,7 @@ _iavf_recv_raw_pkts_vec_avx512(struct > > iavf_rx_queue *rxq, > > len4_7); > > __m512i mb4_7 = _mm512_shuffle_epi8(desc4_7, shuf_msk); > > > > -mb4_7 = _mm512_add_epi16(mb4_7, crc_adjust); > > +mb4_7 = _mm512_add_epi32(mb4_7, crc_adjust); > > /** > > * to get packet types, shift 64-bit values down 30 bits > > * and so ptype is in lower 8-bits in each @@ -411,7 +411,7 @@ > > _iavf_recv_raw_pkts_vec_avx512(struct iavf_rx_queue *rxq, len0_3); > > __m512i mb0_3 = _mm512_shuffle_epi8(desc0_3, shuf_msk); > > > > -mb0_3 = _mm512_add_epi16(mb0_3, crc_adjust); > > +mb0_3 = _mm512_add_epi32(mb0_3, crc_adjust); > > /* get the packet types */ > > const __m512i ptypes0_3 = _mm512_srli_epi64(desc0_3, 30); const > > __m256i ptypes2_3 = _mm512_extracti64x4_epi64(ptypes0_3, 1); @@ > -869,7 > > +869,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct iavf_rx_queue > > *rxq, > > */ > > __m512i mb4_7 = _mm512_shuffle_epi8(raw_desc4_7, shuf_msk); > > > > -mb4_7 = _mm512_add_epi16(mb4_7, crc_adjust); > > +mb4_7 = _mm512_add_epi32(mb4_7, crc_adjust); > > /** > > * to get packet types, ptype is located in bit16-25 > > * of each 128bits > > @@ -898,7 +898,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct > > iavf_rx_queue *rxq, > > */ > > __m512i mb0_3 = _mm512_shuffle_epi8(raw_desc0_3, shuf_msk); > > > > -mb0_3 = _mm512_add_epi16(mb0_3, crc_adjust); > > +mb0_3 = _mm512_add_epi32(mb0_3, crc_adjust); > > /** > > * to get packet types, ptype is located in bit16-25 > > * of each 128bits > > -- > > 2.25.1 > > This patch fixes the issue > > Tested-by: David Coyle <david.coyle@intel.com> Applied to dpdk-next-net-intel Thanks Qi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-25 7:56 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-17 9:17 [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 Leyi Rong 2021-03-24 10:40 ` Coyle, David 2021-03-25 7:56 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).